Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(openai): fix esm tests #5163

Merged
merged 1 commit into from
Jan 30, 2025
Merged

ci(openai): fix esm tests #5163

merged 1 commit into from
Jan 30, 2025

Conversation

sabrenner
Copy link
Collaborator

@sabrenner sabrenner commented Jan 28, 2025

What does this PR do?

Fixes ESM tests by removing problematic nock headers for the request. Unsure why this doesn't affect unit tests but seems to work here for resolving the issue

Motivation

Fix CI

Copy link

github-actions bot commented Jan 28, 2025

Overall package size

Self size: 8.54 MB
Deduped: 94.94 MB
No deduping: 95.45 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.6.1 | 2.59 MB | 2.73 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.07%. Comparing base (fd61c8c) to head (7c2a144).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5163   +/-   ##
=======================================
  Coverage   81.06%   81.07%           
=======================================
  Files         477      479    +2     
  Lines       21327    21337   +10     
=======================================
+ Hits        17288    17298   +10     
  Misses       4039     4039           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Jan 28, 2025

Benchmarks

Benchmark execution time: 2025-01-30 16:53:27

Comparing candidate commit 7c2a144 in PR branch sabrenner/fix-openai-esm-tests with baseline commit fd61c8c in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 909 metrics, 24 unstable metrics.

@sabrenner sabrenner force-pushed the sabrenner/fix-openai-esm-tests branch from c9da507 to 9718edd Compare January 29, 2025 20:25
@sabrenner sabrenner marked this pull request as ready for review January 30, 2025 16:38
@sabrenner sabrenner requested a review from a team as a code owner January 30, 2025 16:38
@sabrenner sabrenner force-pushed the sabrenner/fix-openai-esm-tests branch from 9718edd to 7c2a144 Compare January 30, 2025 16:40
@sabrenner sabrenner enabled auto-merge (squash) January 30, 2025 16:42
@datadog-datadog-prod-us1
Copy link

Datadog Report

Branch report: sabrenner/fix-openai-esm-tests
Commit report: 10c6e38
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 616 Passed, 0 Skipped, 14m 50.54s Total Time

@sabrenner sabrenner merged commit bfdd3ad into master Jan 30, 2025
348 of 350 checks passed
@sabrenner sabrenner deleted the sabrenner/fix-openai-esm-tests branch January 30, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants