Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tracing): graphql error support #5162

Merged
merged 7 commits into from
Jan 29, 2025
Merged

Conversation

wconti27
Copy link
Contributor

@wconti27 wconti27 commented Jan 28, 2025

What does this PR do?

Adds error support for GraphQL using span events.

Motivation

Plugin Checklist

Additional Notes

@wconti27 wconti27 requested review from a team as code owners January 28, 2025 17:41
Copy link

github-actions bot commented Jan 28, 2025

Overall package size

Self size: 8.55 MB
Deduped: 94.94 MB
No deduping: 95.46 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.5.0 | 9.8 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.6.1 | 2.59 MB | 2.73 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.07%. Comparing base (f5bec49) to head (e4da707).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
packages/datadog-plugin-graphql/src/utils.js 89.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5162      +/-   ##
==========================================
+ Coverage   80.52%   81.07%   +0.54%     
==========================================
  Files         452      479      +27     
  Lines       20621    21338     +717     
==========================================
+ Hits        16605    17299     +694     
- Misses       4016     4039      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wconti27 wconti27 self-assigned this Jan 28, 2025
@wconti27 wconti27 requested a review from a team as a code owner January 28, 2025 18:13
@pr-commenter
Copy link

pr-commenter bot commented Jan 28, 2025

Benchmarks

Benchmark execution time: 2025-01-29 17:02:58

Comparing candidate commit e4da707 in PR branch conti/graphql-span-event-errors with baseline commit f5bec49 in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 909 metrics, 23 unstable metrics.

scenario:plugin-graphql-with-depth-on-max-18

  • 🟩 max_rss_usage [-69.047MB; -55.629MB] or [-7.082%; -5.706%]

@marcotc marcotc requested a review from tlhunter January 28, 2025 20:22
tlhunter
tlhunter previously approved these changes Jan 28, 2025
@wconti27 wconti27 merged commit 69426fb into master Jan 29, 2025
346 of 348 checks passed
@wconti27 wconti27 deleted the conti/graphql-span-event-errors branch January 29, 2025 20:20
szegedi pushed a commit that referenced this pull request Jan 30, 2025
* add graphql error reporting via span links
@szegedi szegedi mentioned this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants