Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: esbuild plugin when requiring esm files #4774

Merged
merged 6 commits into from
Oct 21, 2024
Merged

Conversation

crysmags
Copy link
Collaborator

@crysmags crysmags commented Oct 11, 2024

What does this PR do?

This is a fix related to a Jira issue: https://datadoghq.atlassian.net/browse/APMS-13434 where the customer was receiving an error when building using the esbuild plugin with esm modules.

Error: Build failed with 1 error:
node_modules ERROR: [plugin: datadog-esbuild] Package subpath './package.json' is not defined by "exports" in /Users/*/ddtrace-esbuild-repro/node_modules/@apollo/server/package.json

Motivation

Plugin Checklist

Additional Notes

@crysmags crysmags requested review from a team as code owners October 11, 2024 18:23
Copy link

github-actions bot commented Oct 11, 2024

Overall package size

Self size: 7.57 MB
Deduped: 62.31 MB
No deduping: 62.59 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.1.1 | 18.67 MB | 18.68 MB | | @datadog/native-iast-taint-tracking | 3.1.0 | 12.27 MB | 12.28 MB | | @datadog/pprof | 5.3.0 | 9.85 MB | 10.22 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.5.0 | 2.51 MB | 2.59 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 2.0.0 | 898.77 kB | 1.3 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | lru-cache | 7.14.0 | 74.95 kB | 74.95 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | path-to-regexp | 0.1.10 | 6.38 kB | 6.38 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@crysmags crysmags force-pushed the crysmags/esbuild_fix branch from 65137ab to 734655d Compare October 11, 2024 18:40
@pr-commenter
Copy link

pr-commenter bot commented Oct 11, 2024

Benchmarks

Benchmark execution time: 2024-10-21 18:29:35

Comparing candidate commit f19089d in PR branch crysmags/esbuild_fix with baseline commit 6e21f9a in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 260 metrics, 6 unstable metrics.

szegedi
szegedi previously approved these changes Oct 14, 2024
Copy link
Contributor

@szegedi szegedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crysmags crysmags force-pushed the crysmags/esbuild_fix branch from c08efa5 to 99869ea Compare October 21, 2024 14:57
@crysmags crysmags merged commit 597d7c5 into master Oct 21, 2024
198 checks passed
@crysmags crysmags deleted the crysmags/esbuild_fix branch October 21, 2024 19:26
@watson watson mentioned this pull request Oct 22, 2024
rochdev pushed a commit that referenced this pull request Oct 31, 2024
* fix esbuild issue when requiring esm files
rochdev pushed a commit that referenced this pull request Oct 31, 2024
* fix esbuild issue when requiring esm files
rochdev pushed a commit that referenced this pull request Oct 31, 2024
* fix esbuild issue when requiring esm files
rochdev pushed a commit that referenced this pull request Nov 6, 2024
* fix esbuild issue when requiring esm files
rochdev pushed a commit that referenced this pull request Nov 6, 2024
* fix esbuild issue when requiring esm files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants