-
Notifications
You must be signed in to change notification settings - Fork 315
Add telemetry to AI Guard evaluations #9884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
223ce1c to
036f183
Compare
|
🎯 Code Coverage 🔗 Commit SHA: b4114df | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 12 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~b4114df0a4, baseline=1.55.0-SNAPSHOT~96d5ea23eb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.029 s) : 0, 1029315
Total [baseline] (8.698 s) : 0, 8697813
Agent [candidate] (1.03 s) : 0, 1030356
Total [candidate] (8.716 s) : 0, 8715903
section iast
Agent [baseline] (1.162 s) : 0, 1161617
Total [baseline] (9.369 s) : 0, 9368666
Agent [candidate] (1.161 s) : 0, 1160796
Total [candidate] (9.372 s) : 0, 9371825
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~b4114df0a4, baseline=1.55.0-SNAPSHOT~96d5ea23eb
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.467 ms) : 0, 1467
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (701.877 ms) : 0, 701877
BytebuddyAgent [candidate] (702.329 ms) : 0, 702329
GlobalTracer [baseline] (244.523 ms) : 0, 244523
GlobalTracer [candidate] (245.064 ms) : 0, 245064
AppSec [baseline] (32.199 ms) : 0, 32199
AppSec [candidate] (32.435 ms) : 0, 32435
Debugger [baseline] (6.363 ms) : 0, 6363
Debugger [candidate] (6.39 ms) : 0, 6390
Remote Config [baseline] (685.886 µs) : 0, 686
Remote Config [candidate] (674.043 µs) : 0, 674
Telemetry [baseline] (14.515 ms) : 0, 14515
Telemetry [candidate] (13.699 ms) : 0, 13699
Flare Poller [baseline] (6.536 ms) : 0, 6536
Flare Poller [candidate] (7.157 ms) : 0, 7157
section iast
crashtracking [baseline] (1.47 ms) : 0, 1470
crashtracking [candidate] (1.474 ms) : 0, 1474
BytebuddyAgent [baseline] (824.234 ms) : 0, 824234
BytebuddyAgent [candidate] (823.99 ms) : 0, 823990
GlobalTracer [baseline] (233.579 ms) : 0, 233579
GlobalTracer [candidate] (233.433 ms) : 0, 233433
AppSec [baseline] (27.985 ms) : 0, 27985
AppSec [candidate] (28.818 ms) : 0, 28818
Debugger [baseline] (6.125 ms) : 0, 6125
Debugger [candidate] (6.101 ms) : 0, 6101
Remote Config [baseline] (607.941 µs) : 0, 608
Remote Config [candidate] (595.399 µs) : 0, 595
Telemetry [baseline] (8.452 ms) : 0, 8452
Telemetry [candidate] (8.446 ms) : 0, 8446
Flare Poller [baseline] (4.119 ms) : 0, 4119
Flare Poller [candidate] (4.085 ms) : 0, 4085
IAST [baseline] (33.735 ms) : 0, 33735
IAST [candidate] (32.696 ms) : 0, 32696
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~b4114df0a4, baseline=1.55.0-SNAPSHOT~96d5ea23eb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.036 s) : 0, 1036178
Total [baseline] (10.756 s) : 0, 10755751
Agent [candidate] (1.034 s) : 0, 1033843
Total [candidate] (10.911 s) : 0, 10911436
section appsec
Agent [baseline] (1.201 s) : 0, 1201404
Total [baseline] (11.084 s) : 0, 11083961
Agent [candidate] (1.201 s) : 0, 1201232
Total [candidate] (10.954 s) : 0, 10954460
section iast
Agent [baseline] (1.163 s) : 0, 1162710
Total [baseline] (11.154 s) : 0, 11154018
Agent [candidate] (1.162 s) : 0, 1161794
Total [candidate] (11.148 s) : 0, 11147533
section profiling
Agent [baseline] (1.172 s) : 0, 1171998
Total [baseline] (10.938 s) : 0, 10938397
Agent [candidate] (1.188 s) : 0, 1188026
Total [candidate] (10.943 s) : 0, 10943007
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~b4114df0a4, baseline=1.55.0-SNAPSHOT~96d5ea23eb
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.479 ms) : 0, 1479
crashtracking [candidate] (1.482 ms) : 0, 1482
BytebuddyAgent [baseline] (707.81 ms) : 0, 707810
BytebuddyAgent [candidate] (705.2 ms) : 0, 705200
GlobalTracer [baseline] (244.961 ms) : 0, 244961
GlobalTracer [candidate] (246.035 ms) : 0, 246035
AppSec [baseline] (32.506 ms) : 0, 32506
AppSec [candidate] (32.333 ms) : 0, 32333
Debugger [baseline] (6.438 ms) : 0, 6438
Debugger [candidate] (6.446 ms) : 0, 6446
Remote Config [baseline] (680.803 µs) : 0, 681
Remote Config [candidate] (688.9 µs) : 0, 689
Telemetry [baseline] (13.052 ms) : 0, 13052
Telemetry [candidate] (15.235 ms) : 0, 15235
Flare Poller [baseline] (7.914 ms) : 0, 7914
Flare Poller [candidate] (5.05 ms) : 0, 5050
section appsec
crashtracking [baseline] (1.477 ms) : 0, 1477
crashtracking [candidate] (1.464 ms) : 0, 1464
BytebuddyAgent [baseline] (724.86 ms) : 0, 724860
BytebuddyAgent [candidate] (725.162 ms) : 0, 725162
GlobalTracer [baseline] (235.834 ms) : 0, 235834
GlobalTracer [candidate] (236.079 ms) : 0, 236079
AppSec [baseline] (174.261 ms) : 0, 174261
AppSec [candidate] (173.672 ms) : 0, 173672
Debugger [baseline] (5.953 ms) : 0, 5953
Debugger [candidate] (5.905 ms) : 0, 5905
Remote Config [baseline] (624.296 µs) : 0, 624
Remote Config [candidate] (606.938 µs) : 0, 607
Telemetry [baseline] (8.444 ms) : 0, 8444
Telemetry [candidate] (8.356 ms) : 0, 8356
Flare Poller [baseline] (3.962 ms) : 0, 3962
Flare Poller [candidate] (3.898 ms) : 0, 3898
IAST [baseline] (24.862 ms) : 0, 24862
IAST [candidate] (24.95 ms) : 0, 24950
section iast
crashtracking [baseline] (1.471 ms) : 0, 1471
crashtracking [candidate] (1.474 ms) : 0, 1474
BytebuddyAgent [baseline] (824.566 ms) : 0, 824566
BytebuddyAgent [candidate] (823.931 ms) : 0, 823931
GlobalTracer [baseline] (234.682 ms) : 0, 234682
GlobalTracer [candidate] (234.114 ms) : 0, 234114
AppSec [baseline] (27.204 ms) : 0, 27204
AppSec [candidate] (29.1 ms) : 0, 29100
Debugger [baseline] (6.167 ms) : 0, 6167
Debugger [candidate] (6.108 ms) : 0, 6108
Remote Config [baseline] (600.444 µs) : 0, 600
Remote Config [candidate] (592.906 µs) : 0, 593
Telemetry [baseline] (8.369 ms) : 0, 8369
Telemetry [candidate] (8.371 ms) : 0, 8371
Flare Poller [baseline] (4.163 ms) : 0, 4163
Flare Poller [candidate] (4.202 ms) : 0, 4202
IAST [baseline] (34.26 ms) : 0, 34260
IAST [candidate] (32.511 ms) : 0, 32511
section profiling
crashtracking [baseline] (1.469 ms) : 0, 1469
crashtracking [candidate] (1.47 ms) : 0, 1470
BytebuddyAgent [baseline] (725.391 ms) : 0, 725391
BytebuddyAgent [candidate] (736.967 ms) : 0, 736967
GlobalTracer [baseline] (219.947 ms) : 0, 219947
GlobalTracer [candidate] (222.785 ms) : 0, 222785
AppSec [baseline] (32.257 ms) : 0, 32257
AppSec [candidate] (34.196 ms) : 0, 34196
Debugger [baseline] (10.762 ms) : 0, 10762
Debugger [candidate] (11.454 ms) : 0, 11454
Remote Config [baseline] (2.301 ms) : 0, 2301
Remote Config [candidate] (702.484 µs) : 0, 702
Telemetry [baseline] (10.721 ms) : 0, 10721
Telemetry [candidate] (9.792 ms) : 0, 9792
Flare Poller [baseline] (4.098 ms) : 0, 4098
Flare Poller [candidate] (4.202 ms) : 0, 4202
ProfilingAgent [baseline] (109.621 ms) : 0, 109621
ProfilingAgent [candidate] (110.335 ms) : 0, 110335
Profiling [baseline] (110.233 ms) : 0, 110233
Profiling [candidate] (110.983 ms) : 0, 110983
LoadParameters
See matching parameters
SummaryFound 5 performance improvements and 1 performance regressions! Performance is the same for 6 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~b4114df0a4, baseline=1.55.0-SNAPSHOT~96d5ea23eb
dateFormat X
axisFormat %s
section baseline
no_agent (1.202 ms) : 1191, 1214
. : milestone, 1202,
iast (3.261 ms) : 3218, 3303
. : milestone, 3261,
iast_FULL (5.886 ms) : 5827, 5946
. : milestone, 5886,
iast_GLOBAL (3.615 ms) : 3569, 3661
. : milestone, 3615,
profiling (2.084 ms) : 2066, 2103
. : milestone, 2084,
tracing (1.867 ms) : 1850, 1885
. : milestone, 1867,
section candidate
no_agent (1.204 ms) : 1192, 1216
. : milestone, 1204,
iast (3.398 ms) : 3354, 3442
. : milestone, 3398,
iast_FULL (5.766 ms) : 5709, 5822
. : milestone, 5766,
iast_GLOBAL (3.447 ms) : 3398, 3495
. : milestone, 3447,
profiling (1.922 ms) : 1906, 1937
. : milestone, 1922,
tracing (1.771 ms) : 1757, 1785
. : milestone, 1771,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~b4114df0a4, baseline=1.55.0-SNAPSHOT~96d5ea23eb
dateFormat X
axisFormat %s
section baseline
no_agent (19.306 ms) : 19106, 19506
. : milestone, 19306,
appsec (20.782 ms) : 20569, 20994
. : milestone, 20782,
code_origins (19.685 ms) : 19489, 19882
. : milestone, 19685,
iast (18.606 ms) : 18414, 18798
. : milestone, 18606,
profiling (19.525 ms) : 19329, 19721
. : milestone, 19525,
tracing (18.39 ms) : 18206, 18574
. : milestone, 18390,
section candidate
no_agent (19.053 ms) : 18855, 19251
. : milestone, 19053,
appsec (19.492 ms) : 19291, 19693
. : milestone, 19492,
code_origins (19.739 ms) : 19542, 19937
. : milestone, 19739,
iast (17.393 ms) : 17219, 17568
. : milestone, 17393,
profiling (19.598 ms) : 19396, 19800
. : milestone, 19598,
tracing (18.757 ms) : 18566, 18948
. : milestone, 18757,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~b4114df0a4, baseline=1.55.0-SNAPSHOT~96d5ea23eb
dateFormat X
axisFormat %s
section baseline
no_agent (1.488 ms) : 1477, 1500
. : milestone, 1488,
appsec (3.709 ms) : 3491, 3927
. : milestone, 3709,
iast (2.231 ms) : 2167, 2294
. : milestone, 2231,
iast_GLOBAL (2.273 ms) : 2209, 2336
. : milestone, 2273,
profiling (2.065 ms) : 2014, 2116
. : milestone, 2065,
tracing (2.042 ms) : 1992, 2091
. : milestone, 2042,
section candidate
no_agent (1.483 ms) : 1471, 1495
. : milestone, 1483,
appsec (3.656 ms) : 3444, 3869
. : milestone, 3656,
iast (2.23 ms) : 2166, 2293
. : milestone, 2230,
iast_GLOBAL (2.273 ms) : 2209, 2337
. : milestone, 2273,
profiling (2.078 ms) : 2025, 2131
. : milestone, 2078,
tracing (2.037 ms) : 1988, 2087
. : milestone, 2037,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~b4114df0a4, baseline=1.55.0-SNAPSHOT~96d5ea23eb
dateFormat X
axisFormat %s
section baseline
no_agent (15.307 s) : 15307000, 15307000
. : milestone, 15307000,
appsec (14.77 s) : 14770000, 14770000
. : milestone, 14770000,
iast (18.318 s) : 18318000, 18318000
. : milestone, 18318000,
iast_GLOBAL (18.118 s) : 18118000, 18118000
. : milestone, 18118000,
profiling (15.2 s) : 15200000, 15200000
. : milestone, 15200000,
tracing (15.23 s) : 15230000, 15230000
. : milestone, 15230000,
section candidate
no_agent (14.914 s) : 14914000, 14914000
. : milestone, 14914000,
appsec (14.968 s) : 14968000, 14968000
. : milestone, 14968000,
iast (18.543 s) : 18543000, 18543000
. : milestone, 18543000,
iast_GLOBAL (17.795 s) : 17795000, 17795000
. : milestone, 17795000,
profiling (15.869 s) : 15869000, 15869000
. : milestone, 15869000,
tracing (15.306 s) : 15306000, 15306000
. : milestone, 15306000,
|
036f183 to
4707290
Compare
dd-java-agent/agent-aiguard/src/main/java/com/datadog/aiguard/AIGuardInternal.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just a minor comment
01aed83 to
a6e4f7d
Compare
ef87f57 to
b4114df
Compare
What Does This Do
Adds telemetry to the AI Guard evaluations.
Motivation
We want to track customer usage of the SDK through telemetry metrics.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]