-
Notifications
You must be signed in to change notification settings - Fork 314
Exclude safeParse errors from telemetry #9770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~c97882c3b6, baseline=1.55.0-SNAPSHOT~4737935c38
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.015 s) : 0, 1014537
Total [baseline] (8.732 s) : 0, 8732115
Agent [candidate] (1.021 s) : 0, 1020575
Total [candidate] (8.681 s) : 0, 8681023
section iast
Agent [baseline] (1.173 s) : 0, 1173189
Total [baseline] (9.343 s) : 0, 9343200
Agent [candidate] (1.157 s) : 0, 1156889
Total [candidate] (9.314 s) : 0, 9313889
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~c97882c3b6, baseline=1.55.0-SNAPSHOT~4737935c38
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.455 ms) : 0, 1455
crashtracking [candidate] (1.483 ms) : 0, 1483
BytebuddyAgent [baseline] (692.644 ms) : 0, 692644
BytebuddyAgent [candidate] (695.302 ms) : 0, 695302
GlobalTracer [baseline] (241.923 ms) : 0, 241923
GlobalTracer [candidate] (242.533 ms) : 0, 242533
AppSec [baseline] (32.398 ms) : 0, 32398
AppSec [candidate] (32.216 ms) : 0, 32216
Debugger [baseline] (6.437 ms) : 0, 6437
Debugger [candidate] (6.413 ms) : 0, 6413
Remote Config [baseline] (703.388 µs) : 0, 703
Remote Config [candidate] (700.025 µs) : 0, 700
Telemetry [baseline] (9.238 ms) : 0, 9238
Telemetry [candidate] (9.325 ms) : 0, 9325
Flare Poller [baseline] (8.63 ms) : 0, 8630
Flare Poller [candidate] (11.522 ms) : 0, 11522
section iast
crashtracking [baseline] (1.512 ms) : 0, 1512
crashtracking [candidate] (1.491 ms) : 0, 1491
BytebuddyAgent [baseline] (831.843 ms) : 0, 831843
BytebuddyAgent [candidate] (819.443 ms) : 0, 819443
GlobalTracer [baseline] (235.375 ms) : 0, 235375
GlobalTracer [candidate] (232.583 ms) : 0, 232583
IAST [baseline] (27.172 ms) : 0, 27172
IAST [candidate] (26.671 ms) : 0, 26671
AppSec [baseline] (35.499 ms) : 0, 35499
AppSec [candidate] (35.297 ms) : 0, 35297
Debugger [baseline] (6.266 ms) : 0, 6266
Debugger [candidate] (6.21 ms) : 0, 6210
Remote Config [baseline] (623.231 µs) : 0, 623
Remote Config [candidate] (627.754 µs) : 0, 628
Telemetry [baseline] (8.891 ms) : 0, 8891
Telemetry [candidate] (8.723 ms) : 0, 8723
Flare Poller [baseline] (4.224 ms) : 0, 4224
Flare Poller [candidate] (4.22 ms) : 0, 4220
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~c97882c3b6, baseline=1.55.0-SNAPSHOT~4737935c38
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.017 s) : 0, 1017106
Total [baseline] (10.686 s) : 0, 10685810
Agent [candidate] (1.02 s) : 0, 1020057
Total [candidate] (10.832 s) : 0, 10832008
section appsec
Agent [baseline] (1.203 s) : 0, 1203118
Total [baseline] (11.035 s) : 0, 11035315
Agent [candidate] (1.198 s) : 0, 1197826
Total [candidate] (11.095 s) : 0, 11095192
section iast
Agent [baseline] (1.156 s) : 0, 1156051
Total [baseline] (11.08 s) : 0, 11079988
Agent [candidate] (1.16 s) : 0, 1160252
Total [candidate] (11.043 s) : 0, 11042744
section profiling
Agent [baseline] (1.172 s) : 0, 1172041
Total [baseline] (11.14 s) : 0, 11139972
Agent [candidate] (1.162 s) : 0, 1161725
Total [candidate] (11.061 s) : 0, 11060977
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~c97882c3b6, baseline=1.55.0-SNAPSHOT~4737935c38
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.468 ms) : 0, 1468
crashtracking [candidate] (1.469 ms) : 0, 1469
BytebuddyAgent [baseline] (692.862 ms) : 0, 692862
BytebuddyAgent [candidate] (694.569 ms) : 0, 694569
GlobalTracer [baseline] (242.134 ms) : 0, 242134
GlobalTracer [candidate] (242.88 ms) : 0, 242880
AppSec [baseline] (32.577 ms) : 0, 32577
AppSec [candidate] (32.476 ms) : 0, 32476
Debugger [baseline] (6.403 ms) : 0, 6403
Debugger [candidate] (6.402 ms) : 0, 6402
Remote Config [baseline] (701.26 µs) : 0, 701
Remote Config [candidate] (698.455 µs) : 0, 698
Telemetry [baseline] (9.403 ms) : 0, 9403
Telemetry [candidate] (9.454 ms) : 0, 9454
Flare Poller [baseline] (10.371 ms) : 0, 10371
Flare Poller [candidate] (10.901 ms) : 0, 10901
section appsec
crashtracking [baseline] (1.472 ms) : 0, 1472
crashtracking [candidate] (1.482 ms) : 0, 1482
BytebuddyAgent [baseline] (722.134 ms) : 0, 722134
BytebuddyAgent [candidate] (720.471 ms) : 0, 720471
GlobalTracer [baseline] (236.999 ms) : 0, 236999
GlobalTracer [candidate] (235.025 ms) : 0, 235025
IAST [baseline] (25.17 ms) : 0, 25170
IAST [candidate] (24.865 ms) : 0, 24865
AppSec [baseline] (175.886 ms) : 0, 175886
AppSec [candidate] (175.431 ms) : 0, 175431
Debugger [baseline] (6.182 ms) : 0, 6182
Debugger [candidate] (6.214 ms) : 0, 6214
Remote Config [baseline] (619.132 µs) : 0, 619
Remote Config [candidate] (636.029 µs) : 0, 636
Telemetry [baseline] (9.406 ms) : 0, 9406
Telemetry [candidate] (8.64 ms) : 0, 8640
Flare Poller [baseline] (4.026 ms) : 0, 4026
Flare Poller [candidate] (3.953 ms) : 0, 3953
section iast
crashtracking [baseline] (1.471 ms) : 0, 1471
crashtracking [candidate] (1.471 ms) : 0, 1471
BytebuddyAgent [baseline] (818.818 ms) : 0, 818818
BytebuddyAgent [candidate] (822.482 ms) : 0, 822482
GlobalTracer [baseline] (232.461 ms) : 0, 232461
GlobalTracer [candidate] (233.118 ms) : 0, 233118
IAST [baseline] (26.524 ms) : 0, 26524
IAST [candidate] (26.659 ms) : 0, 26659
AppSec [baseline] (35.438 ms) : 0, 35438
AppSec [candidate] (35.13 ms) : 0, 35130
Debugger [baseline] (6.159 ms) : 0, 6159
Debugger [candidate] (6.199 ms) : 0, 6199
Remote Config [baseline] (612.953 µs) : 0, 613
Remote Config [candidate] (614.701 µs) : 0, 615
Telemetry [baseline] (8.677 ms) : 0, 8677
Telemetry [candidate] (8.721 ms) : 0, 8721
Flare Poller [baseline] (4.239 ms) : 0, 4239
Flare Poller [candidate] (4.251 ms) : 0, 4251
section profiling
crashtracking [baseline] (1.452 ms) : 0, 1452
crashtracking [candidate] (1.438 ms) : 0, 1438
BytebuddyAgent [baseline] (728.016 ms) : 0, 728016
BytebuddyAgent [candidate] (721.032 ms) : 0, 721032
GlobalTracer [baseline] (219.627 ms) : 0, 219627
GlobalTracer [candidate] (218.226 ms) : 0, 218226
AppSec [baseline] (32.766 ms) : 0, 32766
AppSec [candidate] (32.303 ms) : 0, 32303
Debugger [baseline] (6.548 ms) : 0, 6548
Debugger [candidate] (6.504 ms) : 0, 6504
Remote Config [baseline] (758.583 µs) : 0, 759
Remote Config [candidate] (813.183 µs) : 0, 813
Telemetry [baseline] (15.798 ms) : 0, 15798
Telemetry [candidate] (15.229 ms) : 0, 15229
Flare Poller [baseline] (4.95 ms) : 0, 4950
Flare Poller [candidate] (4.977 ms) : 0, 4977
ProfilingAgent [baseline] (108.097 ms) : 0, 108097
ProfilingAgent [candidate] (108.401 ms) : 0, 108401
Profiling [baseline] (109.727 ms) : 0, 109727
Profiling [candidate] (109.273 ms) : 0, 109273
LoadParameters
See matching parameters
SummaryFound 5 performance improvements and 1 performance regressions! Performance is the same for 6 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~c97882c3b6, baseline=1.55.0-SNAPSHOT~4737935c38
dateFormat X
axisFormat %s
section baseline
no_agent (4.571 ms) : 4511, 4630
. : milestone, 4571,
iast (9.596 ms) : 9438, 9754
. : milestone, 9596,
iast_FULL (14.716 ms) : 14420, 15013
. : milestone, 14716,
iast_GLOBAL (11.23 ms) : 11028, 11431
. : milestone, 11230,
profiling (8.467 ms) : 8332, 8603
. : milestone, 8467,
tracing (7.777 ms) : 7666, 7888
. : milestone, 7777,
section candidate
no_agent (4.384 ms) : 4334, 4434
. : milestone, 4384,
iast (9.833 ms) : 9669, 9997
. : milestone, 9833,
iast_FULL (14.183 ms) : 13897, 14469
. : milestone, 14183,
iast_GLOBAL (10.834 ms) : 10642, 11026
. : milestone, 10834,
profiling (9.151 ms) : 9006, 9296
. : milestone, 9151,
tracing (7.517 ms) : 7411, 7622
. : milestone, 7517,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~c97882c3b6, baseline=1.55.0-SNAPSHOT~4737935c38
dateFormat X
axisFormat %s
section baseline
no_agent (38.346 ms) : 38030, 38662
. : milestone, 38346,
appsec (50.651 ms) : 50201, 51101
. : milestone, 50651,
code_origins (46.528 ms) : 46116, 46940
. : milestone, 46528,
iast (47.415 ms) : 47011, 47819
. : milestone, 47415,
profiling (49.102 ms) : 48641, 49563
. : milestone, 49102,
tracing (45.618 ms) : 45227, 46008
. : milestone, 45618,
section candidate
no_agent (36.598 ms) : 36308, 36888
. : milestone, 36598,
appsec (48.65 ms) : 48220, 49079
. : milestone, 48650,
code_origins (44.326 ms) : 43931, 44721
. : milestone, 44326,
iast (46.366 ms) : 45969, 46762
. : milestone, 46366,
profiling (49.599 ms) : 49136, 50063
. : milestone, 49599,
tracing (42.97 ms) : 42603, 43337
. : milestone, 42970,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~c97882c3b6, baseline=1.55.0-SNAPSHOT~4737935c38
dateFormat X
axisFormat %s
section baseline
no_agent (1.483 ms) : 1472, 1495
. : milestone, 1483,
appsec (3.736 ms) : 3517, 3954
. : milestone, 3736,
iast (2.212 ms) : 2148, 2275
. : milestone, 2212,
iast_GLOBAL (2.26 ms) : 2196, 2324
. : milestone, 2260,
profiling (2.074 ms) : 2022, 2127
. : milestone, 2074,
tracing (2.029 ms) : 1979, 2078
. : milestone, 2029,
section candidate
no_agent (1.485 ms) : 1474, 1497
. : milestone, 1485,
appsec (3.713 ms) : 3494, 3931
. : milestone, 3713,
iast (2.224 ms) : 2160, 2287
. : milestone, 2224,
iast_GLOBAL (2.264 ms) : 2200, 2328
. : milestone, 2264,
profiling (2.071 ms) : 2018, 2124
. : milestone, 2071,
tracing (2.039 ms) : 1990, 2089
. : milestone, 2039,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~c97882c3b6, baseline=1.55.0-SNAPSHOT~4737935c38
dateFormat X
axisFormat %s
section baseline
no_agent (15.68 s) : 15680000, 15680000
. : milestone, 15680000,
appsec (14.987 s) : 14987000, 14987000
. : milestone, 14987000,
iast (18.324 s) : 18324000, 18324000
. : milestone, 18324000,
iast_GLOBAL (18.186 s) : 18186000, 18186000
. : milestone, 18186000,
profiling (15.317 s) : 15317000, 15317000
. : milestone, 15317000,
tracing (15.011 s) : 15011000, 15011000
. : milestone, 15011000,
section candidate
no_agent (14.98 s) : 14980000, 14980000
. : milestone, 14980000,
appsec (15.159 s) : 15159000, 15159000
. : milestone, 15159000,
iast (18.414 s) : 18414000, 18414000
. : milestone, 18414000,
iast_GLOBAL (18.089 s) : 18089000, 18089000
. : milestone, 18089000,
profiling (15.095 s) : 15095000, 15095000
. : milestone, 15095000,
tracing (15.257 s) : 15257000, 15257000
. : milestone, 15257000,
|
|
🎯 Code Coverage 🔗 Commit SHA: c97882c | Docs | Was this helpful? Give us feedback! |
What Does This Do
Those exceptions are logged for debug BUT should not go in the telemetry since they are catched regularly
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]