-
Notifications
You must be signed in to change notification settings - Fork 313
Default LLM Observability ML Application to Service Name #9415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sabrenner
wants to merge
2
commits into
master
Choose a base branch
from
sabrenner/llmobs-ml-app-optional
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 12 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~b61f1d49e0, baseline=1.53.0-SNAPSHOT~da2930a64d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.049 s) : 0, 1048654
Total [baseline] (8.639 s) : 0, 8638917
Agent [candidate] (1.052 s) : 0, 1051933
Total [candidate] (8.619 s) : 0, 8619451
section iast
Agent [baseline] (1.182 s) : 0, 1181899
Total [baseline] (9.405 s) : 0, 9405093
Agent [candidate] (1.197 s) : 0, 1197434
Total [candidate] (9.362 s) : 0, 9361827
gantt
title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~b61f1d49e0, baseline=1.53.0-SNAPSHOT~da2930a64d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.452 ms) : 0, 1452
BytebuddyAgent [baseline] (734.189 ms) : 0, 734189
BytebuddyAgent [candidate] (735.81 ms) : 0, 735810
GlobalTracer [baseline] (242.725 ms) : 0, 242725
GlobalTracer [candidate] (243.717 ms) : 0, 243717
AppSec [baseline] (30.168 ms) : 0, 30168
AppSec [candidate] (30.241 ms) : 0, 30241
Debugger [baseline] (6.076 ms) : 0, 6076
Debugger [candidate] (6.091 ms) : 0, 6091
Remote Config [baseline] (670.285 µs) : 0, 670
Remote Config [candidate] (669.79 µs) : 0, 670
Telemetry [baseline] (12.346 ms) : 0, 12346
Telemetry [candidate] (12.932 ms) : 0, 12932
section iast
crashtracking [baseline] (1.459 ms) : 0, 1459
crashtracking [candidate] (1.477 ms) : 0, 1477
BytebuddyAgent [baseline] (852.948 ms) : 0, 852948
BytebuddyAgent [candidate] (865.261 ms) : 0, 865261
GlobalTracer [baseline] (235.267 ms) : 0, 235267
GlobalTracer [candidate] (235.268 ms) : 0, 235268
IAST [baseline] (28.687 ms) : 0, 28687
IAST [candidate] (30.161 ms) : 0, 30161
AppSec [baseline] (26.112 ms) : 0, 26112
AppSec [candidate] (27.413 ms) : 0, 27413
Debugger [baseline] (7.507 ms) : 0, 7507
Debugger [candidate] (7.49 ms) : 0, 7490
Remote Config [baseline] (618.475 µs) : 0, 618
Remote Config [candidate] (621.121 µs) : 0, 621
Telemetry [baseline] (8.26 ms) : 0, 8260
Telemetry [candidate] (8.518 ms) : 0, 8518
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~b61f1d49e0, baseline=1.53.0-SNAPSHOT~da2930a64d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1046978
Total [baseline] (10.695 s) : 0, 10694510
Agent [candidate] (1.048 s) : 0, 1047541
Total [candidate] (10.656 s) : 0, 10655731
section appsec
Agent [baseline] (1.225 s) : 0, 1224548
Total [baseline] (10.836 s) : 0, 10835830
Agent [candidate] (1.227 s) : 0, 1227039
Total [candidate] (10.838 s) : 0, 10837803
section iast
Agent [baseline] (1.19 s) : 0, 1189505
Total [baseline] (10.961 s) : 0, 10960919
Agent [candidate] (1.182 s) : 0, 1181894
Total [candidate] (11.024 s) : 0, 11024436
section profiling
Agent [baseline] (1.2 s) : 0, 1199705
Total [baseline] (10.914 s) : 0, 10913604
Agent [candidate] (1.21 s) : 0, 1209904
Total [candidate] (11.002 s) : 0, 11001589
gantt
title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~b61f1d49e0, baseline=1.53.0-SNAPSHOT~da2930a64d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.449 ms) : 0, 1449
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (732.604 ms) : 0, 732604
BytebuddyAgent [candidate] (733.419 ms) : 0, 733419
GlobalTracer [baseline] (242.798 ms) : 0, 242798
GlobalTracer [candidate] (243.157 ms) : 0, 243157
AppSec [baseline] (30.145 ms) : 0, 30145
AppSec [candidate] (30.158 ms) : 0, 30158
Debugger [baseline] (6.033 ms) : 0, 6033
Debugger [candidate] (6.06 ms) : 0, 6060
Remote Config [baseline] (669.025 µs) : 0, 669
Remote Config [candidate] (669.627 µs) : 0, 670
Telemetry [baseline] (12.214 ms) : 0, 12214
Telemetry [candidate] (11.464 ms) : 0, 11464
section appsec
crashtracking [baseline] (1.448 ms) : 0, 1448
crashtracking [candidate] (1.475 ms) : 0, 1475
BytebuddyAgent [baseline] (755.892 ms) : 0, 755892
BytebuddyAgent [candidate] (757.854 ms) : 0, 757854
GlobalTracer [baseline] (235.351 ms) : 0, 235351
GlobalTracer [candidate] (236.417 ms) : 0, 236417
AppSec [baseline] (168.163 ms) : 0, 168163
AppSec [candidate] (170.827 ms) : 0, 170827
Debugger [baseline] (6.633 ms) : 0, 6633
Debugger [candidate] (6.468 ms) : 0, 6468
Remote Config [baseline] (642.591 µs) : 0, 643
Remote Config [candidate] (633.322 µs) : 0, 633
Telemetry [baseline] (11.613 ms) : 0, 11613
Telemetry [candidate] (8.504 ms) : 0, 8504
IAST [baseline] (23.614 ms) : 0, 23614
IAST [candidate] (23.638 ms) : 0, 23638
section iast
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (859.148 ms) : 0, 859148
BytebuddyAgent [candidate] (853.236 ms) : 0, 853236
GlobalTracer [baseline] (234.715 ms) : 0, 234715
GlobalTracer [candidate] (234.55 ms) : 0, 234550
AppSec [baseline] (26.205 ms) : 0, 26205
AppSec [candidate] (27.726 ms) : 0, 27726
Debugger [baseline] (6.632 ms) : 0, 6632
Debugger [candidate] (5.756 ms) : 0, 5756
Remote Config [baseline] (606.116 µs) : 0, 606
Remote Config [candidate] (584.496 µs) : 0, 584
Telemetry [baseline] (8.348 ms) : 0, 8348
Telemetry [candidate] (8.169 ms) : 0, 8169
IAST [baseline] (31.263 ms) : 0, 31263
IAST [candidate] (29.32 ms) : 0, 29320
section profiling
ProfilingAgent [baseline] (107.881 ms) : 0, 107881
ProfilingAgent [candidate] (109.199 ms) : 0, 109199
crashtracking [baseline] (1.435 ms) : 0, 1435
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (764.157 ms) : 0, 764157
BytebuddyAgent [candidate] (771.556 ms) : 0, 771556
GlobalTracer [baseline] (223.094 ms) : 0, 223094
GlobalTracer [candidate] (223.491 ms) : 0, 223491
AppSec [baseline] (30.113 ms) : 0, 30113
AppSec [candidate] (30.306 ms) : 0, 30306
Debugger [baseline] (6.292 ms) : 0, 6292
Debugger [candidate] (6.378 ms) : 0, 6378
Remote Config [baseline] (750.372 µs) : 0, 750
Remote Config [candidate] (716.448 µs) : 0, 716
Telemetry [baseline] (16.155 ms) : 0, 16155
Telemetry [candidate] (16.473 ms) : 0, 16473
Profiling [baseline] (108.548 ms) : 0, 108548
Profiling [candidate] (109.855 ms) : 0, 109855
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 1 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~b61f1d49e0, baseline=1.53.0-SNAPSHOT~da2930a64d
dateFormat X
axisFormat %s
section baseline
no_agent (4.302 ms) : 4252, 4353
. : milestone, 4302,
iast (9.32 ms) : 9166, 9474
. : milestone, 9320,
iast_FULL (14.235 ms) : 13952, 14519
. : milestone, 14235,
iast_GLOBAL (10.243 ms) : 10053, 10434
. : milestone, 10243,
profiling (8.724 ms) : 8583, 8866
. : milestone, 8724,
tracing (7.617 ms) : 7511, 7723
. : milestone, 7617,
section candidate
no_agent (4.349 ms) : 4300, 4397
. : milestone, 4349,
iast (9.104 ms) : 8958, 9251
. : milestone, 9104,
iast_FULL (14.301 ms) : 14016, 14585
. : milestone, 14301,
iast_GLOBAL (9.878 ms) : 9704, 10052
. : milestone, 9878,
profiling (8.758 ms) : 8614, 8901
. : milestone, 8758,
tracing (7.817 ms) : 7701, 7932
. : milestone, 7817,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~b61f1d49e0, baseline=1.53.0-SNAPSHOT~da2930a64d
dateFormat X
axisFormat %s
section baseline
no_agent (37.627 ms) : 37325, 37930
. : milestone, 37627,
appsec (47.657 ms) : 47225, 48090
. : milestone, 47657,
code_origins (44.654 ms) : 44271, 45037
. : milestone, 44654,
iast (46.563 ms) : 46161, 46964
. : milestone, 46563,
profiling (49.232 ms) : 48760, 49705
. : milestone, 49232,
tracing (42.574 ms) : 42217, 42932
. : milestone, 42574,
section candidate
no_agent (37.266 ms) : 36962, 37569
. : milestone, 37266,
appsec (45.984 ms) : 45573, 46395
. : milestone, 45984,
code_origins (46.355 ms) : 45960, 46751
. : milestone, 46355,
iast (44.452 ms) : 44066, 44837
. : milestone, 44452,
profiling (47.487 ms) : 47056, 47918
. : milestone, 47487,
tracing (43.2 ms) : 42820, 43581
. : milestone, 43200,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~b61f1d49e0, baseline=1.53.0-SNAPSHOT~da2930a64d
dateFormat X
axisFormat %s
section baseline
no_agent (15.473 s) : 15473000, 15473000
. : milestone, 15473000,
appsec (14.795 s) : 14795000, 14795000
. : milestone, 14795000,
iast (18.322 s) : 18322000, 18322000
. : milestone, 18322000,
iast_GLOBAL (18.054 s) : 18054000, 18054000
. : milestone, 18054000,
profiling (15.254 s) : 15254000, 15254000
. : milestone, 15254000,
tracing (15.035 s) : 15035000, 15035000
. : milestone, 15035000,
section candidate
no_agent (14.965 s) : 14965000, 14965000
. : milestone, 14965000,
appsec (14.966 s) : 14966000, 14966000
. : milestone, 14966000,
iast (18.29 s) : 18290000, 18290000
. : milestone, 18290000,
iast_GLOBAL (17.521 s) : 17521000, 17521000
. : milestone, 17521000,
profiling (15.281 s) : 15281000, 15281000
. : milestone, 15281000,
tracing (14.925 s) : 14925000, 14925000
. : milestone, 14925000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~b61f1d49e0, baseline=1.53.0-SNAPSHOT~da2930a64d
dateFormat X
axisFormat %s
section baseline
no_agent (1.481 ms) : 1469, 1492
. : milestone, 1481,
appsec (3.674 ms) : 3455, 3892
. : milestone, 3674,
iast (2.215 ms) : 2152, 2278
. : milestone, 2215,
iast_GLOBAL (2.251 ms) : 2187, 2314
. : milestone, 2251,
profiling (2.049 ms) : 1998, 2100
. : milestone, 2049,
tracing (2.014 ms) : 1965, 2063
. : milestone, 2014,
section candidate
no_agent (1.48 ms) : 1468, 1491
. : milestone, 1480,
appsec (3.655 ms) : 3440, 3871
. : milestone, 3655,
iast (2.212 ms) : 2149, 2275
. : milestone, 2212,
iast_GLOBAL (2.247 ms) : 2184, 2311
. : milestone, 2247,
profiling (2.072 ms) : 2019, 2124
. : milestone, 2072,
tracing (2.036 ms) : 1987, 2086
. : milestone, 2036,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Makes the
dd.llmobs.ml.app
orDD_LLMOBS_ML_APP
configurations optional by removing anIllegalArgumentException
when it is eithernull
or empty, instead defaulting to the service name.Motivation
Easier onboarding for LLM Observability. Often, when there is no clear direction for an ML application configuration, and/or it aligns directly with the service itself, it's more friction to figure out what value ML application should take, especially after seeing a hard exception thrown during configuration when you just want to enable LLM Observability. This change seeks to reduce that friction by just defaulting it to the service name. A user can still set it to something better suited for an ML application description/name, especially if the service hosts multiple ML applications
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: MLOB-3635