-
Notifications
You must be signed in to change notification settings - Fork 312
Daniel.mohedano/logs backend logging #9411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
) * Make rum injector stream/writer more resilient to errors (cherry picked from commit a298c60) * fix tests (cherry picked from commit 62acf7c) * fix tests (cherry picked from commit 5a32d51) * Update dd-java-agent/agent-bootstrap/src/main/java/datadog/trace/bootstrap/instrumentation/buffer/InjectingPipeOutputStream.java Co-authored-by: Stuart McCulloch <[email protected]> (cherry picked from commit 87d15fb) * apply suggestions (cherry picked from commit 21afeb2) --------- Co-authored-by: Stuart McCulloch <[email protected]>
#9342) * Make rum injector stream/writer more resilient to errors (cherry picked from commit 36246b4) * fix tests (cherry picked from commit 993bf57) * Improve RUM injection matching and avoid truncating responses (cherry picked from commit f46c8f1) * Use MH for setContentLengthLong since available from 3.1 (cherry picked from commit 13753c1) * Fix tomcat11 tests (cherry picked from commit 4fb4129) * Update dd-smoke-tests/rum/src/main/groovy/datadog/smoketest/rum/AbstractRumServerSmokeTest.groovy Co-authored-by: Bruce Bujon <[email protected]> (cherry picked from commit 4b44a38) * Update dd-smoke-tests/rum/src/main/groovy/datadog/smoketest/rum/AbstractRumServerSmokeTest.groovy Co-authored-by: Bruce Bujon <[email protected]> (cherry picked from commit d7e1fdf) * remove leftover (cherry picked from commit 22e5389) --------- Co-authored-by: Bruce Bujon <[email protected]>
Backport #9355 to release/v1.52.x
(cherry picked from commit ffa80b2)
🎯 Code Coverage 🔗 Commit SHA: 61dc0f2 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 13 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~61dc0f2001, baseline=1.53.0-SNAPSHOT~0ce85a2743
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1056065
Total [baseline] (10.762 s) : 0, 10762277
Agent [candidate] (1.049 s) : 0, 1049184
Total [candidate] (10.737 s) : 0, 10736771
section appsec
Agent [baseline] (1.226 s) : 0, 1225785
Total [baseline] (10.857 s) : 0, 10856536
Agent [candidate] (1.223 s) : 0, 1223152
Total [candidate] (10.756 s) : 0, 10756028
section iast
Agent [baseline] (1.19 s) : 0, 1189842
Total [baseline] (11.074 s) : 0, 11074180
Agent [candidate] (1.176 s) : 0, 1176465
Total [candidate] (10.886 s) : 0, 10885597
section profiling
Agent [baseline] (1.2 s) : 0, 1200419
Total [baseline] (10.852 s) : 0, 10851796
Agent [candidate] (1.202 s) : 0, 1201521
Total [candidate] (10.979 s) : 0, 10978517
gantt
title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~61dc0f2001, baseline=1.53.0-SNAPSHOT~0ce85a2743
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.475 ms) : 0, 1475
crashtracking [candidate] (1.452 ms) : 0, 1452
BytebuddyAgent [baseline] (739.544 ms) : 0, 739544
BytebuddyAgent [candidate] (734.694 ms) : 0, 734694
GlobalTracer [baseline] (243.897 ms) : 0, 243897
GlobalTracer [candidate] (242.93 ms) : 0, 242930
AppSec [baseline] (30.207 ms) : 0, 30207
AppSec [candidate] (30.122 ms) : 0, 30122
Debugger [baseline] (6.085 ms) : 0, 6085
Debugger [candidate] (6.045 ms) : 0, 6045
Remote Config [baseline] (668.517 µs) : 0, 669
Remote Config [candidate] (674.243 µs) : 0, 674
Telemetry [baseline] (12.83 ms) : 0, 12830
Telemetry [candidate] (12.087 ms) : 0, 12087
section appsec
crashtracking [baseline] (1.494 ms) : 0, 1494
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (757.204 ms) : 0, 757204
BytebuddyAgent [candidate] (754.845 ms) : 0, 754845
GlobalTracer [baseline] (236.001 ms) : 0, 236001
GlobalTracer [candidate] (235.295 ms) : 0, 235295
IAST [baseline] (23.463 ms) : 0, 23463
IAST [candidate] (23.525 ms) : 0, 23525
AppSec [baseline] (170.723 ms) : 0, 170723
AppSec [candidate] (165.86 ms) : 0, 165860
Debugger [baseline] (6.577 ms) : 0, 6577
Debugger [candidate] (8.888 ms) : 0, 8888
Remote Config [baseline] (647.369 µs) : 0, 647
Remote Config [candidate] (656.971 µs) : 0, 657
Telemetry [baseline] (8.451 ms) : 0, 8451
Telemetry [candidate] (11.522 ms) : 0, 11522
section iast
crashtracking [baseline] (1.475 ms) : 0, 1475
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (858.792 ms) : 0, 858792
BytebuddyAgent [candidate] (849.224 ms) : 0, 849224
GlobalTracer [baseline] (234.932 ms) : 0, 234932
GlobalTracer [candidate] (231.911 ms) : 0, 231911
IAST [baseline] (31.484 ms) : 0, 31484
IAST [candidate] (30.178 ms) : 0, 30178
AppSec [baseline] (27.004 ms) : 0, 27004
AppSec [candidate] (27.188 ms) : 0, 27188
Debugger [baseline] (5.856 ms) : 0, 5856
Debugger [candidate] (6.723 ms) : 0, 6723
Remote Config [baseline] (619.892 µs) : 0, 620
Remote Config [candidate] (615.353 µs) : 0, 615
Telemetry [baseline] (8.432 ms) : 0, 8432
Telemetry [candidate] (8.131 ms) : 0, 8131
section profiling
crashtracking [baseline] (1.437 ms) : 0, 1437
crashtracking [candidate] (1.417 ms) : 0, 1417
BytebuddyAgent [baseline] (764.131 ms) : 0, 764131
BytebuddyAgent [candidate] (764.459 ms) : 0, 764459
GlobalTracer [baseline] (222.994 ms) : 0, 222994
GlobalTracer [candidate] (222.15 ms) : 0, 222150
AppSec [baseline] (30.184 ms) : 0, 30184
AppSec [candidate] (30.525 ms) : 0, 30525
Debugger [baseline] (6.282 ms) : 0, 6282
Debugger [candidate] (6.395 ms) : 0, 6395
Remote Config [baseline] (721.1 µs) : 0, 721
Remote Config [candidate] (738.623 µs) : 0, 739
Telemetry [baseline] (16.725 ms) : 0, 16725
Telemetry [candidate] (16.384 ms) : 0, 16384
ProfilingAgent [baseline] (108.043 ms) : 0, 108043
ProfilingAgent [candidate] (109.578 ms) : 0, 109578
Profiling [baseline] (108.682 ms) : 0, 108682
Profiling [candidate] (110.222 ms) : 0, 110222
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~61dc0f2001, baseline=1.53.0-SNAPSHOT~0ce85a2743
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.048 s) : 0, 1048243
Total [baseline] (8.625 s) : 0, 8625245
Agent [candidate] (1.057 s) : 0, 1057272
Total [candidate] (8.668 s) : 0, 8668437
section iast
Agent [baseline] (1.184 s) : 0, 1183723
Total [baseline] (9.348 s) : 0, 9347817
Agent [candidate] (1.185 s) : 0, 1184988
Total [candidate] (9.322 s) : 0, 9321796
gantt
title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~61dc0f2001, baseline=1.53.0-SNAPSHOT~0ce85a2743
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.464 ms) : 0, 1464
crashtracking [candidate] (1.464 ms) : 0, 1464
BytebuddyAgent [baseline] (734.556 ms) : 0, 734556
BytebuddyAgent [candidate] (740.598 ms) : 0, 740598
GlobalTracer [baseline] (243.27 ms) : 0, 243270
GlobalTracer [candidate] (244.491 ms) : 0, 244491
AppSec [baseline] (30.187 ms) : 0, 30187
AppSec [candidate] (30.486 ms) : 0, 30486
Debugger [baseline] (6.116 ms) : 0, 6116
Debugger [candidate] (6.065 ms) : 0, 6065
Remote Config [baseline] (674.192 µs) : 0, 674
Remote Config [candidate] (681.562 µs) : 0, 682
Telemetry [baseline] (10.912 ms) : 0, 10912
Telemetry [candidate] (12.236 ms) : 0, 12236
section iast
crashtracking [baseline] (1.459 ms) : 0, 1459
crashtracking [candidate] (1.463 ms) : 0, 1463
BytebuddyAgent [baseline] (853.129 ms) : 0, 853129
BytebuddyAgent [candidate] (855.125 ms) : 0, 855125
GlobalTracer [baseline] (234.29 ms) : 0, 234290
GlobalTracer [candidate] (233.678 ms) : 0, 233678
IAST [baseline] (26.43 ms) : 0, 26430
IAST [candidate] (31.562 ms) : 0, 31562
AppSec [baseline] (28.888 ms) : 0, 28888
AppSec [candidate] (25.604 ms) : 0, 25604
Debugger [baseline] (9.356 ms) : 0, 9356
Debugger [candidate] (7.711 ms) : 0, 7711
Remote Config [baseline] (630.887 µs) : 0, 631
Remote Config [candidate] (605.516 µs) : 0, 606
Telemetry [baseline] (8.404 ms) : 0, 8404
Telemetry [candidate] (8.21 ms) : 0, 8210
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 1 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~61dc0f2001, baseline=1.53.0-SNAPSHOT~0ce85a2743
dateFormat X
axisFormat %s
section baseline
no_agent (4.29 ms) : 4232, 4348
. : milestone, 4290,
iast (9.565 ms) : 9409, 9722
. : milestone, 9565,
iast_FULL (14.063 ms) : 13788, 14337
. : milestone, 14063,
iast_GLOBAL (10.387 ms) : 10205, 10568
. : milestone, 10387,
profiling (8.688 ms) : 8554, 8822
. : milestone, 8688,
tracing (7.56 ms) : 7450, 7670
. : milestone, 7560,
section candidate
no_agent (4.329 ms) : 4281, 4378
. : milestone, 4329,
iast (9.468 ms) : 9314, 9621
. : milestone, 9468,
iast_FULL (13.922 ms) : 13642, 14202
. : milestone, 13922,
iast_GLOBAL (10.03 ms) : 9857, 10204
. : milestone, 10030,
profiling (8.903 ms) : 8747, 9059
. : milestone, 8903,
tracing (7.617 ms) : 7511, 7722
. : milestone, 7617,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~61dc0f2001, baseline=1.53.0-SNAPSHOT~0ce85a2743
dateFormat X
axisFormat %s
section baseline
no_agent (37.86 ms) : 37546, 38173
. : milestone, 37860,
appsec (45.601 ms) : 45191, 46010
. : milestone, 45601,
code_origins (44.908 ms) : 44522, 45293
. : milestone, 44908,
iast (44.472 ms) : 44082, 44862
. : milestone, 44472,
profiling (48.91 ms) : 48437, 49383
. : milestone, 48910,
tracing (44.604 ms) : 44226, 44981
. : milestone, 44604,
section candidate
no_agent (36.396 ms) : 36099, 36694
. : milestone, 36396,
appsec (47.331 ms) : 46897, 47766
. : milestone, 47331,
code_origins (43.504 ms) : 43126, 43882
. : milestone, 43504,
iast (44.003 ms) : 43625, 44381
. : milestone, 44003,
profiling (46.278 ms) : 45837, 46719
. : milestone, 46278,
tracing (43.685 ms) : 43311, 44058
. : milestone, 43685,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~61dc0f2001, baseline=1.53.0-SNAPSHOT~0ce85a2743
dateFormat X
axisFormat %s
section baseline
no_agent (14.937 s) : 14937000, 14937000
. : milestone, 14937000,
appsec (14.866 s) : 14866000, 14866000
. : milestone, 14866000,
iast (18.386 s) : 18386000, 18386000
. : milestone, 18386000,
iast_GLOBAL (18.119 s) : 18119000, 18119000
. : milestone, 18119000,
profiling (16.035 s) : 16035000, 16035000
. : milestone, 16035000,
tracing (14.921 s) : 14921000, 14921000
. : milestone, 14921000,
section candidate
no_agent (14.836 s) : 14836000, 14836000
. : milestone, 14836000,
appsec (14.757 s) : 14757000, 14757000
. : milestone, 14757000,
iast (18.572 s) : 18572000, 18572000
. : milestone, 18572000,
iast_GLOBAL (17.974 s) : 17974000, 17974000
. : milestone, 17974000,
profiling (15.364 s) : 15364000, 15364000
. : milestone, 15364000,
tracing (15.062 s) : 15062000, 15062000
. : milestone, 15062000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~61dc0f2001, baseline=1.53.0-SNAPSHOT~0ce85a2743
dateFormat X
axisFormat %s
section baseline
no_agent (1.484 ms) : 1472, 1495
. : milestone, 1484,
appsec (3.702 ms) : 3484, 3920
. : milestone, 3702,
iast (2.213 ms) : 2149, 2277
. : milestone, 2213,
iast_GLOBAL (2.264 ms) : 2200, 2329
. : milestone, 2264,
profiling (2.495 ms) : 2279, 2711
. : milestone, 2495,
tracing (2.04 ms) : 1991, 2090
. : milestone, 2040,
section candidate
no_agent (1.48 ms) : 1469, 1492
. : milestone, 1480,
appsec (3.671 ms) : 3452, 3889
. : milestone, 3671,
iast (2.215 ms) : 2151, 2278
. : milestone, 2215,
iast_GLOBAL (2.267 ms) : 2203, 2331
. : milestone, 2267,
profiling (2.047 ms) : 1996, 2098
. : milestone, 2047,
tracing (2.05 ms) : 2000, 2099
. : milestone, 2050,
|
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]