ConfigProvider iterates over all sources and reports all non-null values to telemetry #9404

mtoffl01 · 2025-08-21T18:55:59Z

NOTE: There are a few unit tests that need to be fixed prior to this PR being "mergable". I'm looking for a review of the source file changes made while I am on PTO to gain a sense of if there are fundamental changes that need to be made.

What Does This Do

Previously, telemetry was only being reported for the ConfigSource that set the final value of the configuration. This PR introduces reporting telemetry for all ConfigSources that have non-null values set, regardless of whether it sets the final configuration value or not.

Summary of Changes:

ConfigCollector
- Stores config telemetry payloads of Map<ConfigOrigin, Map<String (configName), ConfigSetting>>
- New putDefault method is created to allow overriding config telemetry payloads from DEFAULT origin ONLY when the value is null. Use case is when a Config is already processed, then a function like isExplicitlyDisabled is called and invokes getBoolean without the proper default value, which previously would override the DEFAULT telemetry payload with null.
ConfigSetting
- New field seqId and new of function that takes it in as a parameter
ConfigProvider
- All methods querying ConfigSources start from lowest priority to highest priority. A local seqId is used to track priority of ConfigSources that are set. In the case of parsing errors, there may be re-reporting of the last valid ConfigSource to ensure the highest priority and valid ConfigSource is reported with the highest seqId
- ConfigValueResolver
  - Helper class to help with re-reporting configurations. Includes key, value, seqId, and ConfigOrigin.
  - All ConfigProvider methods now store the final return value through ConfigValueResolver
- ConfigMergeResolver
  - Helper class to help with merging maps from multiple sources

Motivation

RFC

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

datadog-datadog-prod-us1 · 2025-08-21T19:18:49Z

🎯 Code Coverage
• Patch Coverage: 80.65%
• Total Coverage: 57.59% (-0.04%)

View detailed report

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 9b22670 | Docs | Was this helpful? Give us feedback!}

pr-commenter · 2025-08-21T19:29:20Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mtoff/4-config-sources
git_commit_date	1756482235	1756499992
git_commit_sha	`d434107`	`9b22670`
release_version	1.53.0-SNAPSHOT~d43410737f	1.53.0-SNAPSHOT~9b22670a6b

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1756501786	1756501786
ci_job_id	1106232284	1106232284
ci_pipeline_id	75129983	75129983
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-usfcvzzu 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-usfcvzzu 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 43 metrics, 15 unstable metrics.

scenario	Δ mean execution_time	candidate mean execution_time	baseline mean execution_time
scenario:startup:petclinic:appsec:Remote Config	better [-62.397µs; -18.546µs] or [-9.607%; -2.855%]	609.053µs	649.525µs

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~9b22670a6b, baseline=1.53.0-SNAPSHOT~d43410737f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1050193
Total [baseline] (8.635 s) : 0, 8634630
Agent [candidate] (1.052 s) : 0, 1052021
Total [candidate] (8.645 s) : 0, 8644741
section iast
Agent [baseline] (1.19 s) : 0, 1190177
Total [baseline] (9.377 s) : 0, 9377253
Agent [candidate] (1.18 s) : 0, 1180067
Total [candidate] (9.366 s) : 0, 9366077

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.05 s	-
Agent	iast	1.19 s	139.984 ms (13.3%)
Total	tracing	8.635 s	-
Total	iast	9.377 s	742.623 ms (8.6%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.052 s	-
Agent	iast	1.18 s	128.046 ms (12.2%)
Total	tracing	8.645 s	-
Total	iast	9.366 s	721.336 ms (8.3%)

gantt
    title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~9b22670a6b, baseline=1.53.0-SNAPSHOT~d43410737f

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.475 ms) : 0, 1475
crashtracking [candidate] (1.454 ms) : 0, 1454
BytebuddyAgent [baseline] (736.151 ms) : 0, 736151
BytebuddyAgent [candidate] (737.0 ms) : 0, 737000
GlobalTracer [baseline] (242.506 ms) : 0, 242506
GlobalTracer [candidate] (244.058 ms) : 0, 244058
AppSec [baseline] (29.907 ms) : 0, 29907
AppSec [candidate] (30.25 ms) : 0, 30250
Debugger [baseline] (6.025 ms) : 0, 6025
Debugger [candidate] (6.014 ms) : 0, 6014
Remote Config [baseline] (667.558 µs) : 0, 668
Remote Config [candidate] (671.582 µs) : 0, 672
Telemetry [baseline] (12.357 ms) : 0, 12357
Telemetry [candidate] (11.5 ms) : 0, 11500
section iast
crashtracking [baseline] (1.482 ms) : 0, 1482
crashtracking [candidate] (1.448 ms) : 0, 1448
BytebuddyAgent [baseline] (859.549 ms) : 0, 859549
BytebuddyAgent [candidate] (852.344 ms) : 0, 852344
GlobalTracer [baseline] (234.421 ms) : 0, 234421
GlobalTracer [candidate] (233.043 ms) : 0, 233043
IAST [baseline] (29.086 ms) : 0, 29086
IAST [candidate] (29.273 ms) : 0, 29273
AppSec [baseline] (28.732 ms) : 0, 28732
AppSec [candidate] (28.289 ms) : 0, 28289
Debugger [baseline] (6.606 ms) : 0, 6606
Debugger [candidate] (5.716 ms) : 0, 5716
Remote Config [baseline] (617.832 µs) : 0, 618
Remote Config [candidate] (613.234 µs) : 0, 613
Telemetry [baseline] (8.449 ms) : 0, 8449
Telemetry [candidate] (8.267 ms) : 0, 8267

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~9b22670a6b, baseline=1.53.0-SNAPSHOT~d43410737f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1046367
Total [baseline] (10.739 s) : 0, 10739349
Agent [candidate] (1.055 s) : 0, 1055146
Total [candidate] (10.757 s) : 0, 10757217
section appsec
Agent [baseline] (1.223 s) : 0, 1222501
Total [baseline] (10.856 s) : 0, 10856036
Agent [candidate] (1.228 s) : 0, 1227744
Total [candidate] (10.831 s) : 0, 10831426
section iast
Agent [baseline] (1.19 s) : 0, 1190370
Total [baseline] (10.963 s) : 0, 10962832
Agent [candidate] (1.184 s) : 0, 1184237
Total [candidate] (10.925 s) : 0, 10924657
section profiling
Agent [baseline] (1.2 s) : 0, 1200194
Total [baseline] (10.905 s) : 0, 10904923
Agent [candidate] (1.201 s) : 0, 1200927
Total [candidate] (10.901 s) : 0, 10900815

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.046 s	-
Agent	appsec	1.223 s	176.134 ms (16.8%)
Agent	iast	1.19 s	144.004 ms (13.8%)
Agent	profiling	1.2 s	153.827 ms (14.7%)
Total	tracing	10.739 s	-
Total	appsec	10.856 s	116.686 ms (1.1%)
Total	iast	10.963 s	223.483 ms (2.1%)
Total	profiling	10.905 s	165.574 ms (1.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.055 s	-
Agent	appsec	1.228 s	172.598 ms (16.4%)
Agent	iast	1.184 s	129.091 ms (12.2%)
Agent	profiling	1.201 s	145.781 ms (13.8%)
Total	tracing	10.757 s	-
Total	appsec	10.831 s	74.209 ms (0.7%)
Total	iast	10.925 s	167.439 ms (1.6%)
Total	profiling	10.901 s	143.598 ms (1.3%)

gantt
    title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~9b22670a6b, baseline=1.53.0-SNAPSHOT~d43410737f

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (733.252 ms) : 0, 733252
BytebuddyAgent [candidate] (737.359 ms) : 0, 737359
GlobalTracer [baseline] (242.883 ms) : 0, 242883
GlobalTracer [candidate] (243.998 ms) : 0, 243998
AppSec [baseline] (30.146 ms) : 0, 30146
AppSec [candidate] (30.221 ms) : 0, 30221
Debugger [baseline] (6.06 ms) : 0, 6060
Debugger [candidate] (6.043 ms) : 0, 6043
Remote Config [baseline] (673.299 µs) : 0, 673
Remote Config [candidate] (665.142 µs) : 0, 665
Telemetry [baseline] (10.775 ms) : 0, 10775
Telemetry [candidate] (14.247 ms) : 0, 14247
section appsec
crashtracking [baseline] (1.453 ms) : 0, 1453
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (754.606 ms) : 0, 754606
BytebuddyAgent [candidate] (759.278 ms) : 0, 759278
GlobalTracer [baseline] (235.219 ms) : 0, 235219
GlobalTracer [candidate] (236.135 ms) : 0, 236135
IAST [baseline] (23.685 ms) : 0, 23685
IAST [candidate] (23.577 ms) : 0, 23577
AppSec [baseline] (170.011 ms) : 0, 170011
AppSec [candidate] (171.334 ms) : 0, 171334
Debugger [baseline] (6.492 ms) : 0, 6492
Debugger [candidate] (5.781 ms) : 0, 5781
Remote Config [baseline] (649.525 µs) : 0, 650
Remote Config [candidate] (609.053 µs) : 0, 609
Telemetry [baseline] (9.268 ms) : 0, 9268
Telemetry [candidate] (8.437 ms) : 0, 8437
section iast
crashtracking [baseline] (1.47 ms) : 0, 1470
crashtracking [candidate] (1.458 ms) : 0, 1458
BytebuddyAgent [baseline] (859.059 ms) : 0, 859059
BytebuddyAgent [candidate] (855.25 ms) : 0, 855250
GlobalTracer [baseline] (234.888 ms) : 0, 234888
GlobalTracer [candidate] (233.697 ms) : 0, 233697
IAST [baseline] (27.399 ms) : 0, 27399
IAST [candidate] (28.528 ms) : 0, 28528
AppSec [baseline] (29.686 ms) : 0, 29686
AppSec [candidate] (25.303 ms) : 0, 25303
Debugger [baseline] (7.527 ms) : 0, 7527
Debugger [candidate] (10.016 ms) : 0, 10016
Remote Config [baseline] (635.668 µs) : 0, 636
Remote Config [candidate] (643.645 µs) : 0, 644
Telemetry [baseline] (8.417 ms) : 0, 8417
Telemetry [candidate] (8.158 ms) : 0, 8158
section profiling
crashtracking [baseline] (1.452 ms) : 0, 1452
crashtracking [candidate] (1.459 ms) : 0, 1459
BytebuddyAgent [baseline] (763.545 ms) : 0, 763545
BytebuddyAgent [candidate] (762.35 ms) : 0, 762350
GlobalTracer [baseline] (223.314 ms) : 0, 223314
GlobalTracer [candidate] (222.977 ms) : 0, 222977
AppSec [baseline] (30.95 ms) : 0, 30950
AppSec [candidate] (30.645 ms) : 0, 30645
Debugger [baseline] (6.318 ms) : 0, 6318
Debugger [candidate] (7.19 ms) : 0, 7190
Remote Config [baseline] (707.666 µs) : 0, 708
Remote Config [candidate] (685.913 µs) : 0, 686
Telemetry [baseline] (15.6 ms) : 0, 15600
Telemetry [candidate] (15.708 ms) : 0, 15708
ProfilingAgent [baseline] (107.817 ms) : 0, 107817
ProfilingAgent [candidate] (108.567 ms) : 0, 108567
Profiling [baseline] (108.474 ms) : 0, 108474
Profiling [candidate] (109.165 ms) : 0, 109165

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mtoff/4-config-sources
git_commit_date	1756482235	1756499992
git_commit_sha	`d434107`	`9b22670`
release_version	1.53.0-SNAPSHOT~d43410737f	1.53.0-SNAPSHOT~9b22670a6b

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1756501458	1756501458
ci_job_id	1106232285	1106232285
ci_pipeline_id	75129983	75129983
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-2-c53a7hkn 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-2-c53a7hkn 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 2 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:insecure-bank:iast_GLOBAL:high_load	worse [+221.765µs; +615.454µs] or [+2.195%; +6.091%]	unstable [-67.978op/s; +31.791op/s] or [-14.786%; +6.915%]	10.522ms	441.656op/s	10.104ms	459.750op/s
scenario:load:petclinic:iast:high_load	better [-2.251ms; -1.411ms] or [-4.900%; -3.071%]	unstable [-3.166op/s; +11.541op/s] or [-3.108%; +11.330%]	44.119ms	106.050op/s	45.950ms	101.862op/s
scenario:load:petclinic:profiling:high_load	worse [+1.173ms; +2.066ms] or [+2.537%; +4.470%]	unstable [-10.390op/s; +3.490op/s] or [-10.259%; +3.446%]	47.837ms	97.825op/s	46.218ms	101.275op/s

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~9b22670a6b, baseline=1.53.0-SNAPSHOT~d43410737f
    dateFormat X
    axisFormat %s
section baseline
no_agent (37.018 ms) : 36725, 37311
.   : milestone, 37018,
appsec (48.46 ms) : 48018, 48901
.   : milestone, 48460,
code_origins (46.316 ms) : 45900, 46732
.   : milestone, 46316,
iast (45.95 ms) : 45551, 46349
.   : milestone, 45950,
profiling (46.218 ms) : 45810, 46626
.   : milestone, 46218,
tracing (44.575 ms) : 44191, 44959
.   : milestone, 44575,
section candidate
no_agent (37.517 ms) : 37216, 37819
.   : milestone, 37517,
appsec (48.136 ms) : 47716, 48556
.   : milestone, 48136,
code_origins (45.101 ms) : 44713, 45489
.   : milestone, 45101,
iast (44.119 ms) : 43737, 44500
.   : milestone, 44119,
profiling (47.837 ms) : 47415, 48260
.   : milestone, 47837,
tracing (45.292 ms) : 44915, 45669
.   : milestone, 45292,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	37.018 ms [36.725 ms, 37.311 ms]	-
appsec	48.46 ms [48.018 ms, 48.901 ms]	11.442 ms (30.9%)
code_origins	46.316 ms [45.9 ms, 46.732 ms]	9.298 ms (25.1%)
iast	45.95 ms [45.551 ms, 46.349 ms]	8.932 ms (24.1%)
profiling	46.218 ms [45.81 ms, 46.626 ms]	9.2 ms (24.9%)
tracing	44.575 ms [44.191 ms, 44.959 ms]	7.557 ms (20.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	37.517 ms [37.216 ms, 37.819 ms]	-
appsec	48.136 ms [47.716 ms, 48.556 ms]	10.618 ms (28.3%)
code_origins	45.101 ms [44.713 ms, 45.489 ms]	7.584 ms (20.2%)
iast	44.119 ms [43.737 ms, 44.5 ms]	6.601 ms (17.6%)
profiling	47.837 ms [47.415 ms, 48.26 ms]	10.32 ms (27.5%)
tracing	45.292 ms [44.915 ms, 45.669 ms]	7.775 ms (20.7%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~9b22670a6b, baseline=1.53.0-SNAPSHOT~d43410737f
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.382 ms) : 4333, 4431
.   : milestone, 4382,
iast (9.414 ms) : 9247, 9580
.   : milestone, 9414,
iast_FULL (14.148 ms) : 13864, 14433
.   : milestone, 14148,
iast_GLOBAL (10.104 ms) : 9930, 10277
.   : milestone, 10104,
profiling (8.703 ms) : 8567, 8840
.   : milestone, 8703,
tracing (7.69 ms) : 7575, 7805
.   : milestone, 7690,
section candidate
no_agent (4.291 ms) : 4241, 4341
.   : milestone, 4291,
iast (9.596 ms) : 9423, 9769
.   : milestone, 9596,
iast_FULL (13.846 ms) : 13568, 14123
.   : milestone, 13846,
iast_GLOBAL (10.522 ms) : 10331, 10714
.   : milestone, 10522,
profiling (8.756 ms) : 8612, 8900
.   : milestone, 8756,
tracing (7.475 ms) : 7370, 7580
.   : milestone, 7475,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.382 ms [4.333 ms, 4.431 ms]	-
iast	9.414 ms [9.247 ms, 9.58 ms]	5.031 ms (114.8%)
iast_FULL	14.148 ms [13.864 ms, 14.433 ms]	9.766 ms (222.8%)
iast_GLOBAL	10.104 ms [9.93 ms, 10.277 ms]	5.722 ms (130.6%)
profiling	8.703 ms [8.567 ms, 8.84 ms]	4.321 ms (98.6%)
tracing	7.69 ms [7.575 ms, 7.805 ms]	3.308 ms (75.5%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.291 ms [4.241 ms, 4.341 ms]	-
iast	9.596 ms [9.423 ms, 9.769 ms]	5.305 ms (123.6%)
iast_FULL	13.846 ms [13.568 ms, 14.123 ms]	9.555 ms (222.7%)
iast_GLOBAL	10.522 ms [10.331 ms, 10.714 ms]	6.231 ms (145.2%)
profiling	8.756 ms [8.612 ms, 8.9 ms]	4.465 ms (104.1%)
tracing	7.475 ms [7.37 ms, 7.58 ms]	3.184 ms (74.2%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mtoff/4-config-sources
git_commit_date	1756482235	1756499992
git_commit_sha	`d434107`	`9b22670`
release_version	1.53.0-SNAPSHOT~d43410737f	1.53.0-SNAPSHOT~9b22670a6b

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1756501999	1756501999
ci_job_id	1106232286	1106232286
ci_pipeline_id	75129983	75129983
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-2-frqgt4xv 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-2-frqgt4xv 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~9b22670a6b, baseline=1.53.0-SNAPSHOT~d43410737f
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.475 ms) : 1464, 1487
.   : milestone, 1475,
appsec (3.658 ms) : 3438, 3878
.   : milestone, 3658,
iast (2.209 ms) : 2147, 2272
.   : milestone, 2209,
iast_GLOBAL (2.244 ms) : 2181, 2307
.   : milestone, 2244,
profiling (2.07 ms) : 2019, 2122
.   : milestone, 2070,
tracing (2.021 ms) : 1973, 2070
.   : milestone, 2021,
section candidate
no_agent (1.475 ms) : 1463, 1486
.   : milestone, 1475,
appsec (3.588 ms) : 3374, 3802
.   : milestone, 3588,
iast (2.194 ms) : 2131, 2256
.   : milestone, 2194,
iast_GLOBAL (2.249 ms) : 2186, 2312
.   : milestone, 2249,
profiling (2.07 ms) : 2018, 2122
.   : milestone, 2070,
tracing (2.021 ms) : 1972, 2069
.   : milestone, 2021,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.475 ms [1.464 ms, 1.487 ms]	-
appsec	3.658 ms [3.438 ms, 3.878 ms]	2.183 ms (148.0%)
iast	2.209 ms [2.147 ms, 2.272 ms]	734.368 µs (49.8%)
iast_GLOBAL	2.244 ms [2.181 ms, 2.307 ms]	768.626 µs (52.1%)
profiling	2.07 ms [2.019 ms, 2.122 ms]	595.235 µs (40.4%)
tracing	2.021 ms [1.973 ms, 2.07 ms]	546.382 µs (37.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.475 ms [1.463 ms, 1.486 ms]	-
appsec	3.588 ms [3.374 ms, 3.802 ms]	2.113 ms (143.2%)
iast	2.194 ms [2.131 ms, 2.256 ms]	718.697 µs (48.7%)
iast_GLOBAL	2.249 ms [2.186 ms, 2.312 ms]	773.676 µs (52.5%)
profiling	2.07 ms [2.018 ms, 2.122 ms]	594.805 µs (40.3%)
tracing	2.021 ms [1.972 ms, 2.069 ms]	545.605 µs (37.0%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~9b22670a6b, baseline=1.53.0-SNAPSHOT~d43410737f
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.565 s) : 15565000, 15565000
.   : milestone, 15565000,
appsec (14.667 s) : 14667000, 14667000
.   : milestone, 14667000,
iast (18.476 s) : 18476000, 18476000
.   : milestone, 18476000,
iast_GLOBAL (18.46 s) : 18460000, 18460000
.   : milestone, 18460000,
profiling (15.239 s) : 15239000, 15239000
.   : milestone, 15239000,
tracing (14.993 s) : 14993000, 14993000
.   : milestone, 14993000,
section candidate
no_agent (14.889 s) : 14889000, 14889000
.   : milestone, 14889000,
appsec (14.878 s) : 14878000, 14878000
.   : milestone, 14878000,
iast (18.548 s) : 18548000, 18548000
.   : milestone, 18548000,
iast_GLOBAL (17.912 s) : 17912000, 17912000
.   : milestone, 17912000,
profiling (15.683 s) : 15683000, 15683000
.   : milestone, 15683000,
tracing (14.815 s) : 14815000, 14815000
.   : milestone, 14815000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.565 s [15.565 s, 15.565 s]	-
appsec	14.667 s [14.667 s, 14.667 s]	-898.0 ms (-5.8%)
iast	18.476 s [18.476 s, 18.476 s]	2.911 s (18.7%)
iast_GLOBAL	18.46 s [18.46 s, 18.46 s]	2.895 s (18.6%)
profiling	15.239 s [15.239 s, 15.239 s]	-326.0 ms (-2.1%)
tracing	14.993 s [14.993 s, 14.993 s]	-572.0 ms (-3.7%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.889 s [14.889 s, 14.889 s]	-
appsec	14.878 s [14.878 s, 14.878 s]	-11.0 ms (-0.1%)
iast	18.548 s [18.548 s, 18.548 s]	3.659 s (24.6%)
iast_GLOBAL	17.912 s [17.912 s, 17.912 s]	3.023 s (20.3%)
profiling	15.683 s [15.683 s, 15.683 s]	794.0 ms (5.3%)
tracing	14.815 s [14.815 s, 14.815 s]	-74.0 ms (-0.5%)

…x configId test to accommodate new ConfigCollector data structure

…Source'

…edConfigSetting static function that takes in a map

…rtFinalResult

mhlidd · 2025-08-29T20:15:14Z

internal-api/src/main/java/datadog/trace/bootstrap/config/provider/ConfigProvider.java

+  }
+
+  /** Helper class to store resolved configuration values with their metadata */
+  static class ConfigValueResolver<T> {


This class is not private in order to expose it for a unit test that is needed to complete code coverage. The unit test verifies that reReportToCollector is not invoked when origin == null, which should never happen since the method to create a ConfigValueResolver should only occur when no re-reporting is expected. This check is only here as a safety check against poor usage of the function.

mhlidd · 2025-08-29T20:18:23Z

telemetry/src/test/groovy/datadog/telemetry/TelemetryServiceSpecification.groovy

@@ -303,60 +304,61 @@ class TelemetryServiceSpecification extends DDSpecification {
    false       | false     | 0
  }

-  def 'split telemetry requests if the size above the limit'() {


Not sure what this is... I'll take a look after I'm back from PTO

github-actions · 2025-08-29T20:42:01Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

apply all changes from PR #9327, accomodated to master

08c80b4

mtoffl01 mentioned this pull request Aug 21, 2025

ConfigProvider iterates over all sources and reports all non-null val… #9327

Closed

mtoffl01 added 3 commits August 21, 2025 15:36

merge with configId changes made in master

c62688b

nits: add configId in ConfigProvider methods where it was missing; fi…

125744a

…x configId test to accommodate new ConfigCollector data structure

Fix 'test config id exists in ConfigCollector when using StableConfig…

8becbc5

…Source'

mtoffl01 force-pushed the mtoff/4-config-sources branch from 67d3e75 to 8becbc5 Compare August 21, 2025 20:44

mtoffl01 and others added 7 commits August 21, 2025 16:46

introduce reportDefault

db60faf

Call collect in BaseApplication.getLogInjectionEnabled; make getAppli…

750ba64

…edConfigSetting static function that takes in a map

Fix call to getAppliedConfigSetting in ConfigCollector test

3006e7c

Introduce ConfigValueResolver and ConfigMergeResolver

bee84bf

getString methods only report non-null values to telemetry

bfcfd7e

remove dependency on collectConfig for reReportToCollector and reRepo…

b411ea9

…rtFinalResult

Merge branch 'master' into mtoff/4-config-sources

d097300

mtoffl01 force-pushed the mtoff/4-config-sources branch from 369b020 to d097300 Compare August 22, 2025 20:44

mhlidd added 3 commits August 27, 2025 17:35

updating config collector to not override existing configs

1ca7fd9

Adding putDefault and adding unit tests

81db67d

relaxing reReportToCollector restraint and adding unit test

1b81e8a

mhlidd force-pushed the mtoff/4-config-sources branch from 535c685 to 1b81e8a Compare August 29, 2025 15:51

mhlidd reviewed Aug 29, 2025

View reviewed changes

cleanup

9b22670

mhlidd added the tag: do not merge Do not merge changes label Aug 29, 2025

mhlidd marked this pull request as ready for review August 29, 2025 20:41

mhlidd requested review from a team as code owners August 29, 2025 20:41

mhlidd requested review from sarahchen6 and removed request for a team August 29, 2025 20:41

mhlidd requested a review from PerfectSlayer August 29, 2025 20:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ConfigProvider iterates over all sources and reports all non-null values to telemetry #9404

ConfigProvider iterates over all sources and reports all non-null values to telemetry #9404

Uh oh!

mtoffl01 commented Aug 21, 2025 •

edited by mhlidd

Loading

Uh oh!

datadog-datadog-prod-us1 bot commented Aug 21, 2025 •

edited by datadog-official bot

Loading

Uh oh!

pr-commenter bot commented Aug 21, 2025 •

edited

Loading

Uh oh!

mhlidd Aug 29, 2025

Uh oh!

mhlidd Aug 29, 2025

Uh oh!

github-actions bot commented Aug 29, 2025

Uh oh!

Uh oh!

ConfigProvider iterates over all sources and reports all non-null values to telemetry #9404

Are you sure you want to change the base?

ConfigProvider iterates over all sources and reports all non-null values to telemetry #9404

Uh oh!

Conversation

mtoffl01 commented Aug 21, 2025 • edited by mhlidd Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

datadog-datadog-prod-us1 bot commented Aug 21, 2025 • edited by datadog-official bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenter bot commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

mhlidd Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

mhlidd Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Aug 29, 2025

Uh oh!

Uh oh!

mtoffl01 commented Aug 21, 2025 •

edited by mhlidd

Loading

datadog-datadog-prod-us1 bot commented Aug 21, 2025 •

edited by datadog-official bot

Loading

pr-commenter bot commented Aug 21, 2025 •

edited

Loading