-
Notifications
You must be signed in to change notification settings - Fork 312
Migrate instrumentations to Context API #9384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Code coverage: total 68.77%, base diff 11.33%, patch 100.00% (view details) This comment will be updated automatically if new data arrives.🔗 Commit SHA: 6d746a3 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 11 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~6d746a31f9, baseline=1.53.0-SNAPSHOT~1f3544809f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.054 s) : 0, 1054079
Total [baseline] (10.694 s) : 0, 10694022
Agent [candidate] (1.05 s) : 0, 1050292
Total [candidate] (10.721 s) : 0, 10721417
section appsec
Agent [baseline] (1.223 s) : 0, 1222653
Total [baseline] (10.867 s) : 0, 10866921
Agent [candidate] (1.223 s) : 0, 1222658
Total [candidate] (10.751 s) : 0, 10751204
section iast
Agent [baseline] (1.182 s) : 0, 1181562
Total [baseline] (10.912 s) : 0, 10911904
Agent [candidate] (1.18 s) : 0, 1180252
Total [candidate] (10.956 s) : 0, 10956078
section profiling
Agent [baseline] (1.201 s) : 0, 1200946
Total [baseline] (10.877 s) : 0, 10876903
Agent [candidate] (1.193 s) : 0, 1193218
Total [candidate] (10.873 s) : 0, 10872579
gantt
title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~6d746a31f9, baseline=1.53.0-SNAPSHOT~1f3544809f
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.454 ms) : 0, 1454
crashtracking [candidate] (1.445 ms) : 0, 1445
BytebuddyAgent [baseline] (736.716 ms) : 0, 736716
BytebuddyAgent [candidate] (734.75 ms) : 0, 734750
GlobalTracer [baseline] (243.979 ms) : 0, 243979
GlobalTracer [candidate] (243.198 ms) : 0, 243198
AppSec [baseline] (30.307 ms) : 0, 30307
AppSec [candidate] (30.093 ms) : 0, 30093
Debugger [baseline] (6.083 ms) : 0, 6083
Debugger [candidate] (6.052 ms) : 0, 6052
Remote Config [baseline] (667.569 µs) : 0, 668
Remote Config [candidate] (660.134 µs) : 0, 660
Telemetry [baseline] (13.664 ms) : 0, 13664
Telemetry [candidate] (12.966 ms) : 0, 12966
section appsec
crashtracking [baseline] (1.453 ms) : 0, 1453
crashtracking [candidate] (1.446 ms) : 0, 1446
BytebuddyAgent [baseline] (755.163 ms) : 0, 755163
BytebuddyAgent [candidate] (755.291 ms) : 0, 755291
GlobalTracer [baseline] (235.403 ms) : 0, 235403
GlobalTracer [candidate] (235.064 ms) : 0, 235064
AppSec [baseline] (167.268 ms) : 0, 167268
AppSec [candidate] (169.731 ms) : 0, 169731
Debugger [baseline] (8.853 ms) : 0, 8853
Debugger [candidate] (7.232 ms) : 0, 7232
Remote Config [baseline] (634.46 µs) : 0, 634
Remote Config [candidate] (633.892 µs) : 0, 634
Telemetry [baseline] (9.218 ms) : 0, 9218
Telemetry [candidate] (8.436 ms) : 0, 8436
IAST [baseline] (23.593 ms) : 0, 23593
IAST [candidate] (23.685 ms) : 0, 23685
section iast
crashtracking [baseline] (1.447 ms) : 0, 1447
crashtracking [candidate] (1.444 ms) : 0, 1444
BytebuddyAgent [baseline] (852.711 ms) : 0, 852711
BytebuddyAgent [candidate] (851.581 ms) : 0, 851581
GlobalTracer [baseline] (233.806 ms) : 0, 233806
GlobalTracer [candidate] (233.284 ms) : 0, 233284
AppSec [baseline] (25.886 ms) : 0, 25886
AppSec [candidate] (25.194 ms) : 0, 25194
Debugger [baseline] (5.795 ms) : 0, 5795
Debugger [candidate] (7.518 ms) : 0, 7518
Remote Config [baseline] (596.356 µs) : 0, 596
Remote Config [candidate] (598.286 µs) : 0, 598
Telemetry [baseline] (8.371 ms) : 0, 8371
Telemetry [candidate] (8.34 ms) : 0, 8340
IAST [baseline] (31.876 ms) : 0, 31876
IAST [candidate] (31.249 ms) : 0, 31249
section profiling
ProfilingAgent [baseline] (107.612 ms) : 0, 107612
ProfilingAgent [candidate] (107.671 ms) : 0, 107671
crashtracking [baseline] (1.443 ms) : 0, 1443
crashtracking [candidate] (1.4 ms) : 0, 1400
BytebuddyAgent [baseline] (766.544 ms) : 0, 766544
BytebuddyAgent [candidate] (760.028 ms) : 0, 760028
GlobalTracer [baseline] (222.108 ms) : 0, 222108
GlobalTracer [candidate] (221.486 ms) : 0, 221486
AppSec [baseline] (30.178 ms) : 0, 30178
AppSec [candidate] (29.83 ms) : 0, 29830
Debugger [baseline] (6.262 ms) : 0, 6262
Debugger [candidate] (6.239 ms) : 0, 6239
Remote Config [baseline] (697.751 µs) : 0, 698
Remote Config [candidate] (690.375 µs) : 0, 690
Telemetry [baseline] (16.353 ms) : 0, 16353
Telemetry [candidate] (16.258 ms) : 0, 16258
Profiling [baseline] (108.241 ms) : 0, 108241
Profiling [candidate] (108.332 ms) : 0, 108332
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~6d746a31f9, baseline=1.53.0-SNAPSHOT~1f3544809f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.048 s) : 0, 1047579
Total [baseline] (8.625 s) : 0, 8624896
Agent [candidate] (1.055 s) : 0, 1054805
Total [candidate] (8.624 s) : 0, 8623561
section iast
Agent [baseline] (1.193 s) : 0, 1192856
Total [baseline] (9.373 s) : 0, 9373341
Agent [candidate] (1.178 s) : 0, 1177929
Total [candidate] (9.327 s) : 0, 9326773
gantt
title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~6d746a31f9, baseline=1.53.0-SNAPSHOT~1f3544809f
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.448 ms) : 0, 1448
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (733.22 ms) : 0, 733220
BytebuddyAgent [candidate] (738.144 ms) : 0, 738144
GlobalTracer [baseline] (242.875 ms) : 0, 242875
GlobalTracer [candidate] (244.652 ms) : 0, 244652
AppSec [baseline] (30.12 ms) : 0, 30120
AppSec [candidate] (30.508 ms) : 0, 30508
Debugger [baseline] (6.08 ms) : 0, 6080
Debugger [candidate] (6.069 ms) : 0, 6069
Remote Config [baseline] (673.743 µs) : 0, 674
Remote Config [candidate] (669.852 µs) : 0, 670
Telemetry [baseline] (12.184 ms) : 0, 12184
Telemetry [candidate] (12.321 ms) : 0, 12321
section iast
crashtracking [baseline] (1.456 ms) : 0, 1456
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (860.521 ms) : 0, 860521
BytebuddyAgent [candidate] (850.235 ms) : 0, 850235
GlobalTracer [baseline] (236.007 ms) : 0, 236007
GlobalTracer [candidate] (232.788 ms) : 0, 232788
AppSec [baseline] (26.403 ms) : 0, 26403
AppSec [candidate] (27.413 ms) : 0, 27413
Debugger [baseline] (6.694 ms) : 0, 6694
Debugger [candidate] (5.768 ms) : 0, 5768
Remote Config [baseline] (615.29 µs) : 0, 615
Remote Config [candidate] (597.325 µs) : 0, 597
Telemetry [baseline] (8.5 ms) : 0, 8500
Telemetry [candidate] (8.393 ms) : 0, 8393
IAST [baseline] (31.602 ms) : 0, 31602
IAST [candidate] (30.33 ms) : 0, 30330
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~6d746a31f9, baseline=1.53.0-SNAPSHOT~1f3544809f
dateFormat X
axisFormat %s
section baseline
no_agent (4.44 ms) : 4390, 4490
. : milestone, 4440,
iast (9.15 ms) : 8991, 9309
. : milestone, 9150,
iast_FULL (13.752 ms) : 13478, 14025
. : milestone, 13752,
iast_GLOBAL (10.225 ms) : 10046, 10405
. : milestone, 10225,
profiling (8.919 ms) : 8781, 9056
. : milestone, 8919,
tracing (7.597 ms) : 7487, 7707
. : milestone, 7597,
section candidate
no_agent (4.287 ms) : 4235, 4339
. : milestone, 4287,
iast (8.98 ms) : 8834, 9126
. : milestone, 8980,
iast_FULL (14.172 ms) : 13891, 14453
. : milestone, 14172,
iast_GLOBAL (10.255 ms) : 10076, 10435
. : milestone, 10255,
profiling (8.959 ms) : 8809, 9110
. : milestone, 8959,
tracing (7.432 ms) : 7321, 7543
. : milestone, 7432,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~6d746a31f9, baseline=1.53.0-SNAPSHOT~1f3544809f
dateFormat X
axisFormat %s
section baseline
no_agent (37.534 ms) : 37222, 37845
. : milestone, 37534,
appsec (48.563 ms) : 48131, 48994
. : milestone, 48563,
code_origins (45.738 ms) : 45353, 46123
. : milestone, 45738,
iast (46.599 ms) : 46173, 47024
. : milestone, 46599,
profiling (48.328 ms) : 47843, 48813
. : milestone, 48328,
tracing (43.876 ms) : 43501, 44252
. : milestone, 43876,
section candidate
no_agent (35.171 ms) : 34884, 35459
. : milestone, 35171,
appsec (46.294 ms) : 45889, 46698
. : milestone, 46294,
code_origins (45.438 ms) : 45048, 45827
. : milestone, 45438,
iast (43.328 ms) : 42947, 43708
. : milestone, 43328,
profiling (49.173 ms) : 48736, 49609
. : milestone, 49173,
tracing (44.952 ms) : 44577, 45326
. : milestone, 44952,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~6d746a31f9, baseline=1.53.0-SNAPSHOT~1f3544809f
dateFormat X
axisFormat %s
section baseline
no_agent (15.151 s) : 15151000, 15151000
. : milestone, 15151000,
appsec (14.255 s) : 14255000, 14255000
. : milestone, 14255000,
iast (17.76 s) : 17760000, 17760000
. : milestone, 17760000,
iast_GLOBAL (17.691 s) : 17691000, 17691000
. : milestone, 17691000,
profiling (14.661 s) : 14661000, 14661000
. : milestone, 14661000,
tracing (14.195 s) : 14195000, 14195000
. : milestone, 14195000,
section candidate
no_agent (14.443 s) : 14443000, 14443000
. : milestone, 14443000,
appsec (14.264 s) : 14264000, 14264000
. : milestone, 14264000,
iast (17.88 s) : 17880000, 17880000
. : milestone, 17880000,
iast_GLOBAL (17.357 s) : 17357000, 17357000
. : milestone, 17357000,
profiling (14.727 s) : 14727000, 14727000
. : milestone, 14727000,
tracing (14.41 s) : 14410000, 14410000
. : milestone, 14410000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~6d746a31f9, baseline=1.53.0-SNAPSHOT~1f3544809f
dateFormat X
axisFormat %s
section baseline
no_agent (1.489 ms) : 1477, 1501
. : milestone, 1489,
appsec (4.094 ms) : 3843, 4345
. : milestone, 4094,
iast (2.554 ms) : 2455, 2652
. : milestone, 2554,
iast_GLOBAL (2.598 ms) : 2499, 2697
. : milestone, 2598,
profiling (2.399 ms) : 2314, 2485
. : milestone, 2399,
tracing (2.331 ms) : 2251, 2411
. : milestone, 2331,
section candidate
no_agent (1.491 ms) : 1479, 1503
. : milestone, 1491,
appsec (4.089 ms) : 3840, 4337
. : milestone, 4089,
iast (2.56 ms) : 2461, 2658
. : milestone, 2560,
iast_GLOBAL (2.606 ms) : 2507, 2704
. : milestone, 2606,
profiling (2.815 ms) : 2586, 3045
. : milestone, 2815,
tracing (2.346 ms) : 2265, 2426
. : milestone, 2346,
|
babf53c
to
6d746a3
Compare
Rebasing on top of |
What Does This Do
This PR keeps migrating instrumentations to the Context API
Motivation
Decoupling DSM from Tracing.
This PR will focus on instrumentation that tightly coupled DSM and Tracing to introduce Context tracking instead.
Additional Notes
The introduced TODO is a marker for following work with the DSM team.
This is a follow up PR of:
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]