-
Notifications
You must be signed in to change notification settings - Fork 301
Fix incorrect use of Path.getRoot() #8751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f469004
to
b7ab377
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 66 metrics, 5 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.49.0-SNAPSHOT~cf7859ddda, baseline=1.49.0-SNAPSHOT~74633afbc6
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.006 s) : 0, 1006320
Total [baseline] (10.554 s) : 0, 10553504
Agent [candidate] (1.004 s) : 0, 1004142
Total [candidate] (10.628 s) : 0, 10628195
section appsec
Agent [baseline] (1.146 s) : 0, 1146456
Total [baseline] (10.688 s) : 0, 10687645
Agent [candidate] (1.15 s) : 0, 1150211
Total [candidate] (10.718 s) : 0, 10718233
section iast
Agent [baseline] (1.139 s) : 0, 1139426
Total [baseline] (10.947 s) : 0, 10946642
Agent [candidate] (1.136 s) : 0, 1136415
Total [candidate] (10.91 s) : 0, 10909968
section profiling
Agent [baseline] (1.252 s) : 0, 1252407
Total [baseline] (10.827 s) : 0, 10827204
Agent [candidate] (1.255 s) : 0, 1255472
Total [candidate] (10.806 s) : 0, 10806233
gantt
title petclinic - break down per module: candidate=1.49.0-SNAPSHOT~cf7859ddda, baseline=1.49.0-SNAPSHOT~74633afbc6
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (670.214 ms) : 0, 670214
BytebuddyAgent [candidate] (670.062 ms) : 0, 670062
GlobalTracer [baseline] (240.813 ms) : 0, 240813
GlobalTracer [candidate] (239.733 ms) : 0, 239733
AppSec [baseline] (54.965 ms) : 0, 54965
AppSec [candidate] (54.805 ms) : 0, 54805
Debugger [baseline] (6.187 ms) : 0, 6187
Debugger [candidate] (6.17 ms) : 0, 6170
Remote Config [baseline] (722.942 µs) : 0, 723
Remote Config [candidate] (701.732 µs) : 0, 702
Telemetry [baseline] (9.983 ms) : 0, 9983
Telemetry [candidate] (9.319 ms) : 0, 9319
section appsec
BytebuddyAgent [baseline] (686.974 ms) : 0, 686974
BytebuddyAgent [candidate] (688.135 ms) : 0, 688135
GlobalTracer [baseline] (235.792 ms) : 0, 235792
GlobalTracer [candidate] (236.944 ms) : 0, 236944
AppSec [baseline] (175.174 ms) : 0, 175174
AppSec [candidate] (176.573 ms) : 0, 176573
Debugger [baseline] (5.859 ms) : 0, 5859
Debugger [candidate] (5.83 ms) : 0, 5830
Remote Config [baseline] (628.034 µs) : 0, 628
Remote Config [candidate] (635.892 µs) : 0, 636
Telemetry [baseline] (7.786 ms) : 0, 7786
Telemetry [candidate] (7.758 ms) : 0, 7758
IAST [baseline] (21.729 ms) : 0, 21729
IAST [candidate] (21.885 ms) : 0, 21885
section iast
BytebuddyAgent [baseline] (790.566 ms) : 0, 790566
BytebuddyAgent [candidate] (789.85 ms) : 0, 789850
GlobalTracer [baseline] (230.811 ms) : 0, 230811
GlobalTracer [candidate] (229.96 ms) : 0, 229960
AppSec [baseline] (57.035 ms) : 0, 57035
AppSec [candidate] (56.321 ms) : 0, 56321
Debugger [baseline] (6.046 ms) : 0, 6046
Debugger [candidate] (5.872 ms) : 0, 5872
Remote Config [baseline] (610.337 µs) : 0, 610
Remote Config [candidate] (593.5 µs) : 0, 593
Telemetry [baseline] (7.972 ms) : 0, 7972
Telemetry [candidate] (7.822 ms) : 0, 7822
IAST [baseline] (22.913 ms) : 0, 22913
IAST [candidate] (22.606 ms) : 0, 22606
section profiling
BytebuddyAgent [baseline] (661.743 ms) : 0, 661743
BytebuddyAgent [candidate] (663.346 ms) : 0, 663346
GlobalTracer [baseline] (375.384 ms) : 0, 375384
GlobalTracer [candidate] (377.36 ms) : 0, 377360
AppSec [baseline] (53.968 ms) : 0, 53968
AppSec [candidate] (53.274 ms) : 0, 53274
Debugger [baseline] (6.134 ms) : 0, 6134
Debugger [candidate] (6.167 ms) : 0, 6167
Remote Config [baseline] (654.697 µs) : 0, 655
Remote Config [candidate] (660.768 µs) : 0, 661
Telemetry [baseline] (8.104 ms) : 0, 8104
Telemetry [candidate] (8.181 ms) : 0, 8181
ProfilingAgent [baseline] (96.225 ms) : 0, 96225
ProfilingAgent [candidate] (96.245 ms) : 0, 96245
Profiling [baseline] (96.249 ms) : 0, 96249
Profiling [candidate] (96.268 ms) : 0, 96268
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.49.0-SNAPSHOT~cf7859ddda, baseline=1.49.0-SNAPSHOT~74633afbc6
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.013 s) : 0, 1013356
Total [baseline] (8.669 s) : 0, 8668911
Agent [candidate] (1.005 s) : 0, 1004898
Total [candidate] (8.625 s) : 0, 8624847
section iast
Agent [baseline] (1.135 s) : 0, 1134538
Total [baseline] (9.186 s) : 0, 9185981
Agent [candidate] (1.135 s) : 0, 1134825
Total [candidate] (9.182 s) : 0, 9181915
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.134 s) : 0, 1134223
Total [baseline] (9.195 s) : 0, 9195036
Agent [candidate] (1.136 s) : 0, 1136100
Total [candidate] (9.19 s) : 0, 9189655
section iast_TELEMETRY_OFF
Agent [baseline] (1.132 s) : 0, 1132223
Total [baseline] (9.177 s) : 0, 9176603
Agent [candidate] (1.14 s) : 0, 1140155
Total [candidate] (9.178 s) : 0, 9178022
gantt
title insecure-bank - break down per module: candidate=1.49.0-SNAPSHOT~cf7859ddda, baseline=1.49.0-SNAPSHOT~74633afbc6
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (675.798 ms) : 0, 675798
BytebuddyAgent [candidate] (669.398 ms) : 0, 669398
GlobalTracer [baseline] (240.224 ms) : 0, 240224
GlobalTracer [candidate] (240.001 ms) : 0, 240001
AppSec [baseline] (54.808 ms) : 0, 54808
AppSec [candidate] (54.658 ms) : 0, 54658
Debugger [baseline] (6.871 ms) : 0, 6871
Debugger [candidate] (6.862 ms) : 0, 6862
Remote Config [baseline] (710.395 µs) : 0, 710
Remote Config [candidate] (691.389 µs) : 0, 691
Telemetry [baseline] (11.382 ms) : 0, 11382
Telemetry [candidate] (9.841 ms) : 0, 9841
section iast
BytebuddyAgent [baseline] (788.493 ms) : 0, 788493
BytebuddyAgent [candidate] (788.307 ms) : 0, 788307
GlobalTracer [baseline] (229.659 ms) : 0, 229659
GlobalTracer [candidate] (229.823 ms) : 0, 229823
AppSec [baseline] (56.034 ms) : 0, 56034
AppSec [candidate] (56.279 ms) : 0, 56279
Debugger [baseline] (5.836 ms) : 0, 5836
Debugger [candidate] (5.876 ms) : 0, 5876
Remote Config [baseline] (588.243 µs) : 0, 588
Remote Config [candidate] (586.388 µs) : 0, 586
Telemetry [baseline] (7.891 ms) : 0, 7891
Telemetry [candidate] (7.902 ms) : 0, 7902
IAST [baseline] (22.674 ms) : 0, 22674
IAST [candidate] (22.753 ms) : 0, 22753
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (788.306 ms) : 0, 788306
BytebuddyAgent [candidate] (789.298 ms) : 0, 789298
GlobalTracer [baseline] (229.16 ms) : 0, 229160
GlobalTracer [candidate] (229.528 ms) : 0, 229528
AppSec [baseline] (56.357 ms) : 0, 56357
AppSec [candidate] (56.643 ms) : 0, 56643
Debugger [baseline] (5.828 ms) : 0, 5828
Debugger [candidate] (5.887 ms) : 0, 5887
Remote Config [baseline] (575.663 µs) : 0, 576
Remote Config [candidate] (591.308 µs) : 0, 591
Telemetry [baseline] (7.833 ms) : 0, 7833
Telemetry [candidate] (7.931 ms) : 0, 7931
IAST [baseline] (22.741 ms) : 0, 22741
IAST [candidate] (22.775 ms) : 0, 22775
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (786.137 ms) : 0, 786137
BytebuddyAgent [candidate] (792.369 ms) : 0, 792369
GlobalTracer [baseline] (229.474 ms) : 0, 229474
GlobalTracer [candidate] (230.941 ms) : 0, 230941
AppSec [baseline] (56.614 ms) : 0, 56614
AppSec [candidate] (56.645 ms) : 0, 56645
Debugger [baseline] (5.915 ms) : 0, 5915
Debugger [candidate] (5.936 ms) : 0, 5936
Remote Config [baseline] (614.586 µs) : 0, 615
Remote Config [candidate] (604.691 µs) : 0, 605
Telemetry [baseline] (7.75 ms) : 0, 7750
Telemetry [candidate] (7.731 ms) : 0, 7731
IAST [baseline] (22.381 ms) : 0, 22381
IAST [candidate] (22.459 ms) : 0, 22459
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 17 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~cf7859ddda, baseline=1.49.0-SNAPSHOT~74633afbc6
dateFormat X
axisFormat %s
section baseline
no_agent (1.35 ms) : 1331, 1370
. : milestone, 1350,
appsec (1.729 ms) : 1706, 1753
. : milestone, 1729,
appsec_no_iast (1.726 ms) : 1703, 1749
. : milestone, 1726,
code_origins (1.694 ms) : 1667, 1720
. : milestone, 1694,
iast (1.52 ms) : 1495, 1545
. : milestone, 1520,
profiling (1.505 ms) : 1482, 1528
. : milestone, 1505,
tracing (1.494 ms) : 1470, 1519
. : milestone, 1494,
section candidate
no_agent (1.351 ms) : 1332, 1371
. : milestone, 1351,
appsec (1.72 ms) : 1697, 1743
. : milestone, 1720,
appsec_no_iast (1.728 ms) : 1704, 1751
. : milestone, 1728,
code_origins (1.693 ms) : 1666, 1719
. : milestone, 1693,
iast (1.518 ms) : 1493, 1543
. : milestone, 1518,
profiling (1.55 ms) : 1525, 1574
. : milestone, 1550,
tracing (1.473 ms) : 1449, 1498
. : milestone, 1473,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~cf7859ddda, baseline=1.49.0-SNAPSHOT~74633afbc6
dateFormat X
axisFormat %s
section baseline
no_agent (380.095 µs) : 360, 400
. : milestone, 380,
iast (522.198 µs) : 499, 545
. : milestone, 522,
iast_FULL (734.802 µs) : 712, 758
. : milestone, 735,
iast_GLOBAL (572.726 µs) : 549, 596
. : milestone, 573,
iast_HARDCODED_SECRET_DISABLED (526.946 µs) : 504, 550
. : milestone, 527,
iast_INACTIVE (466.331 µs) : 445, 488
. : milestone, 466,
iast_TELEMETRY_OFF (503.762 µs) : 481, 527
. : milestone, 504,
tracing (463.101 µs) : 441, 485
. : milestone, 463,
section candidate
no_agent (380.1 µs) : 361, 400
. : milestone, 380,
iast (519.029 µs) : 496, 542
. : milestone, 519,
iast_FULL (734.034 µs) : 711, 757
. : milestone, 734,
iast_GLOBAL (572.438 µs) : 549, 596
. : milestone, 572,
iast_HARDCODED_SECRET_DISABLED (519.113 µs) : 496, 542
. : milestone, 519,
iast_INACTIVE (466.688 µs) : 444, 489
. : milestone, 467,
iast_TELEMETRY_OFF (502.967 µs) : 480, 526
. : milestone, 503,
tracing (459.462 µs) : 439, 480
. : milestone, 459,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~cf7859ddda, baseline=1.49.0-SNAPSHOT~74633afbc6
dateFormat X
axisFormat %s
section baseline
no_agent (1.48 ms) : 1469, 1492
. : milestone, 1480,
appsec (2.384 ms) : 2338, 2431
. : milestone, 2384,
iast (2.169 ms) : 2110, 2228
. : milestone, 2169,
iast_GLOBAL (2.2 ms) : 2141, 2259
. : milestone, 2200,
profiling (2.05 ms) : 2001, 2099
. : milestone, 2050,
tracing (1.998 ms) : 1952, 2044
. : milestone, 1998,
section candidate
no_agent (1.481 ms) : 1470, 1493
. : milestone, 1481,
appsec (2.393 ms) : 2346, 2440
. : milestone, 2393,
iast (2.168 ms) : 2109, 2228
. : milestone, 2168,
iast_GLOBAL (2.209 ms) : 2149, 2269
. : milestone, 2209,
profiling (2.04 ms) : 1991, 2089
. : milestone, 2040,
tracing (2.008 ms) : 1962, 2054
. : milestone, 2008,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~cf7859ddda, baseline=1.49.0-SNAPSHOT~74633afbc6
dateFormat X
axisFormat %s
section baseline
no_agent (15.248 s) : 15248000, 15248000
. : milestone, 15248000,
appsec (14.838 s) : 14838000, 14838000
. : milestone, 14838000,
iast (18.499 s) : 18499000, 18499000
. : milestone, 18499000,
iast_GLOBAL (17.994 s) : 17994000, 17994000
. : milestone, 17994000,
profiling (15.195 s) : 15195000, 15195000
. : milestone, 15195000,
tracing (14.98 s) : 14980000, 14980000
. : milestone, 14980000,
section candidate
no_agent (15.287 s) : 15287000, 15287000
. : milestone, 15287000,
appsec (15.005 s) : 15005000, 15005000
. : milestone, 15005000,
iast (18.682 s) : 18682000, 18682000
. : milestone, 18682000,
iast_GLOBAL (18.14 s) : 18140000, 18140000
. : milestone, 18140000,
profiling (14.985 s) : 14985000, 14985000
. : milestone, 14985000,
tracing (14.945 s) : 14945000, 14945000
. : milestone, 14945000,
|
mcculls
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
After #8714 the profiling tests started failing. The reason is that the
Path.getRoot()
will returnnull
for a single element path because it considers it not having a root 🤷Notes
As a part of this change I removed the
testShortCircuit
test - because the base temp directory is now created eagerly and not lazily so it can not happen that it will not exist, and this test was asserting that exact 'short-circuit' to avoid scanning the dir structure when there is guaranteed nothing in there.type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issue