-
Notifications
You must be signed in to change notification settings - Fork 301
Set up crash-tracking JVM flags automatically (for Hotspot) #8738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jbachorik
wants to merge
1
commit into
master
Choose a base branch
from
jb/crash_tracking_magic
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9d19300
to
a1931a3
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 10 performance improvements and 17 performance regressions! Performance is the same for 35 metrics, 9 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.49.0-SNAPSHOT~a1931a32e9, baseline=1.49.0-SNAPSHOT~75634fe423
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.009 s) : 0, 1008550
Total [baseline] (10.446 s) : 0, 10445919
Agent [candidate] (1.237 s) : 0, 1236568
Total [candidate] (10.654 s) : 0, 10654313
section appsec
Agent [baseline] (1.149 s) : 0, 1148772
Total [baseline] (10.724 s) : 0, 10723857
Agent [candidate] (1.379 s) : 0, 1378665
Total [candidate] (10.875 s) : 0, 10875143
section iast
Agent [baseline] (1.146 s) : 0, 1145981
Total [baseline] (10.849 s) : 0, 10848881
Agent [candidate] (1.369 s) : 0, 1368555
Total [candidate] (11.08 s) : 0, 11079507
section profiling
Agent [baseline] (1.252 s) : 0, 1251581
Total [baseline] (10.772 s) : 0, 10771698
Agent [candidate] (1.39 s) : 0, 1389985
Total [candidate] (11.086 s) : 0, 11085668
gantt
title petclinic - break down per module: candidate=1.49.0-SNAPSHOT~a1931a32e9, baseline=1.49.0-SNAPSHOT~75634fe423
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (670.83 ms) : 0, 670830
BytebuddyAgent [candidate] (738.688 ms) : 0, 738688
GlobalTracer [baseline] (239.797 ms) : 0, 239797
GlobalTracer [candidate] (196.629 ms) : 0, 196629
AppSec [baseline] (54.694 ms) : 0, 54694
AppSec [candidate] (55.086 ms) : 0, 55086
Debugger [baseline] (6.111 ms) : 0, 6111
Debugger [candidate] (6.201 ms) : 0, 6201
Remote Config [baseline] (705.341 µs) : 0, 705
Remote Config [candidate] (677.155 µs) : 0, 677
Telemetry [baseline] (12.964 ms) : 0, 12964
Telemetry [candidate] (15.655 ms) : 0, 15655
section appsec
BytebuddyAgent [baseline] (688.159 ms) : 0, 688159
BytebuddyAgent [candidate] (758.957 ms) : 0, 758957
GlobalTracer [baseline] (236.434 ms) : 0, 236434
GlobalTracer [candidate] (196.636 ms) : 0, 196636
AppSec [baseline] (176.139 ms) : 0, 176139
AppSec [candidate] (170.296 ms) : 0, 170296
Debugger [baseline] (5.85 ms) : 0, 5850
Debugger [candidate] (5.975 ms) : 0, 5975
Remote Config [baseline] (639.127 µs) : 0, 639
Remote Config [candidate] (635.434 µs) : 0, 635
Telemetry [baseline] (7.366 ms) : 0, 7366
Telemetry [candidate] (7.444 ms) : 0, 7444
IAST [baseline] (21.746 ms) : 0, 21746
IAST [candidate] (21.305 ms) : 0, 21305
section iast
BytebuddyAgent [baseline] (796.838 ms) : 0, 796838
BytebuddyAgent [candidate] (853.509 ms) : 0, 853509
GlobalTracer [baseline] (231.509 ms) : 0, 231509
GlobalTracer [candidate] (194.128 ms) : 0, 194128
AppSec [baseline] (56.569 ms) : 0, 56569
AppSec [candidate] (50.182 ms) : 0, 50182
Debugger [baseline] (5.938 ms) : 0, 5938
Debugger [candidate] (5.887 ms) : 0, 5887
Remote Config [baseline] (587.771 µs) : 0, 588
Remote Config [candidate] (583.377 µs) : 0, 583
Telemetry [baseline] (7.942 ms) : 0, 7942
Telemetry [candidate] (7.781 ms) : 0, 7781
IAST [baseline] (23.12 ms) : 0, 23120
IAST [candidate] (26.553 ms) : 0, 26553
section profiling
ProfilingAgent [baseline] (97.857 ms) : 0, 97857
ProfilingAgent [candidate] (98.683 ms) : 0, 98683
BytebuddyAgent [baseline] (660.403 ms) : 0, 660403
BytebuddyAgent [candidate] (758.399 ms) : 0, 758399
GlobalTracer [baseline] (374.118 ms) : 0, 374118
GlobalTracer [candidate] (226.1 ms) : 0, 226100
AppSec [baseline] (54.287 ms) : 0, 54287
AppSec [candidate] (61.61 ms) : 0, 61610
Debugger [baseline] (6.098 ms) : 0, 6098
Debugger [candidate] (6.237 ms) : 0, 6237
Remote Config [baseline] (639.46 µs) : 0, 639
Remote Config [candidate] (672.423 µs) : 0, 672
Telemetry [baseline] (8.173 ms) : 0, 8173
Telemetry [candidate] (8.384 ms) : 0, 8384
Profiling [baseline] (97.881 ms) : 0, 97881
Profiling [candidate] (98.708 ms) : 0, 98708
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.49.0-SNAPSHOT~a1931a32e9, baseline=1.49.0-SNAPSHOT~75634fe423
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.009 s) : 0, 1008712
Total [baseline] (8.644 s) : 0, 8643839
Agent [candidate] (1.232 s) : 0, 1232229
Total [candidate] (8.834 s) : 0, 8834450
section iast
Agent [baseline] (1.135 s) : 0, 1135140
Total [baseline] (9.239 s) : 0, 9238565
Agent [candidate] (1.353 s) : 0, 1352821
Total [candidate] (9.391 s) : 0, 9391034
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.135 s) : 0, 1134526
Total [baseline] (9.165 s) : 0, 9164555
Agent [candidate] (1.358 s) : 0, 1358352
Total [candidate] (9.337 s) : 0, 9337172
section iast_TELEMETRY_OFF
Agent [baseline] (1.134 s) : 0, 1133897
Total [baseline] (9.175 s) : 0, 9175067
Agent [candidate] (1.357 s) : 0, 1356729
Total [candidate] (9.425 s) : 0, 9424948
gantt
title insecure-bank - break down per module: candidate=1.49.0-SNAPSHOT~a1931a32e9, baseline=1.49.0-SNAPSHOT~75634fe423
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (670.983 ms) : 0, 670983
BytebuddyAgent [candidate] (744.598 ms) : 0, 744598
GlobalTracer [baseline] (240.43 ms) : 0, 240430
GlobalTracer [candidate] (198.144 ms) : 0, 198144
AppSec [baseline] (54.79 ms) : 0, 54790
AppSec [candidate] (55.324 ms) : 0, 55324
Debugger [baseline] (6.162 ms) : 0, 6162
Debugger [candidate] (6.208 ms) : 0, 6208
Remote Config [baseline] (720.204 µs) : 0, 720
Remote Config [candidate] (681.548 µs) : 0, 682
Telemetry [baseline] (12.278 ms) : 0, 12278
Telemetry [candidate] (15.467 ms) : 0, 15467
section iast
BytebuddyAgent [baseline] (788.288 ms) : 0, 788288
BytebuddyAgent [candidate] (852.72 ms) : 0, 852720
GlobalTracer [baseline] (229.552 ms) : 0, 229552
GlobalTracer [candidate] (193.384 ms) : 0, 193384
IAST [baseline] (22.742 ms) : 0, 22742
IAST [candidate] (24.245 ms) : 0, 24245
AppSec [baseline] (56.756 ms) : 0, 56756
AppSec [candidate] (53.824 ms) : 0, 53824
Debugger [baseline] (5.964 ms) : 0, 5964
Debugger [candidate] (5.927 ms) : 0, 5927
Remote Config [baseline] (588.64 µs) : 0, 589
Remote Config [candidate] (600.927 µs) : 0, 601
Telemetry [baseline] (7.931 ms) : 0, 7931
Telemetry [candidate] (7.713 ms) : 0, 7713
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (788.126 ms) : 0, 788126
BytebuddyAgent [candidate] (851.604 ms) : 0, 851604
GlobalTracer [baseline] (229.536 ms) : 0, 229536
GlobalTracer [candidate] (193.424 ms) : 0, 193424
IAST [baseline] (22.754 ms) : 0, 22754
IAST [candidate] (25.075 ms) : 0, 25075
AppSec [baseline] (56.373 ms) : 0, 56373
AppSec [candidate] (52.737 ms) : 0, 52737
Debugger [baseline] (5.866 ms) : 0, 5866
Debugger [candidate] (5.946 ms) : 0, 5946
Remote Config [baseline] (602.718 µs) : 0, 603
Remote Config [candidate] (593.56 µs) : 0, 594
Telemetry [baseline] (7.876 ms) : 0, 7876
Telemetry [candidate] (7.808 ms) : 0, 7808
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (787.43 ms) : 0, 787430
BytebuddyAgent [candidate] (852.592 ms) : 0, 852592
GlobalTracer [baseline] (230.587 ms) : 0, 230587
GlobalTracer [candidate] (192.434 ms) : 0, 192434
IAST [baseline] (22.255 ms) : 0, 22255
IAST [candidate] (23.877 ms) : 0, 23877
AppSec [baseline] (56.126 ms) : 0, 56126
AppSec [candidate] (53.577 ms) : 0, 53577
Debugger [baseline] (5.833 ms) : 0, 5833
Debugger [candidate] (5.967 ms) : 0, 5967
Remote Config [baseline] (593.19 µs) : 0, 593
Remote Config [candidate] (623.676 µs) : 0, 624
Telemetry [baseline] (7.677 ms) : 0, 7677
Telemetry [candidate] (7.907 ms) : 0, 7907
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 18 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~a1931a32e9, baseline=1.49.0-SNAPSHOT~75634fe423
dateFormat X
axisFormat %s
section baseline
no_agent (388.158 µs) : 368, 408
. : milestone, 388,
iast (522.447 µs) : 499, 546
. : milestone, 522,
iast_FULL (742.709 µs) : 720, 766
. : milestone, 743,
iast_GLOBAL (566.374 µs) : 543, 589
. : milestone, 566,
iast_HARDCODED_SECRET_DISABLED (532.64 µs) : 509, 556
. : milestone, 533,
iast_INACTIVE (475.116 µs) : 452, 499
. : milestone, 475,
iast_TELEMETRY_OFF (511.042 µs) : 489, 533
. : milestone, 511,
tracing (466.122 µs) : 443, 489
. : milestone, 466,
section candidate
no_agent (381.053 µs) : 361, 401
. : milestone, 381,
iast (533.595 µs) : 510, 557
. : milestone, 534,
iast_FULL (734.042 µs) : 711, 757
. : milestone, 734,
iast_GLOBAL (573.9 µs) : 550, 597
. : milestone, 574,
iast_HARDCODED_SECRET_DISABLED (521.962 µs) : 499, 545
. : milestone, 522,
iast_INACTIVE (478.644 µs) : 456, 501
. : milestone, 479,
iast_TELEMETRY_OFF (518.729 µs) : 496, 542
. : milestone, 519,
tracing (467.769 µs) : 447, 489
. : milestone, 468,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~a1931a32e9, baseline=1.49.0-SNAPSHOT~75634fe423
dateFormat X
axisFormat %s
section baseline
no_agent (1.358 ms) : 1338, 1377
. : milestone, 1358,
appsec (1.725 ms) : 1702, 1749
. : milestone, 1725,
appsec_no_iast (1.743 ms) : 1720, 1766
. : milestone, 1743,
code_origins (1.688 ms) : 1662, 1714
. : milestone, 1688,
iast (1.516 ms) : 1491, 1540
. : milestone, 1516,
profiling (1.572 ms) : 1547, 1597
. : milestone, 1572,
tracing (1.494 ms) : 1469, 1519
. : milestone, 1494,
section candidate
no_agent (1.375 ms) : 1356, 1393
. : milestone, 1375,
appsec (1.748 ms) : 1724, 1772
. : milestone, 1748,
appsec_no_iast (1.739 ms) : 1716, 1763
. : milestone, 1739,
code_origins (1.686 ms) : 1659, 1714
. : milestone, 1686,
iast (1.519 ms) : 1495, 1543
. : milestone, 1519,
profiling (1.496 ms) : 1473, 1519
. : milestone, 1496,
tracing (1.488 ms) : 1465, 1512
. : milestone, 1488,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~a1931a32e9, baseline=1.49.0-SNAPSHOT~75634fe423
dateFormat X
axisFormat %s
section baseline
no_agent (15.53 s) : 15530000, 15530000
. : milestone, 15530000,
appsec (14.936 s) : 14936000, 14936000
. : milestone, 14936000,
iast (18.747 s) : 18747000, 18747000
. : milestone, 18747000,
iast_GLOBAL (18.278 s) : 18278000, 18278000
. : milestone, 18278000,
profiling (15.504 s) : 15504000, 15504000
. : milestone, 15504000,
tracing (15.104 s) : 15104000, 15104000
. : milestone, 15104000,
section candidate
no_agent (15.063 s) : 15063000, 15063000
. : milestone, 15063000,
appsec (14.981 s) : 14981000, 14981000
. : milestone, 14981000,
iast (19.119 s) : 19119000, 19119000
. : milestone, 19119000,
iast_GLOBAL (18.046 s) : 18046000, 18046000
. : milestone, 18046000,
profiling (15.027 s) : 15027000, 15027000
. : milestone, 15027000,
tracing (14.716 s) : 14716000, 14716000
. : milestone, 14716000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~a1931a32e9, baseline=1.49.0-SNAPSHOT~75634fe423
dateFormat X
axisFormat %s
section baseline
no_agent (1.471 ms) : 1460, 1483
. : milestone, 1471,
appsec (2.374 ms) : 2327, 2420
. : milestone, 2374,
iast (2.15 ms) : 2091, 2208
. : milestone, 2150,
iast_GLOBAL (2.193 ms) : 2134, 2252
. : milestone, 2193,
profiling (1.997 ms) : 1950, 2044
. : milestone, 1997,
tracing (1.975 ms) : 1930, 2020
. : milestone, 1975,
section candidate
no_agent (1.473 ms) : 1462, 1485
. : milestone, 1473,
appsec (2.364 ms) : 2318, 2410
. : milestone, 2364,
iast (2.157 ms) : 2098, 2216
. : milestone, 2157,
iast_GLOBAL (2.196 ms) : 2137, 2255
. : milestone, 2196,
profiling (1.992 ms) : 1946, 2039
. : milestone, 1992,
tracing (1.975 ms) : 1930, 2020
. : milestone, 1975,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Use the vmstructs based access to JVM flags which is available via ddprof-java library. Using this approach we can even set some flags - the effectiveness depends on whether JVM caches the flag value or not. For the 'OnError' and 'OnOutOfMemoryError' JVM flags the value is not cached and that means we can actually set it up early in the startup.
Motivation
Make the crash-tracking as easy to onboard as possible.
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: PROF-10707