-
Notifications
You must be signed in to change notification settings - Fork 299
Update trace sampling formula #8734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
genesor
wants to merge
1
commit into
master
Choose a base branch
from
ben.db/APMAPI-1262-adjust-sampling-formula
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 12 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.49.0-SNAPSHOT~fa8ffa9139, baseline=1.49.0-SNAPSHOT~de593cc116
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1069463
Total [baseline] (8.716 s) : 0, 8716150
Agent [candidate] (1.06 s) : 0, 1060095
Total [candidate] (8.691 s) : 0, 8691024
section iast
Agent [baseline] (1.195 s) : 0, 1194774
Total [baseline] (9.255 s) : 0, 9254948
Agent [candidate] (1.188 s) : 0, 1187906
Total [candidate] (9.233 s) : 0, 9233146
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.187 s) : 0, 1187249
Total [baseline] (9.228 s) : 0, 9228369
Agent [candidate] (1.188 s) : 0, 1188284
Total [candidate] (9.197 s) : 0, 9196879
section iast_TELEMETRY_OFF
Agent [baseline] (1.193 s) : 0, 1193143
Total [baseline] (9.244 s) : 0, 9243727
Agent [candidate] (1.189 s) : 0, 1189424
Total [candidate] (9.323 s) : 0, 9323138
gantt
title insecure-bank - break down per module: candidate=1.49.0-SNAPSHOT~fa8ffa9139, baseline=1.49.0-SNAPSHOT~de593cc116
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (730.028 ms) : 0, 730028
BytebuddyAgent [candidate] (723.179 ms) : 0, 723179
GlobalTracer [baseline] (241.957 ms) : 0, 241957
GlobalTracer [candidate] (239.803 ms) : 0, 239803
AppSec [baseline] (55.388 ms) : 0, 55388
AppSec [candidate] (56.25 ms) : 0, 56250
Debugger [baseline] (7.774 ms) : 0, 7774
Debugger [candidate] (6.993 ms) : 0, 6993
Remote Config [baseline] (708.973 µs) : 0, 709
Remote Config [candidate] (694.604 µs) : 0, 695
Telemetry [baseline] (9.973 ms) : 0, 9973
Telemetry [candidate] (9.795 ms) : 0, 9795
section iast
BytebuddyAgent [baseline] (846.903 ms) : 0, 846903
BytebuddyAgent [candidate] (841.705 ms) : 0, 841705
GlobalTracer [baseline] (230.826 ms) : 0, 230826
GlobalTracer [candidate] (229.33 ms) : 0, 229330
IAST [baseline] (23.682 ms) : 0, 23682
IAST [candidate] (23.448 ms) : 0, 23448
AppSec [baseline] (53.866 ms) : 0, 53866
AppSec [candidate] (54.887 ms) : 0, 54887
Debugger [baseline] (5.926 ms) : 0, 5926
Debugger [candidate] (5.927 ms) : 0, 5927
Remote Config [baseline] (593.755 µs) : 0, 594
Remote Config [candidate] (597.459 µs) : 0, 597
Telemetry [baseline] (7.971 ms) : 0, 7971
Telemetry [candidate] (7.894 ms) : 0, 7894
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (840.645 ms) : 0, 840645
BytebuddyAgent [candidate] (841.12 ms) : 0, 841120
GlobalTracer [baseline] (229.612 ms) : 0, 229612
GlobalTracer [candidate] (229.802 ms) : 0, 229802
IAST [baseline] (25.519 ms) : 0, 25519
IAST [candidate] (25.502 ms) : 0, 25502
AppSec [baseline] (51.276 ms) : 0, 51276
AppSec [candidate] (52.308 ms) : 0, 52308
Debugger [baseline] (5.931 ms) : 0, 5931
Debugger [candidate] (5.93 ms) : 0, 5930
Remote Config [baseline] (601.197 µs) : 0, 601
Remote Config [candidate] (615.404 µs) : 0, 615
Telemetry [baseline] (7.961 ms) : 0, 7961
Telemetry [candidate] (7.959 ms) : 0, 7959
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (845.504 ms) : 0, 845504
BytebuddyAgent [candidate] (840.684 ms) : 0, 840684
GlobalTracer [baseline] (231.057 ms) : 0, 231057
GlobalTracer [candidate] (231.364 ms) : 0, 231364
IAST [baseline] (22.623 ms) : 0, 22623
IAST [candidate] (22.579 ms) : 0, 22579
AppSec [baseline] (55.456 ms) : 0, 55456
AppSec [candidate] (56.782 ms) : 0, 56782
Debugger [baseline] (5.919 ms) : 0, 5919
Debugger [candidate] (6.013 ms) : 0, 6013
Remote Config [baseline] (606.798 µs) : 0, 607
Remote Config [candidate] (618.858 µs) : 0, 619
Telemetry [baseline] (7.787 ms) : 0, 7787
Telemetry [candidate] (7.989 ms) : 0, 7989
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.49.0-SNAPSHOT~fa8ffa9139, baseline=1.49.0-SNAPSHOT~de593cc116
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1061092
Total [baseline] (10.569 s) : 0, 10569051
Agent [candidate] (1.067 s) : 0, 1067212
Total [candidate] (10.615 s) : 0, 10615453
section appsec
Agent [baseline] (1.203 s) : 0, 1203331
Total [baseline] (10.705 s) : 0, 10705251
Agent [candidate] (1.2 s) : 0, 1199996
Total [candidate] (10.752 s) : 0, 10751535
section iast
Agent [baseline] (1.19 s) : 0, 1189681
Total [baseline] (10.893 s) : 0, 10892594
Agent [candidate] (1.189 s) : 0, 1188857
Total [candidate] (10.864 s) : 0, 10864262
section profiling
Agent [baseline] (1.32 s) : 0, 1319888
Total [baseline] (10.873 s) : 0, 10872936
Agent [candidate] (1.31 s) : 0, 1310345
Total [candidate] (10.834 s) : 0, 10833764
gantt
title petclinic - break down per module: candidate=1.49.0-SNAPSHOT~fa8ffa9139, baseline=1.49.0-SNAPSHOT~de593cc116
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (722.578 ms) : 0, 722578
BytebuddyAgent [candidate] (728.047 ms) : 0, 728047
GlobalTracer [baseline] (240.065 ms) : 0, 240065
GlobalTracer [candidate] (241.675 ms) : 0, 241675
AppSec [baseline] (57.459 ms) : 0, 57459
AppSec [candidate] (55.63 ms) : 0, 55630
Debugger [baseline] (7.701 ms) : 0, 7701
Debugger [candidate] (7.703 ms) : 0, 7703
Remote Config [baseline] (685.519 µs) : 0, 686
Remote Config [candidate] (700.669 µs) : 0, 701
Telemetry [baseline] (9.053 ms) : 0, 9053
Telemetry [candidate] (9.827 ms) : 0, 9827
section appsec
BytebuddyAgent [baseline] (743.251 ms) : 0, 743251
BytebuddyAgent [candidate] (740.274 ms) : 0, 740274
GlobalTracer [baseline] (236.157 ms) : 0, 236157
GlobalTracer [candidate] (236.03 ms) : 0, 236030
AppSec [baseline] (174.716 ms) : 0, 174716
AppSec [candidate] (175.036 ms) : 0, 175036
Debugger [baseline] (6.639 ms) : 0, 6639
Debugger [candidate] (5.932 ms) : 0, 5932
Remote Config [baseline] (629.119 µs) : 0, 629
Remote Config [candidate] (637.247 µs) : 0, 637
Telemetry [baseline] (7.409 ms) : 0, 7409
Telemetry [candidate] (7.742 ms) : 0, 7742
IAST [baseline] (21.86 ms) : 0, 21860
IAST [candidate] (21.678 ms) : 0, 21678
section iast
BytebuddyAgent [baseline] (842.765 ms) : 0, 842765
BytebuddyAgent [candidate] (841.846 ms) : 0, 841846
GlobalTracer [baseline] (230.095 ms) : 0, 230095
GlobalTracer [candidate] (230.184 ms) : 0, 230184
AppSec [baseline] (52.999 ms) : 0, 52999
AppSec [candidate] (52.054 ms) : 0, 52054
Debugger [baseline] (5.913 ms) : 0, 5913
Debugger [candidate] (5.937 ms) : 0, 5937
Remote Config [baseline] (593.58 µs) : 0, 594
Remote Config [candidate] (601.364 µs) : 0, 601
Telemetry [baseline] (7.936 ms) : 0, 7936
Telemetry [candidate] (7.919 ms) : 0, 7919
IAST [baseline] (22.778 ms) : 0, 22778
IAST [candidate] (23.667 ms) : 0, 23667
section profiling
ProfilingAgent [baseline] (103.576 ms) : 0, 103576
ProfilingAgent [candidate] (103.125 ms) : 0, 103125
BytebuddyAgent [baseline] (718.766 ms) : 0, 718766
BytebuddyAgent [candidate] (713.391 ms) : 0, 713391
GlobalTracer [baseline] (377.571 ms) : 0, 377571
GlobalTracer [candidate] (375.767 ms) : 0, 375767
AppSec [baseline] (54.356 ms) : 0, 54356
AppSec [candidate] (53.107 ms) : 0, 53107
Debugger [baseline] (6.266 ms) : 0, 6266
Debugger [candidate] (6.156 ms) : 0, 6156
Remote Config [baseline] (675.793 µs) : 0, 676
Remote Config [candidate] (660.526 µs) : 0, 661
Telemetry [baseline] (8.202 ms) : 0, 8202
Telemetry [candidate] (8.004 ms) : 0, 8004
Profiling [baseline] (103.601 ms) : 0, 103601
Profiling [candidate] (103.15 ms) : 0, 103150
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 19 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~fa8ffa9139, baseline=1.49.0-SNAPSHOT~de593cc116
dateFormat X
axisFormat %s
section baseline
no_agent (1.35 ms) : 1331, 1370
. : milestone, 1350,
appsec (1.74 ms) : 1717, 1763
. : milestone, 1740,
appsec_no_iast (1.719 ms) : 1697, 1742
. : milestone, 1719,
code_origins (1.684 ms) : 1656, 1711
. : milestone, 1684,
iast (1.513 ms) : 1488, 1538
. : milestone, 1513,
profiling (1.557 ms) : 1533, 1582
. : milestone, 1557,
tracing (1.507 ms) : 1482, 1532
. : milestone, 1507,
section candidate
no_agent (1.35 ms) : 1331, 1370
. : milestone, 1350,
appsec (1.724 ms) : 1700, 1748
. : milestone, 1724,
appsec_no_iast (1.712 ms) : 1689, 1736
. : milestone, 1712,
code_origins (1.695 ms) : 1669, 1722
. : milestone, 1695,
iast (1.522 ms) : 1496, 1547
. : milestone, 1522,
profiling (1.499 ms) : 1476, 1522
. : milestone, 1499,
tracing (1.49 ms) : 1465, 1514
. : milestone, 1490,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~fa8ffa9139, baseline=1.49.0-SNAPSHOT~de593cc116
dateFormat X
axisFormat %s
section baseline
no_agent (378.468 µs) : 358, 398
. : milestone, 378,
iast (518.808 µs) : 497, 541
. : milestone, 519,
iast_FULL (736.033 µs) : 712, 760
. : milestone, 736,
iast_GLOBAL (573.282 µs) : 550, 597
. : milestone, 573,
iast_HARDCODED_SECRET_DISABLED (520.729 µs) : 499, 543
. : milestone, 521,
iast_INACTIVE (463.586 µs) : 441, 487
. : milestone, 464,
iast_TELEMETRY_OFF (500.635 µs) : 478, 524
. : milestone, 501,
tracing (453.289 µs) : 432, 474
. : milestone, 453,
section candidate
no_agent (381.565 µs) : 362, 401
. : milestone, 382,
iast (522.652 µs) : 500, 545
. : milestone, 523,
iast_FULL (738.25 µs) : 715, 762
. : milestone, 738,
iast_GLOBAL (577.19 µs) : 553, 601
. : milestone, 577,
iast_HARDCODED_SECRET_DISABLED (505.328 µs) : 483, 527
. : milestone, 505,
iast_INACTIVE (469.248 µs) : 446, 492
. : milestone, 469,
iast_TELEMETRY_OFF (516.116 µs) : 492, 540
. : milestone, 516,
tracing (452.054 µs) : 431, 473
. : milestone, 452,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~fa8ffa9139, baseline=1.49.0-SNAPSHOT~de593cc116
dateFormat X
axisFormat %s
section baseline
no_agent (15.448 s) : 15448000, 15448000
. : milestone, 15448000,
appsec (14.865 s) : 14865000, 14865000
. : milestone, 14865000,
iast (18.822 s) : 18822000, 18822000
. : milestone, 18822000,
iast_GLOBAL (17.751 s) : 17751000, 17751000
. : milestone, 17751000,
profiling (15.219 s) : 15219000, 15219000
. : milestone, 15219000,
tracing (14.95 s) : 14950000, 14950000
. : milestone, 14950000,
section candidate
no_agent (15.622 s) : 15622000, 15622000
. : milestone, 15622000,
appsec (15.103 s) : 15103000, 15103000
. : milestone, 15103000,
iast (19.169 s) : 19169000, 19169000
. : milestone, 19169000,
iast_GLOBAL (18.166 s) : 18166000, 18166000
. : milestone, 18166000,
profiling (15.13 s) : 15130000, 15130000
. : milestone, 15130000,
tracing (14.989 s) : 14989000, 14989000
. : milestone, 14989000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~fa8ffa9139, baseline=1.49.0-SNAPSHOT~de593cc116
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (2.393 ms) : 2346, 2441
. : milestone, 2393,
iast (2.167 ms) : 2108, 2227
. : milestone, 2167,
iast_GLOBAL (2.203 ms) : 2144, 2262
. : milestone, 2203,
profiling (2.041 ms) : 1992, 2089
. : milestone, 2041,
tracing (1.999 ms) : 1953, 2045
. : milestone, 1999,
section candidate
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (2.378 ms) : 2331, 2425
. : milestone, 2378,
iast (2.163 ms) : 2104, 2222
. : milestone, 2163,
iast_GLOBAL (2.207 ms) : 2148, 2267
. : milestone, 2207,
profiling (2.028 ms) : 1980, 2076
. : milestone, 2028,
tracing (1.987 ms) : 1941, 2032
. : milestone, 1987,
|
PerfectSlayer
approved these changes
Apr 25, 2025
mcculls
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: core
Tracer core
tag: no release notes
Changes to exclude from release notes
type: enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
The sampling formula has changed a bit to have an consistent one across all tracers. The change is relatively small in Java as it only require a change from
<
to<=
Motivation
We are aiming to have consistent sampling over all tracers.
Additional Notes
I added a new TraceID to the unit test that lands exactly on
0.5 * (2^64 -1)
when multiplicated by the knuthContributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: APMAPI-1262