-
Notifications
You must be signed in to change notification settings - Fork 299
Add process tags to client stats payload #8704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: andrea.marziali/processtags
Are you sure you want to change the base?
Add process tags to client stats payload #8704
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 10 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.49.0-SNAPSHOT~281251ce9d, baseline=1.49.0-SNAPSHOT~b00c24e26a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1065334
Total [baseline] (10.496 s) : 0, 10495901
Agent [candidate] (1.06 s) : 0, 1059643
Total [candidate] (10.481 s) : 0, 10480695
section appsec
Agent [baseline] (1.203 s) : 0, 1202656
Total [baseline] (10.841 s) : 0, 10841459
Agent [candidate] (1.198 s) : 0, 1198475
Total [candidate] (10.789 s) : 0, 10788720
section iast
Agent [baseline] (1.184 s) : 0, 1183650
Total [baseline] (11.048 s) : 0, 11047566
Agent [candidate] (1.194 s) : 0, 1193690
Total [candidate] (11.049 s) : 0, 11049348
section profiling
Agent [baseline] (1.292 s) : 0, 1292328
Total [baseline] (10.98 s) : 0, 10980254
Agent [candidate] (1.298 s) : 0, 1297874
Total [candidate] (10.888 s) : 0, 10888307
gantt
title petclinic - break down per module: candidate=1.49.0-SNAPSHOT~281251ce9d, baseline=1.49.0-SNAPSHOT~b00c24e26a
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (725.967 ms) : 0, 725967
BytebuddyAgent [candidate] (723.679 ms) : 0, 723679
GlobalTracer [baseline] (240.91 ms) : 0, 240910
GlobalTracer [candidate] (239.144 ms) : 0, 239144
AppSec [baseline] (56.933 ms) : 0, 56933
AppSec [candidate] (55.418 ms) : 0, 55418
Debugger [baseline] (4.386 ms) : 0, 4386
Debugger [candidate] (4.416 ms) : 0, 4416
Remote Config [baseline] (699.118 µs) : 0, 699
Remote Config [candidate] (695.324 µs) : 0, 695
Telemetry [baseline] (12.872 ms) : 0, 12872
Telemetry [candidate] (12.726 ms) : 0, 12726
section appsec
BytebuddyAgent [baseline] (743.378 ms) : 0, 743378
BytebuddyAgent [candidate] (739.028 ms) : 0, 739028
GlobalTracer [baseline] (236.085 ms) : 0, 236085
GlobalTracer [candidate] (235.981 ms) : 0, 235981
AppSec [baseline] (175.949 ms) : 0, 175949
AppSec [candidate] (175.989 ms) : 0, 175989
Debugger [baseline] (4.226 ms) : 0, 4226
Debugger [candidate] (4.228 ms) : 0, 4228
Remote Config [baseline] (624.259 µs) : 0, 624
Remote Config [candidate] (634.771 µs) : 0, 635
Telemetry [baseline] (8.155 ms) : 0, 8155
Telemetry [candidate] (8.213 ms) : 0, 8213
IAST [baseline] (21.56 ms) : 0, 21560
IAST [candidate] (21.988 ms) : 0, 21988
section iast
BytebuddyAgent [baseline] (838.378 ms) : 0, 838378
BytebuddyAgent [candidate] (846.802 ms) : 0, 846802
GlobalTracer [baseline] (229.979 ms) : 0, 229979
GlobalTracer [candidate] (230.906 ms) : 0, 230906
AppSec [baseline] (53.52 ms) : 0, 53520
AppSec [candidate] (55.958 ms) : 0, 55958
Debugger [baseline] (4.213 ms) : 0, 4213
Debugger [candidate] (4.23 ms) : 0, 4230
Remote Config [baseline] (602.897 µs) : 0, 603
Remote Config [candidate] (619.945 µs) : 0, 620
Telemetry [baseline] (8.675 ms) : 0, 8675
Telemetry [candidate] (8.751 ms) : 0, 8751
IAST [baseline] (25.014 ms) : 0, 25014
IAST [candidate] (22.934 ms) : 0, 22934
section profiling
ProfilingAgent [baseline] (101.382 ms) : 0, 101382
ProfilingAgent [candidate] (102.811 ms) : 0, 102811
BytebuddyAgent [baseline] (712.887 ms) : 0, 712887
BytebuddyAgent [candidate] (715.86 ms) : 0, 715860
GlobalTracer [baseline] (359.904 ms) : 0, 359904
GlobalTracer [candidate] (360.762 ms) : 0, 360762
AppSec [baseline] (53.787 ms) : 0, 53787
AppSec [candidate] (53.739 ms) : 0, 53739
Debugger [baseline] (4.371 ms) : 0, 4371
Debugger [candidate] (4.439 ms) : 0, 4439
Remote Config [baseline] (672.718 µs) : 0, 673
Remote Config [candidate] (676.203 µs) : 0, 676
Telemetry [baseline] (8.979 ms) : 0, 8979
Telemetry [candidate] (9.038 ms) : 0, 9038
Profiling [baseline] (101.408 ms) : 0, 101408
Profiling [candidate] (102.836 ms) : 0, 102836
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.49.0-SNAPSHOT~281251ce9d, baseline=1.49.0-SNAPSHOT~b00c24e26a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1063993
Total [baseline] (8.7 s) : 0, 8699817
Agent [candidate] (1.059 s) : 0, 1058632
Total [candidate] (8.703 s) : 0, 8702751
section iast
Agent [baseline] (1.189 s) : 0, 1189057
Total [baseline] (9.245 s) : 0, 9244683
Agent [candidate] (1.183 s) : 0, 1182882
Total [candidate] (9.24 s) : 0, 9239895
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.182 s) : 0, 1182212
Total [baseline] (9.251 s) : 0, 9251351
Agent [candidate] (1.186 s) : 0, 1185847
Total [candidate] (9.228 s) : 0, 9227777
section iast_TELEMETRY_OFF
Agent [baseline] (1.176 s) : 0, 1176466
Total [baseline] (9.248 s) : 0, 9247608
Agent [candidate] (1.182 s) : 0, 1182150
Total [candidate] (9.271 s) : 0, 9271180
gantt
title insecure-bank - break down per module: candidate=1.49.0-SNAPSHOT~281251ce9d, baseline=1.49.0-SNAPSHOT~b00c24e26a
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (727.174 ms) : 0, 727174
BytebuddyAgent [candidate] (722.168 ms) : 0, 722168
GlobalTracer [baseline] (240.591 ms) : 0, 240591
GlobalTracer [candidate] (239.208 ms) : 0, 239208
AppSec [baseline] (55.434 ms) : 0, 55434
AppSec [candidate] (55.192 ms) : 0, 55192
Debugger [baseline] (5.12 ms) : 0, 5120
Debugger [candidate] (4.366 ms) : 0, 4366
Remote Config [baseline] (1.382 ms) : 0, 1382
Remote Config [candidate] (1.413 ms) : 0, 1413
Telemetry [baseline] (10.659 ms) : 0, 10659
Telemetry [candidate] (12.803 ms) : 0, 12803
section iast
BytebuddyAgent [baseline] (843.532 ms) : 0, 843532
BytebuddyAgent [candidate] (838.021 ms) : 0, 838021
GlobalTracer [baseline] (230.128 ms) : 0, 230128
GlobalTracer [candidate] (229.26 ms) : 0, 229260
IAST [baseline] (22.884 ms) : 0, 22884
IAST [candidate] (24.195 ms) : 0, 24195
AppSec [baseline] (55.454 ms) : 0, 55454
AppSec [candidate] (54.46 ms) : 0, 54460
Debugger [baseline] (4.234 ms) : 0, 4234
Debugger [candidate] (4.225 ms) : 0, 4225
Remote Config [baseline] (604.665 µs) : 0, 605
Remote Config [candidate] (595.624 µs) : 0, 596
Telemetry [baseline] (8.705 ms) : 0, 8705
Telemetry [candidate] (8.719 ms) : 0, 8719
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (837.82 ms) : 0, 837820
BytebuddyAgent [candidate] (839.487 ms) : 0, 839487
GlobalTracer [baseline] (229.046 ms) : 0, 229046
GlobalTracer [candidate] (230.805 ms) : 0, 230805
IAST [baseline] (24.327 ms) : 0, 24327
IAST [candidate] (23.589 ms) : 0, 23589
AppSec [baseline] (54.126 ms) : 0, 54126
AppSec [candidate] (55.076 ms) : 0, 55076
Debugger [baseline] (4.261 ms) : 0, 4261
Debugger [candidate] (4.236 ms) : 0, 4236
Remote Config [baseline] (613.182 µs) : 0, 613
Remote Config [candidate] (602.405 µs) : 0, 602
Telemetry [baseline] (8.739 ms) : 0, 8739
Telemetry [candidate] (8.675 ms) : 0, 8675
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (833.618 ms) : 0, 833618
BytebuddyAgent [candidate] (837.011 ms) : 0, 837011
GlobalTracer [baseline] (228.855 ms) : 0, 228855
GlobalTracer [candidate] (230.177 ms) : 0, 230177
IAST [baseline] (22.149 ms) : 0, 22149
IAST [candidate] (22.336 ms) : 0, 22336
AppSec [baseline] (55.261 ms) : 0, 55261
AppSec [candidate] (55.784 ms) : 0, 55784
Debugger [baseline] (4.131 ms) : 0, 4131
Debugger [candidate] (4.173 ms) : 0, 4173
Remote Config [baseline] (612.574 µs) : 0, 613
Remote Config [candidate] (627.812 µs) : 0, 628
Telemetry [baseline] (8.523 ms) : 0, 8523
Telemetry [candidate] (8.69 ms) : 0, 8690
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~281251ce9d, baseline=1.49.0-SNAPSHOT~b00c24e26a
dateFormat X
axisFormat %s
section baseline
no_agent (379.26 µs) : 358, 400
. : milestone, 379,
iast (507.036 µs) : 485, 529
. : milestone, 507,
iast_FULL (725.022 µs) : 703, 747
. : milestone, 725,
iast_GLOBAL (557.657 µs) : 536, 580
. : milestone, 558,
iast_HARDCODED_SECRET_DISABLED (506.721 µs) : 485, 528
. : milestone, 507,
iast_INACTIVE (464.269 µs) : 443, 486
. : milestone, 464,
iast_TELEMETRY_OFF (494.602 µs) : 473, 516
. : milestone, 495,
tracing (457.98 µs) : 437, 479
. : milestone, 458,
section candidate
no_agent (376.666 µs) : 356, 397
. : milestone, 377,
iast (510.119 µs) : 488, 532
. : milestone, 510,
iast_FULL (728.006 µs) : 706, 750
. : milestone, 728,
iast_GLOBAL (549.112 µs) : 527, 571
. : milestone, 549,
iast_HARDCODED_SECRET_DISABLED (515.915 µs) : 494, 538
. : milestone, 516,
iast_INACTIVE (466.777 µs) : 445, 489
. : milestone, 467,
iast_TELEMETRY_OFF (500.905 µs) : 479, 523
. : milestone, 501,
tracing (459.671 µs) : 438, 481
. : milestone, 460,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~281251ce9d, baseline=1.49.0-SNAPSHOT~b00c24e26a
dateFormat X
axisFormat %s
section baseline
no_agent (1.358 ms) : 1338, 1378
. : milestone, 1358,
appsec (1.71 ms) : 1686, 1733
. : milestone, 1710,
appsec_no_iast (1.709 ms) : 1685, 1732
. : milestone, 1709,
code_origins (1.704 ms) : 1675, 1733
. : milestone, 1704,
iast (1.502 ms) : 1478, 1527
. : milestone, 1502,
profiling (1.512 ms) : 1486, 1537
. : milestone, 1512,
tracing (1.485 ms) : 1461, 1509
. : milestone, 1485,
section candidate
no_agent (1.364 ms) : 1345, 1384
. : milestone, 1364,
appsec (1.735 ms) : 1712, 1759
. : milestone, 1735,
appsec_no_iast (1.722 ms) : 1698, 1746
. : milestone, 1722,
code_origins (1.693 ms) : 1665, 1720
. : milestone, 1693,
iast (1.518 ms) : 1493, 1544
. : milestone, 1518,
profiling (1.512 ms) : 1489, 1535
. : milestone, 1512,
tracing (1.5 ms) : 1473, 1527
. : milestone, 1500,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~281251ce9d, baseline=1.49.0-SNAPSHOT~b00c24e26a
dateFormat X
axisFormat %s
section baseline
no_agent (14.922 s) : 14922000, 14922000
. : milestone, 14922000,
appsec (14.763 s) : 14763000, 14763000
. : milestone, 14763000,
iast (18.792 s) : 18792000, 18792000
. : milestone, 18792000,
iast_GLOBAL (17.897 s) : 17897000, 17897000
. : milestone, 17897000,
profiling (15.043 s) : 15043000, 15043000
. : milestone, 15043000,
tracing (15.013 s) : 15013000, 15013000
. : milestone, 15013000,
section candidate
no_agent (15.437 s) : 15437000, 15437000
. : milestone, 15437000,
appsec (15.064 s) : 15064000, 15064000
. : milestone, 15064000,
iast (18.67 s) : 18670000, 18670000
. : milestone, 18670000,
iast_GLOBAL (17.998 s) : 17998000, 17998000
. : milestone, 17998000,
profiling (15.164 s) : 15164000, 15164000
. : milestone, 15164000,
tracing (15.288 s) : 15288000, 15288000
. : milestone, 15288000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~281251ce9d, baseline=1.49.0-SNAPSHOT~b00c24e26a
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (2.335 ms) : 2292, 2379
. : milestone, 2335,
iast (2.124 ms) : 2068, 2179
. : milestone, 2124,
iast_GLOBAL (2.166 ms) : 2110, 2222
. : milestone, 2166,
profiling (1.967 ms) : 1923, 2011
. : milestone, 1967,
tracing (1.957 ms) : 1915, 2000
. : milestone, 1957,
section candidate
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (2.334 ms) : 2291, 2377
. : milestone, 2334,
iast (2.107 ms) : 2052, 2163
. : milestone, 2107,
iast_GLOBAL (2.16 ms) : 2105, 2216
. : milestone, 2160,
profiling (1.996 ms) : 1950, 2041
. : milestone, 1996,
tracing (1.945 ms) : 1903, 1987
. : milestone, 1945,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 if sync'd in the backend, ideally system-tests should be added.
What Does This Do
Adds process tags to stats client payload.
See DataDog/datadog-agent#35746 and #8698
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]