Skip to content

setup.sh should check for JAVA_HOME if version is not 1.8 #8702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 2, 2025
Merged

setup.sh should check for JAVA_HOME if version is not 1.8 #8702

merged 2 commits into from
May 2, 2025

Conversation

mobuchowski
Copy link
Contributor

What Does This Do

The setup.sh check needs an additional condition if java binary is not Java 8. Else, gradle fails:

./gradlew clean spotlessApply shadowJar --rerun-tasks

(...)

> Task :dd-smoke-tests:iast-propagation:compileKotlin FAILED
FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':dd-smoke-tests:iast-propagation:compileKotlin'.
> Inconsistent JVM-target compatibility detected for tasks 'compileJava' (1.8) and 'compileKotlin' (17).

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@mobuchowski mobuchowski requested a review from a team as a code owner April 16, 2025 15:19
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 16, 2025 •
edited
Loading

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@mobuchowski mobuchowski added comp: tooling Build & Tooling type: enhancement tag: no release notes Changes to exclude from release notes labels Apr 16, 2025
@pr-commenter
Copy link

pr-commenter bot commented Apr 16, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mobuchowski/setup-sh-check-for-java
git_commit_date 1745919592 1745906379
git_commit_sha 0698839 1ce7e72
release_version 1.49.0-SNAPSHOT~069883952e 1.49.0-SNAPSHOT~1ce7e72239
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1745923693 1745923693
ci_job_id 916247344 916247344
ci_pipeline_id 63581801 63581801
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-6hdzond-project-304-concurrent-0-hbnxyhai 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-6hdzond-project-304-concurrent-0-hbnxyhai 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 8 performance improvements and 22 performance regressions! Performance is the same for 34 metrics, 7 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:insecure-bank:iast:Agent.start worse
[+40.109ms; +74.806ms] or [+3.523%; +6.571%]		 1.196s 1.138s
scenario:startup:insecure-bank:iast:BytebuddyAgent worse
[+42.440ms; +70.011ms] or [+5.364%; +8.849%]		 847.403ms 791.178ms
scenario:startup:insecure-bank:iast:Debugger better
[-1.653ms; -1.418ms] or [-28.243%; -24.215%]		 4.319ms 5.854ms
scenario:startup:insecure-bank:iast:Telemetry worse
[+769.781µs; +1180.694µs] or [+9.814%; +15.053%]		 8.819ms 7.844ms
scenario:startup:insecure-bank:iast_HARDCODED_SECRET_DISABLED:Agent.start worse
[+23.455ms; +56.228ms] or [+2.045%; +4.901%]		 1.187s 1.147s
scenario:startup:insecure-bank:iast_HARDCODED_SECRET_DISABLED:BytebuddyAgent worse
[+31.768ms; +55.903ms] or [+3.985%; +7.013%]		 840.965ms 797.130ms
scenario:startup:insecure-bank:iast_HARDCODED_SECRET_DISABLED:Debugger better
[-1.980ms; -1.664ms] or [-32.849%; -27.612%]		 4.206ms 6.028ms
scenario:startup:insecure-bank:iast_HARDCODED_SECRET_DISABLED:Telemetry worse
[+488.086µs; +820.347µs] or [+6.037%; +10.147%]		 8.739ms 8.085ms
scenario:startup:insecure-bank:iast_TELEMETRY_OFF:Agent.start worse
[+31.792ms; +75.206ms] or [+2.787%; +6.594%]		 1.194s 1.141s
scenario:startup:insecure-bank:iast_TELEMETRY_OFF:BytebuddyAgent worse
[+37.076ms; +70.478ms] or [+4.678%; +8.892%]		 846.353ms 792.576ms
scenario:startup:insecure-bank:iast_TELEMETRY_OFF:Debugger better
[-1.861ms; -1.657ms] or [-31.396%; -27.949%]		 4.169ms 5.928ms
scenario:startup:insecure-bank:iast_TELEMETRY_OFF:Telemetry worse
[+800.574µs; +988.211µs] or [+10.278%; +12.686%]		 8.684ms 7.790ms
scenario:startup:insecure-bank:tracing:Agent.start worse
[+44.245ms; +54.303ms] or [+4.390%; +5.388%]		 1.057s 1.008s
scenario:startup:insecure-bank:tracing:BytebuddyAgent worse
[+46.374ms; +51.598ms] or [+6.898%; +7.675%]		 721.271ms 672.285ms
scenario:startup:insecure-bank:tracing:Debugger better
[-1.838ms; -1.716ms] or [-29.840%; -27.868%]		 4.382ms 6.159ms
scenario:startup:petclinic:appsec:Agent.start worse
[+32.813ms; +63.024ms] or [+2.837%; +5.448%]		 1.205s 1.157s
scenario:startup:petclinic:appsec:BytebuddyAgent worse
[+40.150ms; +60.018ms] or [+5.787%; +8.651%]		 743.877ms 693.793ms
scenario:startup:petclinic:iast:Agent.start worse
[+24.956ms; +56.862ms] or [+2.175%; +4.955%]		 1.188s 1.148s
scenario:startup:petclinic:iast:BytebuddyAgent worse
[+31.949ms; +55.641ms] or [+4.006%; +6.977%]		 841.288ms 797.493ms
scenario:startup:petclinic:iast:Debugger better
[-1.784ms; -1.493ms] or [-30.213%; -25.287%]		 4.265ms 5.904ms
scenario:startup:petclinic:iast:Telemetry worse
[+508.762µs; +1033.863µs] or [+6.383%; +12.971%]		 8.742ms 7.970ms
scenario:startup:petclinic:profiling:ProfilingAgent worse
[+2.441ms; +6.396ms] or [+2.494%; +6.535%]		 102.287ms 97.869ms
scenario:startup:petclinic:profiling:BytebuddyAgent worse
[+23.734ms; +54.136ms] or [+3.504%; +7.992%]		 716.279ms 677.344ms
scenario:startup:petclinic:profiling:GlobalTracer better
[-24.336ms; -12.613ms] or [-6.393%; -3.314%]		 362.164ms 380.638ms
scenario:startup:petclinic:profiling:Debugger better
[-1.861ms; -1.631ms] or [-30.315%; -26.570%]		 4.392ms 6.138ms
scenario:startup:petclinic:profiling:Telemetry worse
[+522.466µs; +880.084µs] or [+6.299%; +10.610%]		 8.996ms 8.295ms
scenario:startup:petclinic:profiling:Profiling worse
[+2.441ms; +6.395ms] or [+2.493%; +6.533%]		 102.312ms 97.894ms
scenario:startup:petclinic:tracing:Agent.start worse
[+34.952ms; +55.589ms] or [+3.457%; +5.498%]		 1.056s 1.011s
scenario:startup:petclinic:tracing:BytebuddyAgent worse
[+41.891ms; +54.579ms] or [+6.224%; +8.109%]		 721.320ms 673.085ms
scenario:startup:petclinic:tracing:Debugger better
[-1.882ms; -1.618ms] or [-30.482%; -26.199%]		 4.424ms 6.174ms
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.49.0-SNAPSHOT~1ce7e72239, baseline=1.49.0-SNAPSHOT~069883952e

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.011 s) : 0, 1011142
Total [baseline] (10.54 s) : 0, 10539866
Agent [candidate] (1.056 s) : 0, 1056413
Total [candidate] (10.493 s) : 0, 10493034
section appsec
Agent [baseline] (1.157 s) : 0, 1156819
Total [baseline] (10.759 s) : 0, 10758974
Agent [candidate] (1.205 s) : 0, 1204738
Total [candidate] (10.819 s) : 0, 10819166
section iast
Agent [baseline] (1.148 s) : 0, 1147550
Total [baseline] (10.852 s) : 0, 10851587
Agent [candidate] (1.188 s) : 0, 1188459
Total [candidate] (11.051 s) : 0, 11050700
section profiling
Agent [baseline] (1.277 s) : 0, 1276502
Total [baseline] (10.946 s) : 0, 10946351
Agent [candidate] (1.299 s) : 0, 1298765
Total [candidate] (10.958 s) : 0, 10958053
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.011 s -
Agent appsec 1.157 s 145.677 ms (14.4%)
Agent iast 1.148 s 136.407 ms (13.5%)
Agent profiling 1.277 s 265.36 ms (26.2%)
Total tracing 10.54 s -
Total appsec 10.759 s 219.108 ms (2.1%)
Total iast 10.852 s 311.721 ms (3.0%)
Total profiling 10.946 s 406.484 ms (3.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.056 s -
Agent appsec 1.205 s 148.325 ms (14.0%)
Agent iast 1.188 s 132.046 ms (12.5%)
Agent profiling 1.299 s 242.352 ms (22.9%)
Total tracing 10.493 s -
Total appsec 10.819 s 326.132 ms (3.1%)
Total iast 11.051 s 557.666 ms (5.3%)
Total profiling 10.958 s 465.019 ms (4.4%) 
gantt
    title petclinic - break down per module: candidate=1.49.0-SNAPSHOT~1ce7e72239, baseline=1.49.0-SNAPSHOT~069883952e

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (673.085 ms) : 0, 673085
BytebuddyAgent [candidate] (721.32 ms) : 0, 721320
GlobalTracer [baseline] (241.229 ms) : 0, 241229
GlobalTracer [candidate] (239.45 ms) : 0, 239450
AppSec [baseline] (55.104 ms) : 0, 55104
AppSec [candidate] (55.507 ms) : 0, 55507
Debugger [baseline] (6.174 ms) : 0, 6174
Debugger [candidate] (4.424 ms) : 0, 4424
Remote Config [baseline] (702.857 µs) : 0, 703
Remote Config [candidate] (714.653 µs) : 0, 715
Telemetry [baseline] (11.429 ms) : 0, 11429
Telemetry [candidate] (11.541 ms) : 0, 11541
section appsec
BytebuddyAgent [baseline] (693.793 ms) : 0, 693793
BytebuddyAgent [candidate] (743.877 ms) : 0, 743877
GlobalTracer [baseline] (238.004 ms) : 0, 238004
GlobalTracer [candidate] (237.537 ms) : 0, 237537
IAST [baseline] (21.836 ms) : 0, 21836
IAST [candidate] (21.999 ms) : 0, 21999
AppSec [baseline] (175.838 ms) : 0, 175838
AppSec [candidate] (175.37 ms) : 0, 175370
Debugger [baseline] (5.881 ms) : 0, 5881
Debugger [candidate] (4.596 ms) : 0, 4596
Remote Config [baseline] (641.009 µs) : 0, 641
Remote Config [candidate] (634.401 µs) : 0, 634
Telemetry [baseline] (8.173 ms) : 0, 8173
Telemetry [candidate] (8.18 ms) : 0, 8180
section iast
BytebuddyAgent [baseline] (797.493 ms) : 0, 797493
BytebuddyAgent [candidate] (841.288 ms) : 0, 841288
GlobalTracer [baseline] (231.977 ms) : 0, 231977
GlobalTracer [candidate] (230.543 ms) : 0, 230543
IAST [baseline] (23.033 ms) : 0, 23033
IAST [candidate] (23.03 ms) : 0, 23030
AppSec [baseline] (56.984 ms) : 0, 56984
AppSec [candidate] (56.493 ms) : 0, 56493
Debugger [baseline] (5.904 ms) : 0, 5904
Debugger [candidate] (4.266 ms) : 0, 4266
Remote Config [baseline] (595.806 µs) : 0, 596
Remote Config [candidate] (616.812 µs) : 0, 617
Telemetry [baseline] (7.97 ms) : 0, 7970
Telemetry [candidate] (8.742 ms) : 0, 8742
section profiling
BytebuddyAgent [baseline] (677.344 ms) : 0, 677344
BytebuddyAgent [candidate] (716.279 ms) : 0, 716279
GlobalTracer [baseline] (380.638 ms) : 0, 380638
GlobalTracer [candidate] (362.164 ms) : 0, 362164
AppSec [baseline] (54.671 ms) : 0, 54671
AppSec [candidate] (53.401 ms) : 0, 53401
Debugger [baseline] (6.138 ms) : 0, 6138
Debugger [candidate] (4.392 ms) : 0, 4392
Remote Config [baseline] (665.823 µs) : 0, 666
Remote Config [candidate] (664.778 µs) : 0, 665
Telemetry [baseline] (8.295 ms) : 0, 8295
Telemetry [candidate] (8.996 ms) : 0, 8996
ProfilingAgent [baseline] (97.869 ms) : 0, 97869
ProfilingAgent [candidate] (102.287 ms) : 0, 102287
Profiling [baseline] (97.894 ms) : 0, 97894
Profiling [candidate] (102.312 ms) : 0, 102312
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.49.0-SNAPSHOT~1ce7e72239, baseline=1.49.0-SNAPSHOT~069883952e

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.008 s) : 0, 1007829
Total [baseline] (8.636 s) : 0, 8636457
Agent [candidate] (1.057 s) : 0, 1057103
Total [candidate] (8.691 s) : 0, 8691498
section iast
Agent [baseline] (1.138 s) : 0, 1138396
Total [baseline] (9.252 s) : 0, 9251940
Agent [candidate] (1.196 s) : 0, 1195854
Total [candidate] (9.267 s) : 0, 9266858
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.147 s) : 0, 1147158
Total [baseline] (9.222 s) : 0, 9222274
Agent [candidate] (1.187 s) : 0, 1186999
Total [candidate] (9.243 s) : 0, 9242592
section iast_TELEMETRY_OFF
Agent [baseline] (1.141 s) : 0, 1140543
Total [baseline] (9.189 s) : 0, 9189382
Agent [candidate] (1.194 s) : 0, 1194042
Total [candidate] (9.29 s) : 0, 9289794
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.008 s -
Agent iast 1.138 s 130.567 ms (13.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.147 s 139.329 ms (13.8%)
Agent iast_TELEMETRY_OFF 1.141 s 132.714 ms (13.2%)
Total tracing 8.636 s -
Total iast 9.252 s 615.483 ms (7.1%)
Total iast_HARDCODED_SECRET_DISABLED 9.222 s 585.817 ms (6.8%)
Total iast_TELEMETRY_OFF 9.189 s 552.924 ms (6.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.057 s -
Agent iast 1.196 s 138.751 ms (13.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.187 s 129.896 ms (12.3%)
Agent iast_TELEMETRY_OFF 1.194 s 136.94 ms (13.0%)
Total tracing 8.691 s -
Total iast 9.267 s 575.359 ms (6.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.243 s 551.094 ms (6.3%)
Total iast_TELEMETRY_OFF 9.29 s 598.296 ms (6.9%) 
gantt
    title insecure-bank - break down per module: candidate=1.49.0-SNAPSHOT~1ce7e72239, baseline=1.49.0-SNAPSHOT~069883952e

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (672.285 ms) : 0, 672285
BytebuddyAgent [candidate] (721.271 ms) : 0, 721271
GlobalTracer [baseline] (241.079 ms) : 0, 241079
GlobalTracer [candidate] (239.904 ms) : 0, 239904
AppSec [baseline] (54.784 ms) : 0, 54784
AppSec [candidate] (55.263 ms) : 0, 55263
Debugger [baseline] (6.159 ms) : 0, 6159
Debugger [candidate] (4.382 ms) : 0, 4382
Remote Config [baseline] (715.23 µs) : 0, 715
Remote Config [candidate] (2.132 ms) : 0, 2132
Telemetry [baseline] (9.239 ms) : 0, 9239
Telemetry [candidate] (10.662 ms) : 0, 10662
section iast
BytebuddyAgent [baseline] (791.178 ms) : 0, 791178
BytebuddyAgent [candidate] (847.403 ms) : 0, 847403
GlobalTracer [baseline] (230.635 ms) : 0, 230635
GlobalTracer [candidate] (231.748 ms) : 0, 231748
IAST [baseline] (22.756 ms) : 0, 22756
IAST [candidate] (23.891 ms) : 0, 23891
AppSec [baseline] (56.166 ms) : 0, 56166
AppSec [candidate] (55.513 ms) : 0, 55513
Debugger [baseline] (5.854 ms) : 0, 5854
Debugger [candidate] (4.319 ms) : 0, 4319
Remote Config [baseline] (584.83 µs) : 0, 585
Remote Config [candidate] (611.541 µs) : 0, 612
Telemetry [baseline] (7.844 ms) : 0, 7844
Telemetry [candidate] (8.819 ms) : 0, 8819
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (797.13 ms) : 0, 797130
BytebuddyAgent [candidate] (840.965 ms) : 0, 840965
GlobalTracer [baseline] (231.721 ms) : 0, 231721
GlobalTracer [candidate] (230.155 ms) : 0, 230155
IAST [baseline] (23.059 ms) : 0, 23059
IAST [candidate] (23.647 ms) : 0, 23647
AppSec [baseline] (56.966 ms) : 0, 56966
AppSec [candidate] (55.273 ms) : 0, 55273
Debugger [baseline] (6.028 ms) : 0, 6028
Debugger [candidate] (4.206 ms) : 0, 4206
Remote Config [baseline] (597.689 µs) : 0, 598
Remote Config [candidate] (607.342 µs) : 0, 607
Telemetry [baseline] (8.085 ms) : 0, 8085
Telemetry [candidate] (8.739 ms) : 0, 8739
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (792.576 ms) : 0, 792576
BytebuddyAgent [candidate] (846.353 ms) : 0, 846353
GlobalTracer [baseline] (231.006 ms) : 0, 231006
GlobalTracer [candidate] (231.892 ms) : 0, 231892
IAST [baseline] (22.337 ms) : 0, 22337
IAST [candidate] (22.722 ms) : 0, 22722
AppSec [baseline] (56.843 ms) : 0, 56843
AppSec [candidate] (55.986 ms) : 0, 55986
Debugger [baseline] (5.928 ms) : 0, 5928
Debugger [candidate] (4.169 ms) : 0, 4169
Remote Config [baseline] (599.045 µs) : 0, 599
Remote Config [candidate] (627.971 µs) : 0, 628
Telemetry [baseline] (7.79 ms) : 0, 7790
Telemetry [candidate] (8.684 ms) : 0, 8684
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-04-29T10:18:27 2025-04-29T10:26:09
git_branch master mobuchowski/setup-sh-check-for-java
git_commit_date 1745919592 1745906379
git_commit_sha 0698839 1ce7e72
release_version 1.49.0-SNAPSHOT~069883952e 1.49.0-SNAPSHOT~1ce7e72239
start_time 2025-04-29T10:18:13 2025-04-29T10:25:55
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1745922766 1745922766
ci_job_id 916247349 916247349
ci_pipeline_id 63581801 63581801
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-6hdzond-project-304-concurrent-1-r2xldzn5 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-6hdzond-project-304-concurrent-1-r2xldzn5 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~1ce7e72239, baseline=1.49.0-SNAPSHOT~069883952e
    dateFormat X
    axisFormat %s
section baseline
no_agent (378.505 µs) : 358, 399
.   : milestone, 379,
iast (513.481 µs) : 490, 537
.   : milestone, 513,
iast_FULL (728.993 µs) : 706, 752
.   : milestone, 729,
iast_GLOBAL (557.034 µs) : 534, 580
.   : milestone, 557,
iast_HARDCODED_SECRET_DISABLED (510.846 µs) : 488, 534
.   : milestone, 511,
iast_INACTIVE (466.543 µs) : 444, 489
.   : milestone, 467,
iast_TELEMETRY_OFF (508.273 µs) : 485, 531
.   : milestone, 508,
tracing (458.16 µs) : 436, 480
.   : milestone, 458,
section candidate
no_agent (380.055 µs) : 360, 400
.   : milestone, 380,
iast (511.49 µs) : 489, 534
.   : milestone, 511,
iast_FULL (727.549 µs) : 705, 750
.   : milestone, 728,
iast_GLOBAL (558.454 µs) : 536, 581
.   : milestone, 558,
iast_HARDCODED_SECRET_DISABLED (511.254 µs) : 490, 533
.   : milestone, 511,
iast_INACTIVE (464.368 µs) : 442, 486
.   : milestone, 464,
iast_TELEMETRY_OFF (499.416 µs) : 477, 521
.   : milestone, 499,
tracing (459.722 µs) : 439, 481
.   : milestone, 460,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 378.505 µs [357.928 µs, 399.083 µs] -
iast 513.481 µs [490.359 µs, 536.602 µs] 134.975 µs (35.7%)
iast_FULL 728.993 µs [705.593 µs, 752.392 µs] 350.487 µs (92.6%)
iast_GLOBAL 557.034 µs [533.903 µs, 580.165 µs] 178.529 µs (47.2%)
iast_HARDCODED_SECRET_DISABLED 510.846 µs [487.545 µs, 534.146 µs] 132.34 µs (35.0%)
iast_INACTIVE 466.543 µs [444.464 µs, 488.621 µs] 88.037 µs (23.3%)
iast_TELEMETRY_OFF 508.273 µs [485.15 µs, 531.397 µs] 129.768 µs (34.3%)
tracing 458.16 µs [436.011 µs, 480.309 µs] 79.655 µs (21.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 380.055 µs [360.116 µs, 399.995 µs] -
iast 511.49 µs [489.438 µs, 533.542 µs] 131.435 µs (34.6%)
iast_FULL 727.549 µs [705.265 µs, 749.834 µs] 347.494 µs (91.4%)
iast_GLOBAL 558.454 µs [535.791 µs, 581.118 µs] 178.399 µs (46.9%)
iast_HARDCODED_SECRET_DISABLED 511.254 µs [489.583 µs, 532.926 µs] 131.199 µs (34.5%)
iast_INACTIVE 464.368 µs [442.327 µs, 486.41 µs] 84.313 µs (22.2%)
iast_TELEMETRY_OFF 499.416 µs [477.454 µs, 521.379 µs] 119.361 µs (31.4%)
tracing 459.722 µs [438.526 µs, 480.918 µs] 79.667 µs (21.0%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~1ce7e72239, baseline=1.49.0-SNAPSHOT~069883952e
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.346 ms) : 1326, 1367
.   : milestone, 1346,
appsec (1.713 ms) : 1690, 1736
.   : milestone, 1713,
appsec_no_iast (1.712 ms) : 1689, 1736
.   : milestone, 1712,
code_origins (1.663 ms) : 1635, 1690
.   : milestone, 1663,
iast (1.505 ms) : 1479, 1530
.   : milestone, 1505,
profiling (1.557 ms) : 1532, 1583
.   : milestone, 1557,
tracing (1.471 ms) : 1445, 1496
.   : milestone, 1471,
section candidate
no_agent (1.357 ms) : 1337, 1377
.   : milestone, 1357,
appsec (1.723 ms) : 1699, 1746
.   : milestone, 1723,
appsec_no_iast (1.723 ms) : 1699, 1746
.   : milestone, 1723,
code_origins (1.669 ms) : 1642, 1696
.   : milestone, 1669,
iast (1.499 ms) : 1475, 1524
.   : milestone, 1499,
profiling (1.508 ms) : 1484, 1532
.   : milestone, 1508,
tracing (1.503 ms) : 1478, 1528
.   : milestone, 1503,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.346 ms [1.326 ms, 1.367 ms] -
appsec 1.713 ms [1.69 ms, 1.736 ms] 366.913 µs (27.3%)
appsec_no_iast 1.712 ms [1.689 ms, 1.736 ms] 366.058 µs (27.2%)
code_origins 1.663 ms [1.635 ms, 1.69 ms] 316.22 µs (23.5%)
iast 1.505 ms [1.479 ms, 1.53 ms] 158.117 µs (11.7%)
profiling 1.557 ms [1.532 ms, 1.583 ms] 211.049 µs (15.7%)
tracing 1.471 ms [1.445 ms, 1.496 ms] 124.253 µs (9.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.357 ms [1.337 ms, 1.377 ms] -
appsec 1.723 ms [1.699 ms, 1.746 ms] 365.478 µs (26.9%)
appsec_no_iast 1.723 ms [1.699 ms, 1.746 ms] 365.773 µs (27.0%)
code_origins 1.669 ms [1.642 ms, 1.696 ms] 312.367 µs (23.0%)
iast 1.499 ms [1.475 ms, 1.524 ms] 142.258 µs (10.5%)
profiling 1.508 ms [1.484 ms, 1.532 ms] 151.191 µs (11.1%)
tracing 1.503 ms [1.478 ms, 1.528 ms] 145.526 µs (10.7%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mobuchowski/setup-sh-check-for-java
git_commit_date 1745919592 1745906379
git_commit_sha 0698839 1ce7e72
release_version 1.49.0-SNAPSHOT~069883952e 1.49.0-SNAPSHOT~1ce7e72239
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1745923268 1745923268
ci_job_id 916247354 916247354
ci_pipeline_id 63581801 63581801
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-stvtq5db-project-304-concurrent-0-b1hthifs 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-stvtq5db-project-304-concurrent-0-b1hthifs 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~1ce7e72239, baseline=1.49.0-SNAPSHOT~069883952e
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.835 s) : 14835000, 14835000
.   : milestone, 14835000,
appsec (15.038 s) : 15038000, 15038000
.   : milestone, 15038000,
iast (18.617 s) : 18617000, 18617000
.   : milestone, 18617000,
iast_GLOBAL (18.125 s) : 18125000, 18125000
.   : milestone, 18125000,
profiling (15.124 s) : 15124000, 15124000
.   : milestone, 15124000,
tracing (15.001 s) : 15001000, 15001000
.   : milestone, 15001000,
section candidate
no_agent (15.66 s) : 15660000, 15660000
.   : milestone, 15660000,
appsec (15.024 s) : 15024000, 15024000
.   : milestone, 15024000,
iast (18.632 s) : 18632000, 18632000
.   : milestone, 18632000,
iast_GLOBAL (17.632 s) : 17632000, 17632000
.   : milestone, 17632000,
profiling (14.994 s) : 14994000, 14994000
.   : milestone, 14994000,
tracing (15.004 s) : 15004000, 15004000
.   : milestone, 15004000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.835 s [14.835 s, 14.835 s] -
appsec 15.038 s [15.038 s, 15.038 s] 203.0 ms (1.4%)
iast 18.617 s [18.617 s, 18.617 s] 3.782 s (25.5%)
iast_GLOBAL 18.125 s [18.125 s, 18.125 s] 3.29 s (22.2%)
profiling 15.124 s [15.124 s, 15.124 s] 289.0 ms (1.9%)
tracing 15.001 s [15.001 s, 15.001 s] 166.0 ms (1.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.66 s [15.66 s, 15.66 s] -
appsec 15.024 s [15.024 s, 15.024 s] -636.0 ms (-4.1%)
iast 18.632 s [18.632 s, 18.632 s] 2.972 s (19.0%)
iast_GLOBAL 17.632 s [17.632 s, 17.632 s] 1.972 s (12.6%)
profiling 14.994 s [14.994 s, 14.994 s] -666.0 ms (-4.3%)
tracing 15.004 s [15.004 s, 15.004 s] -656.0 ms (-4.2%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~1ce7e72239, baseline=1.49.0-SNAPSHOT~069883952e
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.471 ms) : 1459, 1482
.   : milestone, 1471,
appsec (2.372 ms) : 2325, 2419
.   : milestone, 2372,
iast (2.146 ms) : 2087, 2205
.   : milestone, 2146,
iast_GLOBAL (2.193 ms) : 2134, 2252
.   : milestone, 2193,
profiling (1.993 ms) : 1947, 2040
.   : milestone, 1993,
tracing (1.973 ms) : 1928, 2018
.   : milestone, 1973,
section candidate
no_agent (1.468 ms) : 1456, 1479
.   : milestone, 1468,
appsec (2.371 ms) : 2324, 2418
.   : milestone, 2371,
iast (2.158 ms) : 2099, 2217
.   : milestone, 2158,
iast_GLOBAL (2.203 ms) : 2143, 2263
.   : milestone, 2203,
profiling (1.995 ms) : 1948, 2042
.   : milestone, 1995,
tracing (1.975 ms) : 1929, 2020
.   : milestone, 1975,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.471 ms [1.459 ms, 1.482 ms] -
appsec 2.372 ms [2.325 ms, 2.419 ms] 901.327 µs (61.3%)
iast 2.146 ms [2.087 ms, 2.205 ms] 674.839 µs (45.9%)
iast_GLOBAL 2.193 ms [2.134 ms, 2.252 ms] 722.184 µs (49.1%)
profiling 1.993 ms [1.947 ms, 2.04 ms] 522.669 µs (35.5%)
tracing 1.973 ms [1.928 ms, 2.018 ms] 502.455 µs (34.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.468 ms [1.456 ms, 1.479 ms] -
appsec 2.371 ms [2.324 ms, 2.418 ms] 903.103 µs (61.5%)
iast 2.158 ms [2.099 ms, 2.217 ms] 690.224 µs (47.0%)
iast_GLOBAL 2.203 ms [2.143 ms, 2.263 ms] 735.438 µs (50.1%)
profiling 1.995 ms [1.948 ms, 2.042 ms] 526.979 µs (35.9%)
tracing 1.975 ms [1.929 ms, 2.02 ms] 507.194 µs (34.6%)

PerfectSlayer
PerfectSlayer reviewed Apr 17, 2025
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks the improvement! 👍

In case where java is in the path and not Java 8, is the error message still relevant? 🤔 (ie asking to set the JAVA_HOME env var?)

And what about the Windows version of this script, does it need to be updated too?

@mobuchowski
Copy link
Contributor Author

@PerfectSlayer yes, with java binary being Java 17 and no JAVA_HOME env var - but otherwise good looking setup.sh run, the shadow jar fails on

./gradlew clean spotlessApply shadowJar --rerun-tasks

(...)

> Task :dd-smoke-tests:iast-propagation:compileKotlin FAILED
FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':dd-smoke-tests:iast-propagation:compileKotlin'.
> Inconsistent JVM-target compatibility detected for tasks 'compileJava' (1.8) and 'compileKotlin' (17).

Unfortunately I have no way of testing the windows script - should I just update it in case?

@PerfectSlayer
Copy link
Contributor

I pushed an update for the script. I don’t maintain the Windows one either but maybe @lucaspimentel can?

@PerfectSlayer PerfectSlayer enabled auto-merge (squash) April 29, 2025 06:03
@PerfectSlayer PerfectSlayer added tag: no release notes Changes to exclude from release notes and removed tag: no release notes Changes to exclude from release notes labels Apr 29, 2025
@PerfectSlayer PerfectSlayer merged commit c87fa1b into master May 2, 2025
253 of 254 checks passed
@PerfectSlayer PerfectSlayer deleted the mobuchowski/setup-sh-check-for-java branch May 2, 2025 05:32
@github-actions github-actions bot added this to the 1.49.0 milestone May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@manuel-alvarez-alvarez manuel-alvarez-alvarez Awaiting requested review from manuel-alvarez-alvarez manuel-alvarez-alvarez is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes type: enhancement
Projects
None yet
Milestone
1.49.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mobuchowski @PerfectSlayer