-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant setJavaVersion calls in gradle #8278
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 4 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~4c976091f7, baseline=1.46.0-SNAPSHOT~56d4919491
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.041 s) : 0, 1040542
Total [baseline] (8.699 s) : 0, 8698753
Agent [candidate] (1.041 s) : 0, 1040554
Total [candidate] (8.632 s) : 0, 8631941
section iast
Agent [baseline] (1.166 s) : 0, 1166442
Total [baseline] (9.218 s) : 0, 9218259
Agent [candidate] (1.164 s) : 0, 1164363
Total [candidate] (9.217 s) : 0, 9216883
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.165 s) : 0, 1165190
Total [baseline] (9.236 s) : 0, 9236142
Agent [candidate] (1.171 s) : 0, 1170631
Total [candidate] (9.18 s) : 0, 9179976
section iast_TELEMETRY_OFF
Agent [baseline] (1.163 s) : 0, 1163373
Total [baseline] (9.206 s) : 0, 9205997
Agent [candidate] (1.162 s) : 0, 1162489
Total [candidate] (9.233 s) : 0, 9233074
gantt
title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~4c976091f7, baseline=1.46.0-SNAPSHOT~56d4919491
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (714.995 ms) : 0, 714995
BytebuddyAgent [candidate] (717.797 ms) : 0, 717797
GlobalTracer [baseline] (240.299 ms) : 0, 240299
GlobalTracer [candidate] (239.218 ms) : 0, 239218
AppSec [baseline] (55.752 ms) : 0, 55752
AppSec [candidate] (54.922 ms) : 0, 54922
Remote Config [baseline] (718.695 µs) : 0, 719
Remote Config [candidate] (706.818 µs) : 0, 707
Telemetry [baseline] (13.752 ms) : 0, 13752
Telemetry [candidate] (12.804 ms) : 0, 12804
section iast
BytebuddyAgent [baseline] (833.388 ms) : 0, 833388
BytebuddyAgent [candidate] (830.879 ms) : 0, 830879
GlobalTracer [baseline] (229.197 ms) : 0, 229197
GlobalTracer [candidate] (229.392 ms) : 0, 229392
AppSec [baseline] (58.229 ms) : 0, 58229
AppSec [candidate] (58.393 ms) : 0, 58393
IAST [baseline] (21.184 ms) : 0, 21184
IAST [candidate] (21.266 ms) : 0, 21266
Remote Config [baseline] (659.206 µs) : 0, 659
Remote Config [candidate] (653.283 µs) : 0, 653
Telemetry [baseline] (8.77 ms) : 0, 8770
Telemetry [candidate] (8.751 ms) : 0, 8751
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (831.799 ms) : 0, 831799
BytebuddyAgent [candidate] (837.497 ms) : 0, 837497
GlobalTracer [baseline] (229.412 ms) : 0, 229412
GlobalTracer [candidate] (229.555 ms) : 0, 229555
AppSec [baseline] (58.454 ms) : 0, 58454
AppSec [candidate] (57.896 ms) : 0, 57896
IAST [baseline] (21.078 ms) : 0, 21078
IAST [candidate] (21.251 ms) : 0, 21251
Remote Config [baseline] (654.812 µs) : 0, 655
Remote Config [candidate] (651.444 µs) : 0, 651
Telemetry [baseline] (8.786 ms) : 0, 8786
Telemetry [candidate] (8.64 ms) : 0, 8640
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (830.155 ms) : 0, 830155
BytebuddyAgent [candidate] (829.637 ms) : 0, 829637
GlobalTracer [baseline] (229.329 ms) : 0, 229329
GlobalTracer [candidate] (229.612 ms) : 0, 229612
AppSec [baseline] (58.609 ms) : 0, 58609
AppSec [candidate] (58.129 ms) : 0, 58129
IAST [baseline] (20.939 ms) : 0, 20939
IAST [candidate] (20.765 ms) : 0, 20765
Remote Config [baseline] (657.951 µs) : 0, 658
Remote Config [candidate] (656.212 µs) : 0, 656
Telemetry [baseline] (8.69 ms) : 0, 8690
Telemetry [candidate] (8.703 ms) : 0, 8703
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~4c976091f7, baseline=1.46.0-SNAPSHOT~56d4919491
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.043 s) : 0, 1043397
Total [baseline] (10.478 s) : 0, 10477749
Agent [candidate] (1.037 s) : 0, 1036795
Total [candidate] (10.499 s) : 0, 10498906
section appsec
Agent [baseline] (1.178 s) : 0, 1178154
Total [baseline] (10.729 s) : 0, 10729419
Agent [candidate] (1.18 s) : 0, 1180215
Total [candidate] (10.776 s) : 0, 10776173
section iast
Agent [baseline] (1.164 s) : 0, 1164183
Total [baseline] (10.944 s) : 0, 10943889
Agent [candidate] (1.168 s) : 0, 1167570
Total [candidate] (10.981 s) : 0, 10981303
section profiling
Agent [baseline] (1.256 s) : 0, 1255843
Total [baseline] (10.882 s) : 0, 10882005
Agent [candidate] (1.254 s) : 0, 1253882
Total [candidate] (10.919 s) : 0, 10919147
gantt
title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~4c976091f7, baseline=1.46.0-SNAPSHOT~56d4919491
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (719.517 ms) : 0, 719517
BytebuddyAgent [candidate] (714.449 ms) : 0, 714449
GlobalTracer [baseline] (240.673 ms) : 0, 240673
GlobalTracer [candidate] (239.044 ms) : 0, 239044
AppSec [baseline] (55.864 ms) : 0, 55864
AppSec [candidate] (55.326 ms) : 0, 55326
Remote Config [baseline] (714.379 µs) : 0, 714
Remote Config [candidate] (710.847 µs) : 0, 711
Telemetry [baseline] (11.507 ms) : 0, 11507
Telemetry [candidate] (12.203 ms) : 0, 12203
section appsec
BytebuddyAgent [baseline] (731.532 ms) : 0, 731532
BytebuddyAgent [candidate] (733.422 ms) : 0, 733422
GlobalTracer [baseline] (236.513 ms) : 0, 236513
GlobalTracer [candidate] (236.485 ms) : 0, 236485
AppSec [baseline] (176.007 ms) : 0, 176007
AppSec [candidate] (176.759 ms) : 0, 176759
IAST [baseline] (19.07 ms) : 0, 19070
IAST [candidate] (19.223 ms) : 0, 19223
Remote Config [baseline] (671.505 µs) : 0, 672
Remote Config [candidate] (670.453 µs) : 0, 670
Telemetry [baseline] (8.951 ms) : 0, 8951
Telemetry [candidate] (8.211 ms) : 0, 8211
section iast
BytebuddyAgent [baseline] (831.113 ms) : 0, 831113
BytebuddyAgent [candidate] (832.603 ms) : 0, 832603
GlobalTracer [baseline] (228.931 ms) : 0, 228931
GlobalTracer [candidate] (229.999 ms) : 0, 229999
AppSec [baseline] (58.261 ms) : 0, 58261
AppSec [candidate] (58.13 ms) : 0, 58130
IAST [baseline] (21.341 ms) : 0, 21341
IAST [candidate] (22.254 ms) : 0, 22254
Remote Config [baseline] (669.656 µs) : 0, 670
Remote Config [candidate] (653.795 µs) : 0, 654
Telemetry [baseline] (8.835 ms) : 0, 8835
Telemetry [candidate] (8.88 ms) : 0, 8880
section profiling
BytebuddyAgent [baseline] (704.559 ms) : 0, 704559
BytebuddyAgent [candidate] (703.85 ms) : 0, 703850
GlobalTracer [baseline] (348.538 ms) : 0, 348538
GlobalTracer [candidate] (349.275 ms) : 0, 349275
AppSec [baseline] (55.132 ms) : 0, 55132
AppSec [candidate] (53.745 ms) : 0, 53745
Remote Config [baseline] (726.777 µs) : 0, 727
Remote Config [candidate] (707.956 µs) : 0, 708
Telemetry [baseline] (8.817 ms) : 0, 8817
Telemetry [candidate] (8.828 ms) : 0, 8828
ProfilingAgent [baseline] (95.76 ms) : 0, 95760
ProfilingAgent [candidate] (95.526 ms) : 0, 95526
Profiling [baseline] (95.783 ms) : 0, 95783
Profiling [candidate] (95.55 ms) : 0, 95550
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~4c976091f7, baseline=1.46.0-SNAPSHOT~56d4919491
dateFormat X
axisFormat %s
section baseline
no_agent (1.353 ms) : 1333, 1373
. : milestone, 1353,
appsec (1.744 ms) : 1720, 1767
. : milestone, 1744,
appsec_no_iast (1.769 ms) : 1745, 1793
. : milestone, 1769,
iast (1.523 ms) : 1498, 1547
. : milestone, 1523,
profiling (1.528 ms) : 1503, 1553
. : milestone, 1528,
tracing (1.478 ms) : 1452, 1504
. : milestone, 1478,
section candidate
no_agent (1.363 ms) : 1343, 1382
. : milestone, 1363,
appsec (1.743 ms) : 1718, 1768
. : milestone, 1743,
appsec_no_iast (1.755 ms) : 1732, 1777
. : milestone, 1755,
iast (1.516 ms) : 1492, 1541
. : milestone, 1516,
profiling (1.506 ms) : 1483, 1529
. : milestone, 1506,
tracing (1.473 ms) : 1448, 1499
. : milestone, 1473,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~4c976091f7, baseline=1.46.0-SNAPSHOT~56d4919491
dateFormat X
axisFormat %s
section baseline
no_agent (385.716 µs) : 365, 406
. : milestone, 386,
iast (510.179 µs) : 487, 533
. : milestone, 510,
iast_FULL (748.105 µs) : 725, 771
. : milestone, 748,
iast_GLOBAL (553.304 µs) : 530, 577
. : milestone, 553,
iast_HARDCODED_SECRET_DISABLED (508.673 µs) : 486, 532
. : milestone, 509,
iast_INACTIVE (461.832 µs) : 440, 483
. : milestone, 462,
iast_TELEMETRY_OFF (497.148 µs) : 474, 520
. : milestone, 497,
tracing (458.164 µs) : 437, 480
. : milestone, 458,
section candidate
no_agent (380.845 µs) : 360, 402
. : milestone, 381,
iast (513.864 µs) : 492, 536
. : milestone, 514,
iast_FULL (742.02 µs) : 720, 764
. : milestone, 742,
iast_GLOBAL (561.072 µs) : 538, 584
. : milestone, 561,
iast_HARDCODED_SECRET_DISABLED (512.729 µs) : 490, 536
. : milestone, 513,
iast_INACTIVE (455.777 µs) : 435, 477
. : milestone, 456,
iast_TELEMETRY_OFF (498.257 µs) : 475, 521
. : milestone, 498,
tracing (459.486 µs) : 438, 481
. : milestone, 459,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~4c976091f7, baseline=1.46.0-SNAPSHOT~56d4919491
dateFormat X
axisFormat %s
section baseline
no_agent (1.465 ms) : 1453, 1476
. : milestone, 1465,
appsec (2.331 ms) : 2289, 2374
. : milestone, 2331,
iast (2.087 ms) : 2032, 2141
. : milestone, 2087,
iast_GLOBAL (2.135 ms) : 2081, 2190
. : milestone, 2135,
profiling (1.984 ms) : 1940, 2028
. : milestone, 1984,
tracing (1.924 ms) : 1883, 1966
. : milestone, 1924,
section candidate
no_agent (1.461 ms) : 1449, 1472
. : milestone, 1461,
appsec (2.338 ms) : 2295, 2381
. : milestone, 2338,
iast (2.095 ms) : 2041, 2150
. : milestone, 2095,
iast_GLOBAL (2.138 ms) : 2083, 2192
. : milestone, 2138,
profiling (1.948 ms) : 1905, 1991
. : milestone, 1948,
tracing (1.935 ms) : 1894, 1977
. : milestone, 1935,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~4c976091f7, baseline=1.46.0-SNAPSHOT~56d4919491
dateFormat X
axisFormat %s
section baseline
no_agent (14.934 s) : 14934000, 14934000
. : milestone, 14934000,
appsec (14.912 s) : 14912000, 14912000
. : milestone, 14912000,
iast (18.302 s) : 18302000, 18302000
. : milestone, 18302000,
iast_GLOBAL (17.745 s) : 17745000, 17745000
. : milestone, 17745000,
profiling (15.127 s) : 15127000, 15127000
. : milestone, 15127000,
tracing (15.034 s) : 15034000, 15034000
. : milestone, 15034000,
section candidate
no_agent (15.351 s) : 15351000, 15351000
. : milestone, 15351000,
appsec (15.145 s) : 15145000, 15145000
. : milestone, 15145000,
iast (18.898 s) : 18898000, 18898000
. : milestone, 18898000,
iast_GLOBAL (18.128 s) : 18128000, 18128000
. : milestone, 18128000,
profiling (15.198 s) : 15198000, 15198000
. : milestone, 15198000,
tracing (15.008 s) : 15008000, 15008000
. : milestone, 15008000,
|
amarziali
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Remove redundant calls to
setJavaVersion(it, 8)
inbuild.gradle
files. This is already the default.Motivation
Prep work for decoupling of gradle JDK and build/test JDK.
Additional Notes
Split out from #7506
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: APMJAVA-1342