WIP - Prototyping context propagation API #8271
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
Comment on lines
591
to
593
| ExtractedSpan(AgentSpanContext spanContext) { | ||
| this.spanContext = spanContext; | ||
| } |
There was a problem hiding this comment.
⚪ Code Quality Violation
Consider adding super() or this() to your constructor (...read more)
In Java, it is suggested to call super() in an extended class. This rule will report a violation if both a call to super() and an overloaded constructor are absent.
PerfectSlayer
force-pushed
the
bbujon/context-propagation
branch
from
017e5a4 to
ddb0406
Compare
Kafka / producer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 1 performance improvements and 8 performance regressions! Performance is the same for 51 metrics, 3 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~fbf319b527, baseline=1.46.0-SNAPSHOT~56d4919491
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.035 s) : 0, 1034548
Total [baseline] (8.634 s) : 0, 8633691
Agent [candidate] (1.068 s) : 0, 1068333
Total [candidate] (8.657 s) : 0, 8656693
section iast
Agent [baseline] (1.175 s) : 0, 1174620
Total [baseline] (9.215 s) : 0, 9215256
Agent [candidate] (1.186 s) : 0, 1186270
Total [candidate] (9.25 s) : 0, 9250192
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.172 s) : 0, 1171641
Total [baseline] (9.212 s) : 0, 9212361
Agent [candidate] (1.188 s) : 0, 1187968
Total [candidate] (9.205 s) : 0, 9205377
section iast_TELEMETRY_OFF
Agent [baseline] (1.169 s) : 0, 1169465
Total [baseline] (9.262 s) : 0, 9261946
Agent [candidate] (1.191 s) : 0, 1191392
Total [candidate] (9.212 s) : 0, 9212329
gantt
title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~fbf319b527, baseline=1.46.0-SNAPSHOT~56d4919491
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (713.87 ms) : 0, 713870
BytebuddyAgent [candidate] (720.681 ms) : 0, 720681
GlobalTracer [baseline] (238.749 ms) : 0, 238749
GlobalTracer [candidate] (259.949 ms) : 0, 259949
AppSec [baseline] (55.421 ms) : 0, 55421
AppSec [candidate] (55.893 ms) : 0, 55893
Remote Config [baseline] (717.053 µs) : 0, 717
Remote Config [candidate] (742.019 µs) : 0, 742
Telemetry [baseline] (10.749 ms) : 0, 10749
Telemetry [candidate] (15.892 ms) : 0, 15892
section iast
BytebuddyAgent [baseline] (839.318 ms) : 0, 839318
BytebuddyAgent [candidate] (832.558 ms) : 0, 832558
GlobalTracer [baseline] (231.122 ms) : 0, 231122
GlobalTracer [candidate] (249.222 ms) : 0, 249222
AppSec [baseline] (58.209 ms) : 0, 58209
AppSec [candidate] (58.24 ms) : 0, 58240
IAST [baseline] (21.42 ms) : 0, 21420
IAST [candidate] (21.647 ms) : 0, 21647
Remote Config [baseline] (650.748 µs) : 0, 651
Remote Config [candidate] (675.355 µs) : 0, 675
Telemetry [baseline] (8.76 ms) : 0, 8760
Telemetry [candidate] (8.903 ms) : 0, 8903
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (837.181 ms) : 0, 837181
BytebuddyAgent [candidate] (834.178 ms) : 0, 834178
GlobalTracer [baseline] (230.956 ms) : 0, 230956
GlobalTracer [candidate] (249.527 ms) : 0, 249527
AppSec [baseline] (58.143 ms) : 0, 58143
AppSec [candidate] (58.273 ms) : 0, 58273
IAST [baseline] (21.112 ms) : 0, 21112
IAST [candidate] (21.527 ms) : 0, 21527
Remote Config [baseline] (635.096 µs) : 0, 635
Remote Config [candidate] (666.518 µs) : 0, 667
Telemetry [baseline] (8.596 ms) : 0, 8596
Telemetry [candidate] (8.823 ms) : 0, 8823
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (835.855 ms) : 0, 835855
BytebuddyAgent [candidate] (837.162 ms) : 0, 837162
GlobalTracer [baseline] (230.126 ms) : 0, 230126
GlobalTracer [candidate] (250.784 ms) : 0, 250784
AppSec [baseline] (58.038 ms) : 0, 58038
AppSec [candidate] (58.089 ms) : 0, 58089
IAST [baseline] (21.062 ms) : 0, 21062
IAST [candidate] (20.919 ms) : 0, 20919
Remote Config [baseline] (651.159 µs) : 0, 651
Remote Config [candidate] (671.414 µs) : 0, 671
Telemetry [baseline] (8.584 ms) : 0, 8584
Telemetry [candidate] (8.686 ms) : 0, 8686
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~fbf319b527, baseline=1.46.0-SNAPSHOT~56d4919491
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.039 s) : 0, 1038670
Total [baseline] (10.437 s) : 0, 10437029
Agent [candidate] (1.06 s) : 0, 1059976
Total [candidate] (10.507 s) : 0, 10506597
section appsec
Agent [baseline] (1.178 s) : 0, 1177600
Total [baseline] (10.751 s) : 0, 10751206
Agent [candidate] (1.192 s) : 0, 1192144
Total [candidate] (10.761 s) : 0, 10760549
section iast
Agent [baseline] (1.17 s) : 0, 1169532
Total [baseline] (10.988 s) : 0, 10987788
Agent [candidate] (1.188 s) : 0, 1188123
Total [candidate] (11.018 s) : 0, 11018018
section profiling
Agent [baseline] (1.255 s) : 0, 1254636
Total [baseline] (10.848 s) : 0, 10848382
Agent [candidate] (1.256 s) : 0, 1255651
Total [candidate] (10.871 s) : 0, 10870819
gantt
title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~fbf319b527, baseline=1.46.0-SNAPSHOT~56d4919491
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (713.406 ms) : 0, 713406
BytebuddyAgent [candidate] (716.319 ms) : 0, 716319
GlobalTracer [baseline] (238.437 ms) : 0, 238437
GlobalTracer [candidate] (258.21 ms) : 0, 258210
AppSec [baseline] (55.497 ms) : 0, 55497
AppSec [candidate] (55.29 ms) : 0, 55290
Remote Config [baseline] (704.607 µs) : 0, 705
Remote Config [candidate] (750.524 µs) : 0, 751
Telemetry [baseline] (15.721 ms) : 0, 15721
Telemetry [candidate] (14.4 ms) : 0, 14400
section appsec
BytebuddyAgent [baseline] (730.947 ms) : 0, 730947
BytebuddyAgent [candidate] (731.523 ms) : 0, 731523
GlobalTracer [baseline] (236.592 ms) : 0, 236592
GlobalTracer [candidate] (255.88 ms) : 0, 255880
AppSec [baseline] (176.69 ms) : 0, 176690
AppSec [candidate] (171.237 ms) : 0, 171237
IAST [baseline] (19.22 ms) : 0, 19220
IAST [candidate] (19.311 ms) : 0, 19311
Remote Config [baseline] (653.974 µs) : 0, 654
Remote Config [candidate] (664.78 µs) : 0, 665
Telemetry [baseline] (8.175 ms) : 0, 8175
Telemetry [candidate] (8.186 ms) : 0, 8186
section iast
BytebuddyAgent [baseline] (835.152 ms) : 0, 835152
BytebuddyAgent [candidate] (833.886 ms) : 0, 833886
GlobalTracer [baseline] (230.204 ms) : 0, 230204
GlobalTracer [candidate] (249.916 ms) : 0, 249916
AppSec [baseline] (58.186 ms) : 0, 58186
AppSec [candidate] (58.317 ms) : 0, 58317
IAST [baseline] (21.539 ms) : 0, 21539
IAST [candidate] (21.59 ms) : 0, 21590
Remote Config [baseline] (646.289 µs) : 0, 646
Remote Config [candidate] (661.807 µs) : 0, 662
Telemetry [baseline] (8.763 ms) : 0, 8763
Telemetry [candidate] (8.711 ms) : 0, 8711
section profiling
BytebuddyAgent [baseline] (703.842 ms) : 0, 703842
BytebuddyAgent [candidate] (704.009 ms) : 0, 704009
GlobalTracer [baseline] (348.59 ms) : 0, 348590
GlobalTracer [candidate] (351.04 ms) : 0, 351040
AppSec [baseline] (55.246 ms) : 0, 55246
AppSec [candidate] (54.135 ms) : 0, 54135
Remote Config [baseline] (714.829 µs) : 0, 715
Remote Config [candidate] (713.192 µs) : 0, 713
Telemetry [baseline] (8.806 ms) : 0, 8806
Telemetry [candidate] (8.828 ms) : 0, 8828
ProfilingAgent [baseline] (95.52 ms) : 0, 95520
ProfilingAgent [candidate] (94.989 ms) : 0, 94989
Profiling [baseline] (95.544 ms) : 0, 95544
Profiling [candidate] (95.013 ms) : 0, 95013
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~fbf319b527, baseline=1.46.0-SNAPSHOT~56d4919491
dateFormat X
axisFormat %s
section baseline
no_agent (1.366 ms) : 1346, 1385
. : milestone, 1366,
appsec (1.76 ms) : 1737, 1782
. : milestone, 1760,
appsec_no_iast (1.76 ms) : 1736, 1784
. : milestone, 1760,
iast (1.511 ms) : 1487, 1536
. : milestone, 1511,
profiling (1.51 ms) : 1487, 1533
. : milestone, 1510,
tracing (1.505 ms) : 1480, 1529
. : milestone, 1505,
section candidate
no_agent (1.348 ms) : 1329, 1368
. : milestone, 1348,
appsec (1.755 ms) : 1731, 1779
. : milestone, 1755,
appsec_no_iast (1.771 ms) : 1748, 1793
. : milestone, 1771,
iast (1.509 ms) : 1485, 1534
. : milestone, 1509,
profiling (1.566 ms) : 1542, 1590
. : milestone, 1566,
tracing (1.484 ms) : 1458, 1509
. : milestone, 1484,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~fbf319b527, baseline=1.46.0-SNAPSHOT~56d4919491
dateFormat X
axisFormat %s
section baseline
no_agent (383.835 µs) : 363, 404
. : milestone, 384,
iast (513.756 µs) : 492, 535
. : milestone, 514,
iast_FULL (749.187 µs) : 726, 772
. : milestone, 749,
iast_GLOBAL (565.378 µs) : 541, 590
. : milestone, 565,
iast_HARDCODED_SECRET_DISABLED (521.596 µs) : 498, 545
. : milestone, 522,
iast_INACTIVE (472.139 µs) : 450, 494
. : milestone, 472,
iast_TELEMETRY_OFF (502.09 µs) : 479, 525
. : milestone, 502,
tracing (461.184 µs) : 440, 482
. : milestone, 461,
section candidate
no_agent (384.404 µs) : 365, 404
. : milestone, 384,
iast (512.217 µs) : 491, 534
. : milestone, 512,
iast_FULL (743.461 µs) : 721, 765
. : milestone, 743,
iast_GLOBAL (562.668 µs) : 540, 585
. : milestone, 563,
iast_HARDCODED_SECRET_DISABLED (509.71 µs) : 488, 531
. : milestone, 510,
iast_INACTIVE (464.523 µs) : 443, 486
. : milestone, 465,
iast_TELEMETRY_OFF (512.698 µs) : 490, 535
. : milestone, 513,
tracing (459.91 µs) : 439, 481
. : milestone, 460,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~fbf319b527, baseline=1.46.0-SNAPSHOT~56d4919491
dateFormat X
axisFormat %s
section baseline
no_agent (14.975 s) : 14975000, 14975000
. : milestone, 14975000,
appsec (14.934 s) : 14934000, 14934000
. : milestone, 14934000,
iast (18.419 s) : 18419000, 18419000
. : milestone, 18419000,
iast_GLOBAL (18.052 s) : 18052000, 18052000
. : milestone, 18052000,
profiling (15.18 s) : 15180000, 15180000
. : milestone, 15180000,
tracing (15.271 s) : 15271000, 15271000
. : milestone, 15271000,
section candidate
no_agent (15.564 s) : 15564000, 15564000
. : milestone, 15564000,
appsec (15.101 s) : 15101000, 15101000
. : milestone, 15101000,
iast (18.398 s) : 18398000, 18398000
. : milestone, 18398000,
iast_GLOBAL (17.929 s) : 17929000, 17929000
. : milestone, 17929000,
profiling (15.269 s) : 15269000, 15269000
. : milestone, 15269000,
tracing (14.958 s) : 14958000, 14958000
. : milestone, 14958000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~fbf319b527, baseline=1.46.0-SNAPSHOT~56d4919491
dateFormat X
axisFormat %s
section baseline
no_agent (1.467 ms) : 1455, 1478
. : milestone, 1467,
appsec (2.362 ms) : 2319, 2405
. : milestone, 2362,
iast (2.097 ms) : 2043, 2151
. : milestone, 2097,
iast_GLOBAL (2.141 ms) : 2087, 2196
. : milestone, 2141,
profiling (1.968 ms) : 1925, 2011
. : milestone, 1968,
tracing (1.944 ms) : 1902, 1986
. : milestone, 1944,
section candidate
no_agent (1.471 ms) : 1459, 1482
. : milestone, 1471,
appsec (2.364 ms) : 2321, 2407
. : milestone, 2364,
iast (2.097 ms) : 2042, 2151
. : milestone, 2097,
iast_GLOBAL (2.15 ms) : 2096, 2205
. : milestone, 2150,
profiling (1.963 ms) : 1919, 2008
. : milestone, 1963,
tracing (1.94 ms) : 1898, 1981
. : milestone, 1940,
|
Kafka / consumer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
PerfectSlayer
force-pushed
the
bbujon/context-propagation
branch
from
ddb0406 to
12d2605
Compare
PerfectSlayer
force-pushed
the
bbujon/context-propagation
branch
from
12d2605 to
5a40279
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]