Configuration to Disable APM Tracing #8219

jandro996 · 2025-01-16T09:00:47Z

What Does This Do

Change Env var DD_EXPERIMENTAL_APPSEC_ENABLED = true for DD_APM_TRACING_ENABLED = false
AsmStandaloneSampler should be use when APM tracing is disabled, so it's renamed to ApmTracingDisabledSampler
Change _dd.p.appsec = 1 when there is an ASM event for a a two-character-long hex string _dd.p.ts
Product Trace Source values:
- 01 = APM
- 02 = ASM
- 04 = DSM
- 08 = DJM
- 10 = DBM

Motivation

Migration from the experimental asm standalone billing to APM Disabling tracing

Additional Notes

RFC

Migration Guide

Testested in system-tests

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: APPSEC-56438

pr-commenter · 2025-01-16T09:39:50Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	alejandro.gonzalez/Configuration-to-Disable-APM-Tracing
git_commit_date	1739453354	1739516597
git_commit_sha	`dcf73eb`	`cb9a2d4`
release_version	1.47.0-SNAPSHOT~dcf73eb0cb	1.47.0-SNAPSHOT~cb9a2d4b0d

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1739519086	1739519086
ci_job_id	808303967	808303967
ci_pipeline_id	55896926	55896926
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-nsas5zms-project-304-concurrent-2-kqs6htm7 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-nsas5zms-project-304-concurrent-2-kqs6htm7 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 5 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~cb9a2d4b0d, baseline=1.47.0-SNAPSHOT~dcf73eb0cb

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.038 s) : 0, 1038391
Total [baseline] (10.472 s) : 0, 10472130
Agent [candidate] (1.051 s) : 0, 1051214
Total [candidate] (10.533 s) : 0, 10532887
section appsec
Agent [baseline] (1.182 s) : 0, 1181970
Total [baseline] (10.836 s) : 0, 10836415
Agent [candidate] (1.18 s) : 0, 1180326
Total [candidate] (10.755 s) : 0, 10755005
section iast
Agent [baseline] (1.181 s) : 0, 1180592
Total [baseline] (11.058 s) : 0, 11058003
Agent [candidate] (1.173 s) : 0, 1172866
Total [candidate] (11.141 s) : 0, 11140755
section profiling
Agent [baseline] (1.263 s) : 0, 1262620
Total [baseline] (10.901 s) : 0, 10901379
Agent [candidate] (1.262 s) : 0, 1262429
Total [candidate] (10.901 s) : 0, 10901045

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.038 s	-
Agent	appsec	1.182 s	143.579 ms (13.8%)
Agent	iast	1.181 s	142.201 ms (13.7%)
Agent	profiling	1.263 s	224.23 ms (21.6%)
Total	tracing	10.472 s	-
Total	appsec	10.836 s	364.285 ms (3.5%)
Total	iast	11.058 s	585.874 ms (5.6%)
Total	profiling	10.901 s	429.249 ms (4.1%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.051 s	-
Agent	appsec	1.18 s	129.112 ms (12.3%)
Agent	iast	1.173 s	121.652 ms (11.6%)
Agent	profiling	1.262 s	211.215 ms (20.1%)
Total	tracing	10.533 s	-
Total	appsec	10.755 s	222.118 ms (2.1%)
Total	iast	11.141 s	607.868 ms (5.8%)
Total	profiling	10.901 s	368.158 ms (3.5%)

gantt
    title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~cb9a2d4b0d, baseline=1.47.0-SNAPSHOT~dcf73eb0cb

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (715.684 ms) : 0, 715684
BytebuddyAgent [candidate] (724.348 ms) : 0, 724348
GlobalTracer [baseline] (240.763 ms) : 0, 240763
GlobalTracer [candidate] (243.02 ms) : 0, 243020
AppSec [baseline] (55.145 ms) : 0, 55145
AppSec [candidate] (56.132 ms) : 0, 56132
Remote Config [baseline] (714.67 µs) : 0, 715
Remote Config [candidate] (707.755 µs) : 0, 708
Telemetry [baseline] (10.81 ms) : 0, 10810
Telemetry [candidate] (11.595 ms) : 0, 11595
section appsec
BytebuddyAgent [baseline] (732.805 ms) : 0, 732805
BytebuddyAgent [candidate] (732.964 ms) : 0, 732964
GlobalTracer [baseline] (237.58 ms) : 0, 237580
GlobalTracer [candidate] (236.256 ms) : 0, 236256
IAST [baseline] (21.52 ms) : 0, 21520
IAST [candidate] (21.4 ms) : 0, 21400
AppSec [baseline] (176.647 ms) : 0, 176647
AppSec [candidate] (176.305 ms) : 0, 176305
Remote Config [baseline] (658.824 µs) : 0, 659
Remote Config [candidate] (669.686 µs) : 0, 670
Telemetry [baseline] (8.289 ms) : 0, 8289
Telemetry [candidate] (8.242 ms) : 0, 8242
section iast
BytebuddyAgent [baseline] (842.49 ms) : 0, 842490
BytebuddyAgent [candidate] (836.714 ms) : 0, 836714
GlobalTracer [baseline] (232.968 ms) : 0, 232968
GlobalTracer [candidate] (231.157 ms) : 0, 231157
IAST [baseline] (23.018 ms) : 0, 23018
IAST [candidate] (23.046 ms) : 0, 23046
AppSec [baseline] (57.238 ms) : 0, 57238
AppSec [candidate] (57.314 ms) : 0, 57314
Remote Config [baseline] (629.249 µs) : 0, 629
Remote Config [candidate] (622.28 µs) : 0, 622
Telemetry [baseline] (8.759 ms) : 0, 8759
Telemetry [candidate] (8.687 ms) : 0, 8687
section profiling
BytebuddyAgent [baseline] (707.728 ms) : 0, 707728
BytebuddyAgent [candidate] (708.551 ms) : 0, 708551
GlobalTracer [baseline] (351.111 ms) : 0, 351111
GlobalTracer [candidate] (350.618 ms) : 0, 350618
AppSec [baseline] (55.482 ms) : 0, 55482
AppSec [candidate] (54.874 ms) : 0, 54874
Remote Config [baseline] (702.742 µs) : 0, 703
Remote Config [candidate] (676.139 µs) : 0, 676
Telemetry [baseline] (8.885 ms) : 0, 8885
Telemetry [candidate] (9.053 ms) : 0, 9053
ProfilingAgent [baseline] (96.367 ms) : 0, 96367
ProfilingAgent [candidate] (96.287 ms) : 0, 96287
Profiling [baseline] (96.391 ms) : 0, 96391
Profiling [candidate] (96.312 ms) : 0, 96312

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~cb9a2d4b0d, baseline=1.47.0-SNAPSHOT~dcf73eb0cb

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.043 s) : 0, 1043329
Total [baseline] (8.669 s) : 0, 8669234
Agent [candidate] (1.042 s) : 0, 1042446
Total [candidate] (8.662 s) : 0, 8661716
section iast
Agent [baseline] (1.172 s) : 0, 1172037
Total [baseline] (9.323 s) : 0, 9323314
Agent [candidate] (1.186 s) : 0, 1185937
Total [candidate] (9.288 s) : 0, 9288041
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.174 s) : 0, 1173979
Total [baseline] (9.263 s) : 0, 9263306
Agent [candidate] (1.174 s) : 0, 1174329
Total [candidate] (9.26 s) : 0, 9259938
section iast_TELEMETRY_OFF
Agent [baseline] (1.17 s) : 0, 1169995
Total [baseline] (9.266 s) : 0, 9266198
Agent [candidate] (1.174 s) : 0, 1174294
Total [candidate] (9.297 s) : 0, 9297151

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.043 s	-
Agent	iast	1.172 s	128.707 ms (12.3%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.174 s	130.65 ms (12.5%)
Agent	iast_TELEMETRY_OFF	1.17 s	126.665 ms (12.1%)
Total	tracing	8.669 s	-
Total	iast	9.323 s	654.08 ms (7.5%)
Total	iast_HARDCODED_SECRET_DISABLED	9.263 s	594.072 ms (6.9%)
Total	iast_TELEMETRY_OFF	9.266 s	596.964 ms (6.9%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.042 s	-
Agent	iast	1.186 s	143.491 ms (13.8%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.174 s	131.883 ms (12.7%)
Agent	iast_TELEMETRY_OFF	1.174 s	131.848 ms (12.6%)
Total	tracing	8.662 s	-
Total	iast	9.288 s	626.325 ms (7.2%)
Total	iast_HARDCODED_SECRET_DISABLED	9.26 s	598.222 ms (6.9%)
Total	iast_TELEMETRY_OFF	9.297 s	635.435 ms (7.3%)

gantt
    title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~cb9a2d4b0d, baseline=1.47.0-SNAPSHOT~dcf73eb0cb

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.732 ms) : 0, 717732
BytebuddyAgent [candidate] (717.34 ms) : 0, 717340
GlobalTracer [baseline] (241.137 ms) : 0, 241137
GlobalTracer [candidate] (240.525 ms) : 0, 240525
AppSec [baseline] (55.519 ms) : 0, 55519
AppSec [candidate] (55.653 ms) : 0, 55653
Remote Config [baseline] (725.0 µs) : 0, 725
Remote Config [candidate] (708.275 µs) : 0, 708
Telemetry [baseline] (12.974 ms) : 0, 12974
Telemetry [candidate] (13.046 ms) : 0, 13046
section iast
BytebuddyAgent [baseline] (835.941 ms) : 0, 835941
BytebuddyAgent [candidate] (848.529 ms) : 0, 848529
GlobalTracer [baseline] (231.747 ms) : 0, 231747
GlobalTracer [candidate] (231.734 ms) : 0, 231734
IAST [baseline] (22.76 ms) : 0, 22760
IAST [candidate] (22.913 ms) : 0, 22913
AppSec [baseline] (56.968 ms) : 0, 56968
AppSec [candidate] (57.789 ms) : 0, 57789
Remote Config [baseline] (613.169 µs) : 0, 613
Remote Config [candidate] (637.738 µs) : 0, 638
Telemetry [baseline] (8.738 ms) : 0, 8738
Telemetry [candidate] (8.845 ms) : 0, 8845
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (837.16 ms) : 0, 837160
BytebuddyAgent [candidate] (837.618 ms) : 0, 837618
GlobalTracer [baseline] (232.164 ms) : 0, 232164
GlobalTracer [candidate] (231.681 ms) : 0, 231681
IAST [baseline] (22.747 ms) : 0, 22747
IAST [candidate] (22.957 ms) : 0, 22957
AppSec [baseline] (57.178 ms) : 0, 57178
AppSec [candidate] (57.359 ms) : 0, 57359
Remote Config [baseline] (624.072 µs) : 0, 624
Remote Config [candidate] (630.292 µs) : 0, 630
Telemetry [baseline] (8.745 ms) : 0, 8745
Telemetry [candidate] (8.733 ms) : 0, 8733
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (834.1 ms) : 0, 834100
BytebuddyAgent [candidate] (837.367 ms) : 0, 837367
GlobalTracer [baseline] (231.478 ms) : 0, 231478
GlobalTracer [candidate] (232.351 ms) : 0, 232351
IAST [baseline] (26.477 ms) : 0, 26477
IAST [candidate] (24.681 ms) : 0, 24681
AppSec [baseline] (53.319 ms) : 0, 53319
AppSec [candidate] (55.148 ms) : 0, 55148
Remote Config [baseline] (625.314 µs) : 0, 625
Remote Config [candidate] (649.264 µs) : 0, 649
Telemetry [baseline] (8.652 ms) : 0, 8652
Telemetry [candidate] (8.739 ms) : 0, 8739

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-02-14T07:15:27	2025-02-14T07:22:35
git_branch	master	alejandro.gonzalez/Configuration-to-Disable-APM-Tracing
git_commit_date	1739453354	1739516597
git_commit_sha	`dcf73eb`	`cb9a2d4`
release_version	1.47.0-SNAPSHOT~dcf73eb0cb	1.47.0-SNAPSHOT~cb9a2d4b0d
start_time	2025-02-14T07:15:13	2025-02-14T07:22:21

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1739518115	1739518115
ci_job_id	808303968	808303968
ci_pipeline_id	55896926	55896926
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-k8j6cnox-project-304-concurrent-1-puif5m8j 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-k8j6cnox-project-304-concurrent-1-puif5m8j 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~cb9a2d4b0d, baseline=1.47.0-SNAPSHOT~dcf73eb0cb
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.367 ms) : 1347, 1387
.   : milestone, 1367,
appsec (1.762 ms) : 1738, 1785
.   : milestone, 1762,
appsec_no_iast (1.763 ms) : 1735, 1790
.   : milestone, 1763,
iast (1.508 ms) : 1483, 1533
.   : milestone, 1508,
profiling (1.568 ms) : 1543, 1593
.   : milestone, 1568,
tracing (1.506 ms) : 1482, 1530
.   : milestone, 1506,
section candidate
no_agent (1.365 ms) : 1346, 1385
.   : milestone, 1365,
appsec (1.745 ms) : 1722, 1769
.   : milestone, 1745,
appsec_no_iast (1.766 ms) : 1743, 1789
.   : milestone, 1766,
iast (1.499 ms) : 1474, 1523
.   : milestone, 1499,
profiling (1.519 ms) : 1495, 1542
.   : milestone, 1519,
tracing (1.502 ms) : 1477, 1527
.   : milestone, 1502,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.367 ms [1.347 ms, 1.387 ms]	-
appsec	1.762 ms [1.738 ms, 1.785 ms]	394.371 µs (28.8%)
appsec_no_iast	1.763 ms [1.735 ms, 1.79 ms]	395.253 µs (28.9%)
iast	1.508 ms [1.483 ms, 1.533 ms]	140.461 µs (10.3%)
profiling	1.568 ms [1.543 ms, 1.593 ms]	200.411 µs (14.7%)
tracing	1.506 ms [1.482 ms, 1.53 ms]	138.408 µs (10.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.365 ms [1.346 ms, 1.385 ms]	-
appsec	1.745 ms [1.722 ms, 1.769 ms]	379.868 µs (27.8%)
appsec_no_iast	1.766 ms [1.743 ms, 1.789 ms]	400.583 µs (29.3%)
iast	1.499 ms [1.474 ms, 1.523 ms]	133.389 µs (9.8%)
profiling	1.519 ms [1.495 ms, 1.542 ms]	153.22 µs (11.2%)
tracing	1.502 ms [1.477 ms, 1.527 ms]	136.552 µs (10.0%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~cb9a2d4b0d, baseline=1.47.0-SNAPSHOT~dcf73eb0cb
    dateFormat X
    axisFormat %s
section baseline
no_agent (381.014 µs) : 361, 401
.   : milestone, 381,
iast (524.514 µs) : 503, 546
.   : milestone, 525,
iast_FULL (752.115 µs) : 730, 774
.   : milestone, 752,
iast_GLOBAL (568.204 µs) : 546, 591
.   : milestone, 568,
iast_HARDCODED_SECRET_DISABLED (516.453 µs) : 494, 539
.   : milestone, 516,
iast_INACTIVE (472.058 µs) : 450, 494
.   : milestone, 472,
iast_TELEMETRY_OFF (499.445 µs) : 478, 521
.   : milestone, 499,
tracing (465.893 µs) : 445, 487
.   : milestone, 466,
section candidate
no_agent (386.41 µs) : 367, 406
.   : milestone, 386,
iast (513.896 µs) : 492, 536
.   : milestone, 514,
iast_FULL (753.68 µs) : 732, 776
.   : milestone, 754,
iast_GLOBAL (561.454 µs) : 539, 584
.   : milestone, 561,
iast_HARDCODED_SECRET_DISABLED (514.949 µs) : 492, 538
.   : milestone, 515,
iast_INACTIVE (461.646 µs) : 440, 483
.   : milestone, 462,
iast_TELEMETRY_OFF (506.181 µs) : 483, 529
.   : milestone, 506,
tracing (468.978 µs) : 447, 491
.   : milestone, 469,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	381.014 µs [361.141 µs, 400.886 µs]	-
iast	524.514 µs [502.865 µs, 546.163 µs]	143.5 µs (37.7%)
iast_FULL	752.115 µs [730.266 µs, 773.964 µs]	371.101 µs (97.4%)
iast_GLOBAL	568.204 µs [545.859 µs, 590.549 µs]	187.19 µs (49.1%)
iast_HARDCODED_SECRET_DISABLED	516.453 µs [494.363 µs, 538.542 µs]	135.439 µs (35.5%)
iast_INACTIVE	472.058 µs [450.114 µs, 494.003 µs]	91.045 µs (23.9%)
iast_TELEMETRY_OFF	499.445 µs [477.896 µs, 520.993 µs]	118.431 µs (31.1%)
tracing	465.893 µs [444.629 µs, 487.157 µs]	84.879 µs (22.3%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	386.41 µs [366.851 µs, 405.969 µs]	-
iast	513.896 µs [492.233 µs, 535.559 µs]	127.486 µs (33.0%)
iast_FULL	753.68 µs [731.722 µs, 775.638 µs]	367.27 µs (95.0%)
iast_GLOBAL	561.454 µs [539.362 µs, 583.546 µs]	175.044 µs (45.3%)
iast_HARDCODED_SECRET_DISABLED	514.949 µs [492.02 µs, 537.877 µs]	128.539 µs (33.3%)
iast_INACTIVE	461.646 µs [440.252 µs, 483.039 µs]	75.236 µs (19.5%)
iast_TELEMETRY_OFF	506.181 µs [483.49 µs, 528.872 µs]	119.771 µs (31.0%)
tracing	468.978 µs [446.786 µs, 491.169 µs]	82.568 µs (21.4%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	alejandro.gonzalez/Configuration-to-Disable-APM-Tracing
git_commit_date	1739453354	1739516597
git_commit_sha	`dcf73eb`	`cb9a2d4`
release_version	1.47.0-SNAPSHOT~dcf73eb0cb	1.47.0-SNAPSHOT~cb9a2d4b0d

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1739518566	1739518566
ci_job_id	808303969	808303969
ci_pipeline_id	55896926	55896926
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-nsas5zms-project-304-concurrent-3-1aj9ky3d 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-nsas5zms-project-304-concurrent-3-1aj9ky3d 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~cb9a2d4b0d, baseline=1.47.0-SNAPSHOT~dcf73eb0cb
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.477 ms) : 1465, 1488
.   : milestone, 1477,
appsec (2.372 ms) : 2329, 2416
.   : milestone, 2372,
iast (2.116 ms) : 2061, 2171
.   : milestone, 2116,
iast_GLOBAL (2.156 ms) : 2101, 2212
.   : milestone, 2156,
profiling (1.98 ms) : 1937, 2024
.   : milestone, 1980,
tracing (1.95 ms) : 1908, 1992
.   : milestone, 1950,
section candidate
no_agent (1.481 ms) : 1469, 1492
.   : milestone, 1481,
appsec (2.379 ms) : 2335, 2422
.   : milestone, 2379,
iast (2.113 ms) : 2059, 2168
.   : milestone, 2113,
iast_GLOBAL (2.154 ms) : 2099, 2209
.   : milestone, 2154,
profiling (1.983 ms) : 1940, 2027
.   : milestone, 1983,
tracing (1.953 ms) : 1910, 1995
.   : milestone, 1953,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.477 ms [1.465 ms, 1.488 ms]	-
appsec	2.372 ms [2.329 ms, 2.416 ms]	895.897 µs (60.7%)
iast	2.116 ms [2.061 ms, 2.171 ms]	639.07 µs (43.3%)
iast_GLOBAL	2.156 ms [2.101 ms, 2.212 ms]	679.89 µs (46.0%)
profiling	1.98 ms [1.937 ms, 2.024 ms]	503.547 µs (34.1%)
tracing	1.95 ms [1.908 ms, 1.992 ms]	473.03 µs (32.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.481 ms [1.469 ms, 1.492 ms]	-
appsec	2.379 ms [2.335 ms, 2.422 ms]	898.048 µs (60.6%)
iast	2.113 ms [2.059 ms, 2.168 ms]	632.659 µs (42.7%)
iast_GLOBAL	2.154 ms [2.099 ms, 2.209 ms]	673.374 µs (45.5%)
profiling	1.983 ms [1.94 ms, 2.027 ms]	502.481 µs (33.9%)
tracing	1.953 ms [1.91 ms, 1.995 ms]	472.085 µs (31.9%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~cb9a2d4b0d, baseline=1.47.0-SNAPSHOT~dcf73eb0cb
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.613 s) : 15613000, 15613000
.   : milestone, 15613000,
appsec (14.811 s) : 14811000, 14811000
.   : milestone, 14811000,
iast (18.957 s) : 18957000, 18957000
.   : milestone, 18957000,
iast_GLOBAL (18.379 s) : 18379000, 18379000
.   : milestone, 18379000,
profiling (15.008 s) : 15008000, 15008000
.   : milestone, 15008000,
tracing (15.199 s) : 15199000, 15199000
.   : milestone, 15199000,
section candidate
no_agent (14.901 s) : 14901000, 14901000
.   : milestone, 14901000,
appsec (15.261 s) : 15261000, 15261000
.   : milestone, 15261000,
iast (19.095 s) : 19095000, 19095000
.   : milestone, 19095000,
iast_GLOBAL (18.109 s) : 18109000, 18109000
.   : milestone, 18109000,
profiling (14.96 s) : 14960000, 14960000
.   : milestone, 14960000,
tracing (15.382 s) : 15382000, 15382000
.   : milestone, 15382000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.613 s [15.613 s, 15.613 s]	-
appsec	14.811 s [14.811 s, 14.811 s]	-802.0 ms (-5.1%)
iast	18.957 s [18.957 s, 18.957 s]	3.344 s (21.4%)
iast_GLOBAL	18.379 s [18.379 s, 18.379 s]	2.766 s (17.7%)
profiling	15.008 s [15.008 s, 15.008 s]	-605.0 ms (-3.9%)
tracing	15.199 s [15.199 s, 15.199 s]	-414.0 ms (-2.7%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.901 s [14.901 s, 14.901 s]	-
appsec	15.261 s [15.261 s, 15.261 s]	360.0 ms (2.4%)
iast	19.095 s [19.095 s, 19.095 s]	4.194 s (28.1%)
iast_GLOBAL	18.109 s [18.109 s, 18.109 s]	3.208 s (21.5%)
profiling	14.96 s [14.96 s, 14.96 s]	59.0 ms (0.4%)
tracing	15.382 s [15.382 s, 15.382 s]	481.0 ms (3.2%)

internal-api/src/main/java/datadog/trace/api/Config.java

sezen-datadog · 2025-02-04T14:13:58Z

just for my culture, are we switching from apm to asm or just disabling apm? i see code switch between these so it'd be cool for me to get a bit of understanding on what’s going on here, thank you!

jandro996 · 2025-02-04T14:22:38Z

just for my culture, are we switching from apm to asm or just disabling apm? i see code switch between these so it'd be cool for me to get a bit of understanding on what’s going on here, thank you!

Last year, due to ASM business needs, it became necessary to configure the tracer to work without APM. For various reasons (a long story—almost a year passed between the first RFC and the implementation! 😄), an ad-hoc implementation was chosen specifically for ASM, known as ASM Standalone Billing.

With the new RFC, the goal is to provide a more generic way to disable APM, allowing not only ASM but also other products to operate independently.

If you still have any questions or need more details, we can discuss them offline.

dd-trace-core/src/main/java/datadog/trace/core/propagation/ptags/PTagsFactory.java

manuel-alvarez-alvarez

LGTM (provided that the required system-tests are passing)

PerfectSlayer

That's good improvement 👍 Left a bunch of comments 😅

settings.gradle

dd-trace-core/src/main/java/datadog/trace/common/sampling/ApmTracingDisabledSampler.java

dd-trace-core/src/main/java/datadog/trace/core/propagation/ptags/PTagsCodec.java

internal-api/src/test/groovy/datadog/trace/api/ProductTraceSourceTest.groovy

dd-trace-core/src/main/java/datadog/trace/core/propagation/PropagationTags.java

dd-trace-core/src/main/java/datadog/trace/core/propagation/ptags/PTagsFactory.java

Mariovido

LGTM as the tests are passing and everything seems good, but I am not an expert in the topic.

internal-api/src/main/java/datadog/trace/api/ProductTraceSource.java

move cast to TagInterceptor instead of doing it on DDSpanContext

…atadogPropagationTagsTest.groovy Co-authored-by: Bruce Bujon <[email protected]>

This reverts commit 3ec5d83.

This reverts commit 5dc237b.

This reverts commit 289a048.

This reverts commit 449d681.

…exadecimal string and be able to parse masks of at least 32 bits to ensure forward compatibility

…ed and appsec/iast are enabled

This reverts commit b5f1b22.

jandro996 · 2025-02-14T07:05:03Z

Thanks for all the changes and improvements you made following the original review! 🤟

Thank you for taking the time to review this! 😊

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.46.1` -> `1.47.0` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.46.1` -> `1.47.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | --- ### Release Notes <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.47.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.47.0): 1.47.0 ##### Components ##### Application Security Management (IAST) - 🐛 Exclude com.stripe.net.HttpURLConnectionClient to solve IAST SSRF vulnerability false positives ([#8483](DataDog/dd-trace-java#8483) - [@jandro996](https://github.com/jandro996)) - 🐛 Add exclusion to solve IAST weak randomness vulnerability false positives ([#8462](DataDog/dd-trace-java#8462) - [@jandro996](https://github.com/jandro996)) - ✨ Fix weak randomness false positive in Kafka client ([#8408](DataDog/dd-trace-java#8408) - [@smola](https://github.com/smola)) - ✨ Fix location for SSRF with Kong Unirest ([#8407](DataDog/dd-trace-java#8407) - [@smola](https://github.com/smola)) - ✨ Exclude IBM Instana from IAST ([#8406](DataDog/dd-trace-java#8406) - [@smola](https://github.com/smola)) - 🐛 Fix org.json iast instrumentation test for latest dependency ([#8347](DataDog/dd-trace-java#8347) - [@jandro996](https://github.com/jandro996)) - ✨ Configuration to Disable APM Tracing ([#8219](DataDog/dd-trace-java#8219) - [@jandro996](https://github.com/jandro996)) - ✨ Address cookie vulnerability cardinality issues ([#8210](DataDog/dd-trace-java#8210) - [@jandro996](https://github.com/jandro996)) - ✨ Email HTML Injection detection in IAST ([#8205](DataDog/dd-trace-java#8205) - [@sezen-datadog](https://github.com/sezen-datadog)) ##### Application Security Management (WAF) - 🐛✨ Ensure usr.exists tag is not overridden when UsernameNotFoundException is thrown ([#8376](DataDog/dd-trace-java#8376) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - 🐛✨ Ensure usr.exists tag is not overridden by auto instrumentation ([#8374](DataDog/dd-trace-java#8374) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Update appsec metrics with event_rules_version tag ([#8354](DataDog/dd-trace-java#8354) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Update metrics: appsec.waf.requests ([#8353](DataDog/dd-trace-java#8353) - [@Mariovido](https://github.com/Mariovido)) - ✨ Improve ASM support in vert.x 5.0 ([#8285](DataDog/dd-trace-java#8285) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Update metrics: appsec.waf.updates and appsec.waf.init ([#8280](DataDog/dd-trace-java#8280) - [@Mariovido](https://github.com/Mariovido)) - ✨ Configuration to Disable APM Tracing ([#8219](DataDog/dd-trace-java#8219) - [@jandro996](https://github.com/jandro996)) ##### Build & Tooling - 🐛 Do not generate Muzzle references for primitive arrays in method body ([#8361](DataDog/dd-trace-java#8361) - [@amarziali](https://github.com/amarziali)) - 📖 Improve dev env setup documentation for Windows ([#8180](DataDog/dd-trace-java#8180) - [@lucaspimentel](https://github.com/lucaspimentel)) ##### Continuous Integration Visibility - ✨ Add support for skip-EFD tagging ([#8487](DataDog/dd-trace-java#8487) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix an NPE in Gradle Android instrumentation ([#8484](DataDog/dd-trace-java#8484) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Consider modified tests when applying fail-fast tests ordering ([#8474](DataDog/dd-trace-java#8474) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement tests reordering for TestNG ([#8467](DataDog/dd-trace-java#8467) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix Gradle Launcher instrumentation to not interfere with Gradle Test Kit ([#8465](DataDog/dd-trace-java#8465) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Use separate TestEventHandlers per framework in CI Vis instrumentations ([#8451](DataDog/dd-trace-java#8451) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Remove warning log when JUnit 4 test method cannot be retrieved ([#8445](DataDog/dd-trace-java#8445) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix Scalatest tracing for tests that are reported asynchronously ([#8444](DataDog/dd-trace-java#8444) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement attempt to fix tests ([#8393](DataDog/dd-trace-java#8393) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement test disabling ([#8377](DataDog/dd-trace-java#8377) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Update CODEOWNERS parser to not log errors on comments with leading whitespace ([#8349](DataDog/dd-trace-java#8349) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Request Test Management tests list ([#8345](DataDog/dd-trace-java#8345) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Receive test management settings from CIVis settings request ([#8331](DataDog/dd-trace-java#8331) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement quarantined tests tagging ([#8326](DataDog/dd-trace-java#8326) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement tests quarantining ([#8320](DataDog/dd-trace-java#8320) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add tag to specify if the user is setting DD_SERVICE ([#8318](DataDog/dd-trace-java#8318) - [@daniel-mohedano](https://github.com/daniel-mohedano)) ##### Crash tracking - ✨ Only fork jps when required ([#8419](DataDog/dd-trace-java#8419) - [@mcculls](https://github.com/mcculls)) - 🐛 Use Java home of the crashed process to launch crash uploader ([#8348](DataDog/dd-trace-java#8348) - [@jbachorik](https://github.com/jbachorik)) ##### Data Streams Monitoring - 🐛 Fix error happening when sqs message attributes are readonly ([#8473](DataDog/dd-trace-java#8473) - [@vandonr](https://github.com/vandonr)) - 🐛 Fix bug on proto schema extraction ([#8403](DataDog/dd-trace-java#8403) - [@vandonr](https://github.com/vandonr)) - 🐛 Fix service name overrides in consumers ([#8387](DataDog/dd-trace-java#8387) - [@piochelepiotr](https://github.com/piochelepiotr)) ##### Database Monitoring - ✨ Add DBMTracePreparedStatements to tracer configuration log ([#8508](DataDog/dd-trace-java#8508) - [@cecile75](https://github.com/cecile75)) ##### Dynamic Instrumentation - ✨ Look in another location for grpc service methods ([#8468](DataDog/dd-trace-java#8468) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Fix Exception Replay with Lambda proxy classes ([#8452](DataDog/dd-trace-java#8452) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add code origin support for spring-webmvc ([#8416](DataDog/dd-trace-java#8416) - [@evanchooly](https://github.com/evanchooly)) - ✨ Add support for scanning jar from loaded class ([#8370](DataDog/dd-trace-java#8370) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Disable capture of entry values ([#8369](DataDog/dd-trace-java#8369) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix CodeOrigin for `@Trace` annotation ([#8344](DataDog/dd-trace-java#8344) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix equals/hashCode for CodeOrigin probe ([#8319](DataDog/dd-trace-java#8319) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add code origin support to kafka message listeners ([#8301](DataDog/dd-trace-java#8301) - [@evanchooly](https://github.com/evanchooly)) ##### Metrics - ✨ Create metric: appsec.waf.error ([#8381](DataDog/dd-trace-java#8381) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Create metric: appsec.rasp.error ([#8364](DataDog/dd-trace-java#8364) - [@sezen-datadog](https://github.com/sezen-datadog)) ##### Profiling - ✨ Bump ddprof library to 1.22.0 ([#8463](DataDog/dd-trace-java#8463) - [@jbachorik](https://github.com/jbachorik)) - IBM J9 8u361 corresponds to OpenJDK 8u362 by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#187 - Fix compatibility with musl libc 1.2.4 by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#189 - Modify version extraction by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#179 - Do not write null values to jvminfo event by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#184 - Productize VMStructs-based stack walker by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#177 - A few minor downport issues by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#180 - Enable ASGCT by default on fairly safe J9 JDK versions by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#181 - 🐛 Exclude OrderedThreadPoolExecutor from queue-time measurements ([#8456](DataDog/dd-trace-java#8456) - [@jbachorik](https://github.com/jbachorik)) - ✨ Record JVM info on JVMs without JFR ([#8431](DataDog/dd-trace-java#8431) - [@jbachorik](https://github.com/jbachorik)) - 🐛 Actually use CleanupTask in TempLocationManager ([#8420](DataDog/dd-trace-java#8420) - [@mcculls](https://github.com/mcculls)) - ✨ Only fork jps when required ([#8419](DataDog/dd-trace-java#8419) - [@mcculls](https://github.com/mcculls)) - 🐛 Adjust JFR checks for J9 ([#8405](DataDog/dd-trace-java#8405) - [@jbachorik](https://github.com/jbachorik)) - 🧹 Disable smap RSS parsing by default ([#8342](DataDog/dd-trace-java#8342) - [@MattAlp](https://github.com/MattAlp)) ##### Telemetry - 🐛 Add support for JBoss jar:file format to DependencyResolver ([#8428](DataDog/dd-trace-java#8428) - [@jandro996](https://github.com/jandro996)) - ✨ Update metrics: appsec.waf.requests ([#8353](DataDog/dd-trace-java#8353) - [@Mariovido](https://github.com/Mariovido)) ##### Trace context propagation - ✨ Introduce tracing propagator ([#8313](DataDog/dd-trace-java#8313) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Tracer core - 🐛 Fix Stable Config telemetry source names ([#8460](DataDog/dd-trace-java#8460) - [@BaptisteFoy](https://github.com/BaptisteFoy)) - ✨ Probe trace endpoints with a valid payload of empty arrays ([#8414](DataDog/dd-trace-java#8414) - [@mcculls](https://github.com/mcculls)) - ✨ Add 1 minute fail-safe to JUL/JMX class-loading callback ([#8399](DataDog/dd-trace-java#8399) - [@mcculls](https://github.com/mcculls)) - ✨ Migrate DSM injection calls to context-first APIs ([#8383](DataDog/dd-trace-java#8383) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 🧹 Move continuation capture methods from scope to tracer ([#8371](DataDog/dd-trace-java#8371) - [@mcculls](https://github.com/mcculls)) - ✨ Migrate context extraction calls to context-first APIs ([#8368](DataDog/dd-trace-java#8368) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 🧹 Migrate context injection calls to context-first APIs ([#8358](DataDog/dd-trace-java#8358) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 💡 Support reading configurations from files ([#8338](DataDog/dd-trace-java#8338) - [@mtoffl01](https://github.com/mtoffl01)) - 💡 Implementation of BaggagePropagator and BaggageContext ([#8330](DataDog/dd-trace-java#8330) - [@mhlidd](https://github.com/mhlidd)) - 🧹 Combine continuation implementations into one which supports multiple activations ([#8324](DataDog/dd-trace-java#8324) - [@mcculls](https://github.com/mcculls)) - ✨ Introduce tracing propagator ([#8313](DataDog/dd-trace-java#8313) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Remove old context propagation API ([#8271](DataDog/dd-trace-java#8271) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Instrumentations ##### AWS Lambda instrumentation - 🐛 Send error message and stack to Lambda extension ([#8417](DataDog/dd-trace-java#8417) - [@nhulston](https://github.com/nhulston)) ##### AWS SDK instrumentation - 🐛 Fix error happening when sqs message attributes are readonly ([#8473](DataDog/dd-trace-java#8473) - [@vandonr](https://github.com/vandonr)) - 💡 Inject trace context into AWS Step Functions input ([#7585](DataDog/dd-trace-java#7585) - [@DylanLovesCoffee](https://github.com/DylanLovesCoffee)) ##### Core Java language instrumentation - ✨ Look in another location for grpc service methods ([#8468](DataDog/dd-trace-java#8468) - [@evanchooly](https://github.com/evanchooly)) - ✨ Add code origin support for spring-webmvc ([#8416](DataDog/dd-trace-java#8416) - [@evanchooly](https://github.com/evanchooly)) - 💡 Implementation of BaggagePropagator and BaggageContext ([#8330](DataDog/dd-trace-java#8330) - [@mhlidd](https://github.com/mhlidd)) - ✨ Add code origin support to kafka message listeners ([#8301](DataDog/dd-trace-java#8301) - [@evanchooly](https://github.com/evanchooly)) ##### gRPC instrumentation - ✨ Look in another location for grpc service methods ([#8468](DataDog/dd-trace-java#8468) - [@evanchooly](https://github.com/evanchooly)) ##### Kafka instrumentation - ✨ Add messaging.destination.name tag to kafka integrations ([#8366](DataDog/dd-trace-java#8366) - [@rarguelloF](https://github.com/rarguelloF)) ##### Protocol Buffer instrumentation - 🐛 Fix bug on proto schema extraction ([#8403](DataDog/dd-trace-java#8403) - [@vandonr](https://github.com/vandonr)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 108a0f86aa59ab4c938cbac0688dd4c19cb301fa

jandro996 added the type: enhancement label Jan 16, 2025

datadog-datadog-prod-us1 bot reviewed Jan 22, 2025

View reviewed changes

internal-api/src/main/java/datadog/trace/api/Config.java Outdated Show resolved Hide resolved

jandro996 force-pushed the alejandro.gonzalez/Configuration-to-Disable-APM-Tracing branch from bfd572e to 33ce3ad Compare January 24, 2025 10:19

jandro996 force-pushed the alejandro.gonzalez/Configuration-to-Disable-APM-Tracing branch 2 times, most recently from 4188a6d to 1e9bb61 Compare February 4, 2025 11:36

jandro996 added comp: asm waf Application Security Management (WAF) comp: asm iast Application Security Management (IAST) and removed comp: asm waf Application Security Management (WAF) labels Feb 4, 2025

jandro996 marked this pull request as ready for review February 4, 2025 14:08

jandro996 requested review from a team as code owners February 4, 2025 14:08

jandro996 requested review from manuel-alvarez-alvarez and Mariovido February 4, 2025 14:08

jandro996 requested a review from smola February 4, 2025 14:24

manuel-alvarez-alvarez reviewed Feb 6, 2025

View reviewed changes

dd-trace-core/src/main/java/datadog/trace/core/propagation/ptags/PTagsFactory.java Outdated Show resolved Hide resolved

manuel-alvarez-alvarez approved these changes Feb 7, 2025

View reviewed changes

jandro996 requested a review from PerfectSlayer February 10, 2025 09:55

jandro996 force-pushed the alejandro.gonzalez/Configuration-to-Disable-APM-Tracing branch from cc5dd28 to a519cba Compare February 10, 2025 09:57

PerfectSlayer reviewed Feb 10, 2025

View reviewed changes

Mariovido approved these changes Feb 10, 2025

View reviewed changes

PerfectSlayer mentioned this pull request Feb 10, 2025

Migrate context injection calls to context-first APIs #8358

Merged

jandro996 force-pushed the alejandro.gonzalez/Configuration-to-Disable-APM-Tracing branch from 2a13398 to dc55a60 Compare February 11, 2025 06:24

jandro996 requested a review from a team as a code owner February 11, 2025 06:24

datadog-datadog-prod-us1 bot reviewed Feb 11, 2025

View reviewed changes

internal-api/src/main/java/datadog/trace/api/ProductTraceSource.java Show resolved Hide resolved

jandro996 force-pushed the alejandro.gonzalez/Configuration-to-Disable-APM-Tracing branch from 4dea16f to 0ff5dfb Compare February 12, 2025 14:09

jandro996 requested a review from PerfectSlayer February 13, 2025 06:44

jandro996 and others added 22 commits February 14, 2025 07:56

remove unnecessary refactor

dc2155c

keep it alphabetically

2f82fc4

Add meaningful constant UNSET to ProductTraceSource 0

b2d4922

Improve javadoc

8bdff19

remove deprecated datadog.trace.api.sampling.PrioritySampling

13aaa1e

lowercase the trace source tag value

32f7b6e

refactor to traceSource and addTraceSource

31f9ae0

move cast to TagInterceptor instead of doing it on DDSpanContext

fix rebased compilation errors

50763f1

fix spotless

fed37e5

fixTracingPropagatorTest

7f32632

more meaningful constant changes and renaming Ts with TraceSource

497c568

Update dd-trace-core/src/test/groovy/datadog/trace/core/propagation/D…

2d4965b

…atadogPropagationTagsTest.groovy Co-authored-by: Bruce Bujon <[email protected]>

typo

a0edcc0

change decision maker to default for ApmTracingDisabledSampler

b7c425d

Revert "fix muzzle and check previous latest version"

3dc7926

This reverts commit 3ec5d83.

Revert "add new instrumentation and cover more constructors"

6d00e1e

This reverts commit 5dc237b.

Revert "fix codenarc"

8149451

This reverts commit 289a048.

Revert "Fix org.json iast instrumentation test for latest dependency"

3c2f068

This reverts commit 449d681.

product trace source should generate two-character case-insensitive h…

f994bac

…exadecimal string and be able to parse masks of at least 32 bits to ensure forward compatibility

special standalone sampler should only be used when tracing is disabl…

92ff472

…ed and appsec/iast are enabled

fix merge issues

4867759

rename updatePropagatedTraceSource method

b5f1b22

jandro996 force-pushed the alejandro.gonzalez/Configuration-to-Disable-APM-Tracing branch from f2e3461 to b5f1b22 Compare February 14, 2025 07:01

jandro996 added 2 commits February 14, 2025 08:02

Revert "rename updatePropagatedTraceSource method"

8eb0d65

This reverts commit b5f1b22.

rename updatePropagatedTraceSource method

cb9a2d4

jandro996 merged commit 053a36f into master Feb 14, 2025
203 checks passed

jandro996 deleted the alejandro.gonzalez/Configuration-to-Disable-APM-Tracing branch February 14, 2025 08:16

github-actions bot added this to the 1.47.0 milestone Feb 14, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Configuration to Disable APM Tracing #8219

Configuration to Disable APM Tracing #8219

jandro996 commented Jan 16, 2025 •

edited

Loading

pr-commenter bot commented Jan 16, 2025 •

edited

Loading

sezen-datadog commented Feb 4, 2025

jandro996 commented Feb 4, 2025

manuel-alvarez-alvarez left a comment

PerfectSlayer left a comment

Mariovido left a comment

jandro996 commented Feb 14, 2025

Configuration to Disable APM Tracing #8219

Configuration to Disable APM Tracing #8219

Conversation

jandro996 commented Jan 16, 2025 • edited Loading

What Does This Do

Motivation

Additional Notes

Contributor Checklist

pr-commenter bot commented Jan 16, 2025 • edited Loading

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

sezen-datadog commented Feb 4, 2025

jandro996 commented Feb 4, 2025

manuel-alvarez-alvarez left a comment

Choose a reason for hiding this comment

PerfectSlayer left a comment

Choose a reason for hiding this comment

Mariovido left a comment

Choose a reason for hiding this comment

jandro996 commented Feb 14, 2025

jandro996 commented Jan 16, 2025 •

edited

Loading

pr-commenter bot commented Jan 16, 2025 •

edited

Loading