gRPC-1.5 instrumentation: regenerated via RPC-category readiness loop - #12417
Draft
jordan-wong wants to merge 3 commits into
Draft
gRPC-1.5 instrumentation: regenerated via RPC-category readiness loop#12417jordan-wong wants to merge 3 commits into
jordan-wong wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
component,span.kind, and status tags per side (R-RPC-2).QueuedCommandInstrumentation(a Netty write-queue profiling hook with no client/server call-path overlap) is explicitly re-created rather than silently dropped, per the loop's per-file enumeration rule.Test plan
component,span.kind,rpc.servicetags as expectedmaster's existing gRPC test coverage🤖 Generated with the apm-instrumentation-toolkit RPC category readiness loop.