Skip to content

Conversation

@kakkoyun
Copy link
Member

@kakkoyun kakkoyun commented Nov 24, 2025

What does this PR do?

Add benchmarks for parseSymbol function.

Motivation

Get a baseline for #4148

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@kakkoyun kakkoyun requested review from a team as code owners November 24, 2025 15:48
@kakkoyun kakkoyun changed the title kakkoyun/add parse symbol benchmark chore(stacktrace): Add parseSymbol benchmark Nov 24, 2025
@kakkoyun kakkoyun changed the base branch from main to kakkoyun/use_stacktrace_package November 24, 2025 15:49
@pr-commenter
Copy link

pr-commenter bot commented Nov 24, 2025

Benchmarks

Benchmark execution time: 2025-11-24 16:22:17

Comparing candidate commit 53fd516 in PR branch kakkoyun/add_parse_symbol_benchmark with baseline commit 922bd28 in branch kakkoyun/use_stacktrace_package.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@kakkoyun kakkoyun merged commit fb0e119 into kakkoyun/use_stacktrace_package Nov 24, 2025
241 of 248 checks passed
@kakkoyun kakkoyun deleted the kakkoyun/add_parse_symbol_benchmark branch November 24, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants