Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ktlo(ddtrace,contrib): don't use hardcoded FS paths on integration/telemetry tests #3122

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

darccio
Copy link
Member

@darccio darccio commented Jan 27, 2025

What does this PR do?

Fixes Windows CI removing hardcoded Unix-style filesystem paths in TestIntegrationEnabled and TestTelemetryEnabled.

Motivation

Happy CI, happy devs.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@darccio darccio requested review from a team as code owners January 27, 2025 12:32
@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Jan 27, 2025
@datadog-datadog-prod-us1
Copy link

Datadog Report

Branch report: dario.castane/langplat-289/ktlo-fix-windows-ci
Commit report: 057d8e6
Test service: dd-trace-go

✅ 0 Failed, 5207 Passed, 72 Skipped, 2m 49.23s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Jan 27, 2025

Benchmarks

Benchmark execution time: 2025-01-27 12:53:39

Comparing candidate commit 8ce68f7 in PR branch dario.castane/langplat-289/ktlo-fix-windows-ci with baseline commit ef2e4e2 in branch main.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 0 unstable metrics.

scenario:BenchmarkPartialFlushing/Disabled-24

  • 🟩 execution_time [-12.166ms; -9.102ms] or [-4.382%; -3.279%]

scenario:BenchmarkPartialFlushing/Enabled-24

  • 🟩 execution_time [-11.939ms; -8.206ms] or [-4.228%; -2.906%]

Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Is there a failing test that's bitten by this already?

@hannahkm
Copy link
Contributor

Is there a failing test that's bitten by this already?

TestTelemetryEnabled and TestIntegrationEnabled were flaky on Windows. Do you think this PR will fix that? @darccio 👀

@darccio
Copy link
Member Author

darccio commented Jan 28, 2025

@hannahkm Yes, this should fix the Windows tests.

@kakkoyun Also yes, the tests running only on main, with some Windows pipelines, were failing due to these hardcoded paths.

@darccio darccio merged commit 599da51 into main Jan 28, 2025
177 checks passed
@darccio darccio deleted the dario.castane/langplat-289/ktlo-fix-windows-ci branch January 28, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants