Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/gorm.io/gorm.v1: fix orchestrion aspect #3121

Merged
merged 5 commits into from
Feb 3, 2025

Conversation

rarguelloF
Copy link
Contributor

What does this PR do?

Fixes DataDog/orchestrion#511

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Jan 27, 2025
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 27, 2025

Datadog Report

Branch report: rarguelloF/fix-gorm-orchestrion-issue
Commit report: c1e3157
Test service: dd-trace-go

✅ 0 Failed, 5221 Passed, 72 Skipped, 2m 7.43s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Jan 27, 2025

Benchmarks

Benchmark execution time: 2025-02-03 09:19:48

Comparing candidate commit b621f95 in PR branch rarguelloF/fix-gorm-orchestrion-issue with baseline commit 2ee7731 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 1 unstable metrics.

@rarguelloF rarguelloF marked this pull request as ready for review January 30, 2025 09:28
@rarguelloF rarguelloF requested review from a team as code owners January 30, 2025 09:28
@rarguelloF rarguelloF enabled auto-merge (squash) January 30, 2025 09:28
@rarguelloF rarguelloF merged commit b143b60 into main Feb 3, 2025
176 checks passed
@rarguelloF rarguelloF deleted the rarguelloF/fix-gorm-orchestrion-issue branch February 3, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Auto instrumentation with gorm fails
3 participants