-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable 128bit trace ID logging by default #3116
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Datadog ReportBranch report: ✅ 0 Failed, 4332 Passed, 65 Skipped, 3m 38.88s Total Time |
a7fe208
to
bcb6ad2
Compare
b650c65
to
d0ee2a1
Compare
7 tasks
hannahkm
reviewed
Feb 26, 2025
hannahkm
reviewed
Feb 26, 2025
hannahkm
reviewed
Feb 26, 2025
hannahkm
approved these changes
Feb 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but confused why the Orchestrion tests are failing. Maybe @darccio or @RomainMuller would know?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Logs contain the full 128bits of the trace id by default. Can be disabled with
DD_TRACE_128_BIT_TRACEID_LOGGING_ENABLED=false
. Feature applies to tracer logs as well as our supported logger integrations: slog and logrus.Motivation
Config consistency
Reviewer's Checklist
v2-dev
branch and reviewed by @DataDog/apm-go.Unsure? Have a question? Request a review!