Skip to content

Conversation

khewonc
Copy link
Contributor

@khewonc khewonc commented Sep 29, 2025

What does this PR do?

Allows GPU feature to be overridden by DAPs (requires DDAIs)

Motivation

https://datadoghq.atlassian.net/browse/AGENTONB-2322

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

  • Deploy the operator with profiles enabled and DDAI disabled
  • With DDAI disabled, try setting GPU feature overrides. It should give a reconciler error (which can be viewed in the DAP status)
  • Enable DDAI and ensure a DAP with GPU feature overrides only (no node agent overrides) is valid and that the GPU settings can be overridden

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@khewonc khewonc added this to the v1.21.0 milestone Sep 29, 2025
@khewonc khewonc requested a review from a team as a code owner September 29, 2025 20:16
@khewonc khewonc added the enhancement New feature or request label Sep 29, 2025
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.15%. Comparing base (d383cd6) to head (e2f2636).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2212      +/-   ##
==========================================
+ Coverage   39.12%   39.15%   +0.02%     
==========================================
  Files         253      253              
  Lines       26044    26051       +7     
==========================================
+ Hits        10190    10200      +10     
+ Misses      15247    15245       -2     
+ Partials      607      606       -1     
Flag Coverage Δ
unittests 39.15% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...controller/datadogagent/controller_reconcile_v2.go 58.62% <100.00%> (ø)
internal/controller/datadogagent/profile.go 80.48% <100.00%> (+3.76%) ⬆️
pkg/agentprofile/agent_profile.go 72.03% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d383cd6...e2f2636. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants