Remove deprecated dependencies #1712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuheiktgw
commented
Feb 20, 2025
| @@ -33,6 +33,13 @@ | |||
| ' \+', | |||
| ] | |||
|
|
|||
| [[linters-settings.depguard.rules.main.deny]] | |||
There was a problem hiding this comment.
I found an issue with the make lint command—golangci-lint doesn’t actually run in api/ and e2e/ because it doesn’t recognize go.work. I'll address this in a separate PR.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1712 +/- ##
==========================================
- Coverage 50.02% 50.02% -0.01%
==========================================
Files 228 228
Lines 21682 21680 -2
==========================================
- Hits 10847 10845 -2
Misses 10282 10282
Partials 553 553
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
swang392
approved these changes
Apr 30, 2025
levan-m
added a commit
that referenced
this pull request
May 1, 2025
* update podresources mount to only be in agent container (#1716) * feat(error tracking): add core agent and error tracking standalone settings (#1553) * Add core agent and error tracking standalone settings * Simplify bool condition * set up defaults * add tests * add example * fix tests * rework into ErrorTracking.Mode * rework into single errorTrackingStandalone variable * fix typo * update generated files * doc fixes --------- Co-authored-by: Eloy Toro <[email protected]> Co-authored-by: levan-m <[email protected]> Co-authored-by: Levan Machablishvili <[email protected]> * bump golang to 1.23.6 (#1720) * bump default agent images to 7.63.0 (#1722) * Update OTel agent image (#1728) * Update OTel agent image Use `7.63.0-ot-beta-jmx` instead of nightly image. This will need to be updated once OTel agent is GA (7.64.0), as the ot-beta image will be discontinued. * Update pkg/defaulting/images.go Co-authored-by: Celene <[email protected]> --------- Co-authored-by: Celene <[email protected]> * Generate fips image compiled with Go boringcrypto (#1731) * checkpoint: builds both with cli arg * fips image for main build * add jobs for generating fips image and publishing main-fips tag * fix main fips job references * fix param naming * fix: set `DD_ADP_ENABLED` to `true` on Core Agent when ADP enabled (#1725) * api/datadoghq/v2alpha1: add support for SSI targets (#1670) * api/datadoghq/v2alpha1: add support for SSI targets * error cleanup * revert example * Update docs/configuration.v2alpha1.md Co-authored-by: Alicia Scott <[email protected]> * feat(ssi): add tracer config options This commit adds the tracer config options we've just added. * Fix tests * Address PR feedback * Address PR feedback * add log to warn for non-compatible agent version * fix * fix lint * fix tests * update types --------- Co-authored-by: Mark Spicer <[email protected]> Co-authored-by: Alicia Scott <[email protected]> Co-authored-by: Mark Spicer <[email protected]> Co-authored-by: Celene <[email protected]> * Add gitlab workflows to publish fips images (#1732) * Add gitlab workflows to publish fips images * Add back -w -s ldflags * bump kustomize to 5.6.0 (#1735) * Update check_preflight_redhat_image image tag (#1740) * Remove IsReadOnly from dashboard (#1742) * bump 7.63.2 (#1744) * Pass fips image tag to internal fips template (#1748) * Support agent sidecar securityContext (#1733) * add doc page for slos (#1757) * bump 7.63.3 (#1760) * update default fips-proxy image version to 1.1.8 (#1763) * small fix for error handling (#1768) * Fix internal fips image tag (#1770) * [CECO-2004] Always run e2e tests on release branches (#1764) * always run e2e tests on rc branches (test) * testing * remove testing rules * use default provenance and oci media type (#1772) * Gate profile canary waits behind annotation (#1758) * use partof label to cleanup only owned ds/deployments (#1767) * Handle Daemonset notFound when deleting Agent DS (#1779) * Handle Daemonset notFound when deleting Agent DS * Update internal/controller/datadogagent/controller_v2_test.go Co-authored-by: Celene <[email protected]> --------- Co-authored-by: Celene <[email protected]> * Pass TMPL_RELEASE_TAG in internal image build workflow (#1782) * Clean up integration tests (#1715) * Revert "Pass TMPL_RELEASE_TAG in internal image build workflow (#1782)" (#1788) This reverts commit 780f696. * DOCS-10284: editing operator docs (#1755) * initial pass at docs edits * finishing edit * Apply suggestions from code review Co-authored-by: Alicia Scott <[email protected]> Co-authored-by: Celene <[email protected]> * edits * Apply suggestions from code review Co-authored-by: Celene <[email protected]> * edits --------- Co-authored-by: Alicia Scott <[email protected]> Co-authored-by: Celene <[email protected]> * [feature/eventcollection] Don't set anything for the node agent (#1781) Co-authored-by: fanny-jiang <[email protected]> * [component/agent/default] Don't set DD_LEADER_ELECTION (#1787) Co-authored-by: fanny-jiang <[email protected]> * fix typo in license dir on operator image (#1793) * fix typo * remove un-necessary mkdir * enhancement: per-container image override support (#1730) * add support for Service Discovery network stats collection (#1780) * add config option for Service Discovery network stats collection * fix default value * Update internal/controller/datadogagent/feature/servicediscovery/feature.go Co-authored-by: Celene <[email protected]> * fix CR --------- Co-authored-by: Celene <[email protected]> * [tooling] use latest preflight version (#1797) * fixing links (#1799) * [CECO-2084] Handle custom versions (not following semver) as always above minVersion (#1786) * handle main/latest as always above minVersion * return true when unable to convert to semver * Change Operator base image from ubi-minimal to ubi-micro (#1798) * Change Operator base image from ubi-minimal to ubi-micro * switch check image to ubi-micro * Update correct file * update bundles following 1.13.0 release (#1806) * [tooling][gitlab] separate publishing latest images, tweak community operators job (#1803) * separate publishing latest images, tweak community operators job * update from review * sort git tag by semver (#1807) * servicediscovery: add mounts of module and src volumes (#1804) * [documentation] add example for configuring extra confd (#1811) * [documentation] add example for configuring extra confd * address feedback * small edit * Add backport PR GHA (#1809) * testing backport pr * testing conditions run without merge * more testing conditions * trying app token * test on branch * add workflow dispatch * switch to pull_request for testing * cleaning up * trigger workflow in 2 scenarios 1. pr labeled after merge, merge action 2. pr merged but label is already present * copy ca certs from ubi minimal (#1820) * [autoscaling] Make objectives required CRD v1alpha2 (#1819) * Support evaluation window option for monitors (#1702) Co-authored-by: levan-m <[email protected]> * [CECO-2004] Run e2e tests in more conditions (#1777) * reorder e2e stage jobs * reorder stages * update conditions for e2e * change conditional for conductor triggered job * always run e2e tests otherwise * add logging, cleanup * remove debugging lines * nit * extend ksmcheck waitFor duration * extend check time more * add error tracking standalone var to the core agent (#1818) * Allow to configure SlowStartAdditiveIncrease (#1821) * Update backport PR conditions (#1826) * update run action conditions * noop change for testing (#1822) * remove create app token step * update to only run when labeling a merged pr * noop to test backport pr (#1824) * testing (#1825) * change test-id to integer string id (#1828) * Add validations to DatadogMonitorSpec (#1694) Co-authored-by: levan-m <[email protected]> * [e2e] Disable e2e tests on nightly build (#1829) * disable e2e on nightly * Update .gitlab-ci.yml Co-authored-by: Timothée Bavelier <[email protected]> --------- Co-authored-by: Timothée Bavelier <[email protected]> * [CECO-2005] Configure additional k8s versions for e2e CI (#1769) * always run e2e tests on rc branches (test) * testing * remove testing rules * add k8s versions and testing rules * add tags for runner type * run tests on ubuntu 2004 * change order of VMOption * remove ubuntu 20.04 vm and old versions * mistake with merge conflict --------- Co-authored-by: levan-m <[email protected]> * Enable pod-resources mount only with GPU monitoring enabled (#1801) * Enable podResources socket only with GPU monitoring feature * Add unit tests * Move env var * Update internal/controller/datadogagent/feature/gpu/feature_test.go Co-authored-by: Celene <[email protected]> * fix linter --------- Co-authored-by: Celene <[email protected]> Co-authored-by: levan-m <[email protected]> * (chore) E2E: use m5.xlarge instead of default t3.medium (#1831) * use m5.xlarge instead of default t3.medium * enable gitlab timestamps * modify aws provisioner * update default fips-proxy image version to 1.1.9 (#1830) Co-authored-by: levan-m <[email protected]> * Add checksd volume to ccr init-config (#1823) Co-authored-by: levan-m <[email protected]> * Add validations to DatadogDashboardSpec (#1704) Co-authored-by: Sarah Wang <[email protected]> * [kubectl plugin] Fallback to configmap leader attempt for `clusteragent` if lease failed (#1833) * add force-configmap flag * Revert "add force-configmap flag" This reverts commit b1b2cd4. * fallback instead of using flag * Bump Agent to 7.64.1 (#1834) * [defaulting] clean up unused image methods (#1839) * [defaulting] use jmx images for agent and cluster checks runner * clean up jmx methods instead * Add permission for PDB (#1841) Orchestrator needs it since 7.64.1 * [autoscaling] Move to v1alpha2 as only supported version for Cluster Agent 7.64+ (#1845) * Add flag (#1840) * sign with githubops containers key (#1850) * Bump Agent to 7.64.3 (#1847) * Bump Agent to 7.64.2 * Bump Agent to 7.64.3 * [tooling] Add milestone to automated backport PR (#1856) * automatically add milestone to backport pr * pin action by hash * [datadogpodautoscalers] Add local fallback policy (#1759) * Fix missing apostrophe in dpa json * Add fallback policy and types * Generate files * Fix typo in apply policy name * Use new fallback policy type * Update fallback policy to only expose necessary options * Update comment to reflect how pod resource objectives are defined * Use bool for enabling fallback to reflect binary option * fixup! Use bool for enabling fallback to reflect binary option * Use fallback as top level for flexibility to add other fallback modes in future * Fix SlowStartAdditiveIncrease (#1857) * update seccomp profile to fix k3s (#1862) Fixes #1726 * Add external as a valid recommendation source (#1867) * [CECO-2114] Fix backport automated milestone (#1860) * testing backport milestone addition * copy backport pr * pin to hash * remove some debug lines * Include golangci-lint in fmt Make target (#1714) * Include golangci-lint in fmt Make target * fix formatting issues --------- Co-authored-by: Sarah Wang <[email protected]> Co-authored-by: Sarah Wang <[email protected]> * fix SBOM feature env vars applying to all agents instead of just core (#1761) * fix SBOM feature env vars applying to all agents instead of just core * fix unit tests * SBOM: fix host root volumes for non-OS scans support (#1846) * SBOM: mount the full host root, instead of re-building it from package managers * fix tests * Delete v1beta1 CRDs from repo (#1874) * Delete v1beta1 CRDs from repo * cleanup patch-crd.sh * readme clean-up (#1872) * readme clean-up * address feedback * Update README.md Co-authored-by: Sarah Wang <[email protected]> * Update README.md Co-authored-by: Sarah Wang <[email protected]> --------- Co-authored-by: Sarah Wang <[email protected]> * Fix missing SlowStartAdditiveIncrease (#1882) * Refactor DatadogAgent reconciler (#1878) * use helpers + some unit tests (#1746) * Use object reconciler (#1778) * Move creds and dca token out of enabledefault (#1789) * Allow disabling features that are enabled by default (#1792) * Remove monitoredObject (#1795) * [Remote config feature] Agent & DCA are not required components, but need to be configured (#1805) * Refactor global (#1808) * [dda] update dependency fx names, move GetImage (#1842) * Remove rbac from enabledefault (#1827) * Move install info and seccomp out of enabledefault feature (#1866) --------- Co-authored-by: khewonc <[email protected]> Co-authored-by: Celene <[email protected]> Co-authored-by: levan-m <[email protected]> * Add permission for endpointslices (#1885) * Add permission for endpointslices * add kubebuilder makers * add cursor to gitignore, e.g. rules (#1886) * Remove deprecated dependencies (#1712) Co-authored-by: Sarah Wang <[email protected]> Co-authored-by: levan-m <[email protected]> * fix import * fix assert.Len --------- Co-authored-by: Celene <[email protected]> Co-authored-by: Gianluca Bortoli <[email protected]> Co-authored-by: Eloy Toro <[email protected]> Co-authored-by: Mackenzie <[email protected]> Co-authored-by: Toby Lawrence <[email protected]> Co-authored-by: Kyle Nusbaum <[email protected]> Co-authored-by: Mark Spicer <[email protected]> Co-authored-by: Alicia Scott <[email protected]> Co-authored-by: Mark Spicer <[email protected]> Co-authored-by: Sarah Wang <[email protected]> Co-authored-by: khewonc <[email protected]> Co-authored-by: Timothée Bavelier <[email protected]> Co-authored-by: Keisuke Umegaki <[email protected]> Co-authored-by: louis-cqrl <[email protected]> Co-authored-by: Shuhei Kitagawa <[email protected]> Co-authored-by: cecilia saixue watt <[email protected]> Co-authored-by: David Ortiz <[email protected]> Co-authored-by: fanny-jiang <[email protected]> Co-authored-by: Guillaume Pagnoux <[email protected]> Co-authored-by: Vincent Boulineau <[email protected]> Co-authored-by: Eloy Toro <[email protected]> Co-authored-by: AliDatadog <[email protected]> Co-authored-by: Guillermo Julián <[email protected]> Co-authored-by: Joachim <[email protected]> Co-authored-by: Jennifer Chen <[email protected]> Co-authored-by: Bryce Kahle <[email protected]> Co-authored-by: Sarah Wang <[email protected]> Co-authored-by: Paul Cacheux <[email protected]> Co-authored-by: Kangyi LI <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I've removed deprecated libraries and added a linter to prevent them from being imported again.
Motivation
These two libraries are deprecated and we should migrate them to new ones.
Additional Notes
N/A
Minimum Agent Versions
N/A
Describe your test plan
N/A
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel