chore: unused deps #804
Merged
chore: unused deps #804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AFAIK, protobuf is actually used by other crates although it's not used, I'll approve but not sure if it will build |
|
Looks like it built! I'm actually skeptical on the protobuf change tho, I'd need to run a manual check on it, when we introduced it, the compiler would complain about protobuf not being there 👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crate
rmp-serdewas listed as a dependency but was not used anywhere in the codebase.This PR removes it.
Reference: #390
Additional note:
protobuf was also removed in #368, but it still appears in Cargo.lock due to other transitive dependencies.