Skip to content

security_monitoring - Make Rule History endpoint public #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −26
Open

security_monitoring - Make Rule History endpoint public #591

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .apigentools-info
View file
Original file line number Diff line number Diff line change
@@ -4,13 +4,13 @@
"spec_versions": {
"v1": {
"apigentools_version": "1.6.6",
"regenerated": "2025-04-17 13:26:14.663007",
"spec_repo_commit": "12ab5180"
"regenerated": "2025-04-18 16:37:09.348427",
"spec_repo_commit": "8ff9b6bd"
},
"v2": {
"apigentools_version": "1.6.6",
"regenerated": "2025-04-17 13:26:14.680427",
"spec_repo_commit": "12ab5180"
"regenerated": "2025-04-18 16:37:09.364508",
"spec_repo_commit": "8ff9b6bd"
}
}
}
1 change: 0 additions & 1 deletion .generator/schemas/v2/openapi.yaml
View file
Original file line number Diff line number Diff line change
@@ -52698,7 +52698,6 @@ paths:
operator: OR
permissions:
- security_monitoring_rules_read
x-unstable: '**Note**: This endpoint is in beta and may be subject to changes.'
/api/v2/security_monitoring/signals:
get:
description: 'The list endpoint returns security signals that match a search
3 changes: 1 addition & 2 deletions examples/v2_security-monitoring_GetRuleVersionHistory.rs
View file
Original file line number Diff line number Diff line change
@@ -5,8 +5,7 @@ use datadog_api_client::datadogV2::api_security_monitoring::SecurityMonitoringAP

#[tokio::main]
async fn main() {
let mut configuration = datadog::Configuration::new();
configuration.set_unstable_operation_enabled("v2.GetRuleVersionHistory", true);
let configuration = datadog::Configuration::new();
let api = SecurityMonitoringAPI::with_config(configuration);
let resp = api
.get_rule_version_history(
3 changes: 1 addition & 2 deletions examples/v2_security-monitoring_GetRuleVersionHistory_2467565841.rs
View file
Original file line number Diff line number Diff line change
@@ -7,8 +7,7 @@ use datadog_api_client::datadogV2::api_security_monitoring::SecurityMonitoringAP
async fn main() {
// there is a valid "security_rule" in the system
let security_rule_id = std::env::var("SECURITY_RULE_ID").unwrap();
let mut configuration = datadog::Configuration::new();
configuration.set_unstable_operation_enabled("v2.GetRuleVersionHistory", true);
let configuration = datadog::Configuration::new();
let api = SecurityMonitoringAPI::with_config(configuration);
let resp = api
.get_rule_version_history(
1 change: 0 additions & 1 deletion src/datadog/configuration.rs
View file
Original file line number Diff line number Diff line change
@@ -174,7 +174,6 @@ impl Default for Configuration {
("v2.delete_historical_job".to_owned(), false),
("v2.get_finding".to_owned(), false),
("v2.get_historical_job".to_owned(), false),
("v2.get_rule_version_history".to_owned(), false),
("v2.get_sbom".to_owned(), false),
("v2.list_findings".to_owned(), false),
("v2.list_historical_jobs".to_owned(), false),
8 changes: 0 additions & 8 deletions src/datadogV2/api/api_security_monitoring.rs
View file
Original file line number Diff line number Diff line change
@@ -3807,14 +3807,6 @@ impl SecurityMonitoringAPI {
> {
let local_configuration = &self.config;
let operation_id = "v2.get_rule_version_history";
if local_configuration.is_unstable_operation_enabled(operation_id) {
warn!("Using unstable operation {operation_id}");
} else {
let local_error = datadog::UnstableOperationDisabledError {
msg: "Operation 'v2.get_rule_version_history' is not enabled".to_string(),
};
return Err(datadog::Error::UnstableOperationDisabledError(local_error));
}

// unbox and build optional parameters
let page_size = params.page_size;
12 changes: 4 additions & 8 deletions tests/scenarios/features/v2/security_monitoring.feature
View file
Original file line number Diff line number Diff line change
@@ -604,24 +604,21 @@ Feature: Security Monitoring

@generated @skip @team:DataDog/k9-cloud-security-platform
Scenario: Get a rule's version history returns "Bad Request" response
Given operation "GetRuleVersionHistory" enabled
And new "GetRuleVersionHistory" request
Given new "GetRuleVersionHistory" request
And request contains "rule_id" parameter from "REPLACE.ME"
When the request is sent
Then the response status is 400 Bad Request

@generated @skip @team:DataDog/k9-cloud-security-platform
Scenario: Get a rule's version history returns "Not Found" response
Given operation "GetRuleVersionHistory" enabled
And new "GetRuleVersionHistory" request
Given new "GetRuleVersionHistory" request
And request contains "rule_id" parameter from "REPLACE.ME"
When the request is sent
Then the response status is 404 Not Found

@generated @skip @team:DataDog/k9-cloud-security-platform
Scenario: Get a rule's version history returns "OK" response
Given operation "GetRuleVersionHistory" enabled
And new "GetRuleVersionHistory" request
Given new "GetRuleVersionHistory" request
And request contains "rule_id" parameter from "REPLACE.ME"
When the request is sent
Then the response status is 200 OK
@@ -737,8 +734,7 @@ Feature: Security Monitoring

@skip-go @skip-java @skip-ruby @team:DataDog/k9-cloud-security-platform
Scenario: Get rule version history returns "OK" response
Given operation "GetRuleVersionHistory" enabled
And new "GetRuleVersionHistory" request
Given new "GetRuleVersionHistory" request
And there is a valid "security_rule" in the system
And request contains "rule_id" parameter from "security_rule.id"
When the request is sent