-
Notifications
You must be signed in to change notification settings - Fork 49
Custom Framework API Spec #2510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Custom Framework API Spec #2510
Conversation
"name": "name", | ||
} | ||
|
||
def __init__(self_, controls: List[CustomFrameworkControl], name: str, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
def __init__(self_, controls: List[CustomFrameworkControl], name: str, **kwargs): | |
def __init__(self, controls: List[CustomFrameworkControl], name: str, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
} | ||
|
||
def __init__( | ||
self_, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
self_, | |
self, |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
"data": "data", | ||
} | ||
|
||
def __init__(self_, data: CustomFrameworkData, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
def __init__(self_, data: CustomFrameworkData, **kwargs): | |
def __init__(self, data: CustomFrameworkData, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
} | ||
|
||
def __init__( | ||
self_, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
self_, | |
self, |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
"type": "type", | ||
} | ||
|
||
def __init__(self_, attributes: CustomFrameworkDataAttributes, type: CustomFrameworkType, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
def __init__(self_, attributes: CustomFrameworkDataAttributes, type: CustomFrameworkType, **kwargs): | |
def __init__(self, attributes: CustomFrameworkDataAttributes, type: CustomFrameworkType, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
"data": "data", | ||
} | ||
|
||
def __init__(self_, data: CustomFrameworkData, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
def __init__(self_, data: CustomFrameworkData, **kwargs): | |
def __init__(self, data: CustomFrameworkData, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
"type": "type", | ||
} | ||
|
||
def __init__(self_, attributes: CustomFrameworkDataHandleAndVersion, type: CustomFrameworkType, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
def __init__(self_, attributes: CustomFrameworkDataHandleAndVersion, type: CustomFrameworkType, **kwargs): | |
def __init__(self, attributes: CustomFrameworkDataHandleAndVersion, type: CustomFrameworkType, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
"rules_id": "rules_id", | ||
} | ||
|
||
def __init__(self_, name: str, rules_id: List[str], **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
def __init__(self_, name: str, rules_id: List[str], **kwargs): | |
def __init__(self, name: str, rules_id: List[str], **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
"data": "data", | ||
} | ||
|
||
def __init__(self_, data: FullCustomFrameworkData, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
def __init__(self_, data: FullCustomFrameworkData, **kwargs): | |
def __init__(self, data: FullCustomFrameworkData, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
"type": "type", | ||
} | ||
|
||
def __init__(self_, attributes: FullCustomFrameworkDataAttributes, type: CustomFrameworkType, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
def __init__(self_, attributes: FullCustomFrameworkDataAttributes, type: CustomFrameworkType, **kwargs): | |
def __init__(self, attributes: FullCustomFrameworkDataAttributes, type: CustomFrameworkType, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
985581e
to
cb88124
Compare
"type": "type", | ||
} | ||
|
||
def __init__(self_, attributes: FullCustomFrameworkDataAttributes, id: str, type: CustomFrameworkType, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
def __init__(self_, attributes: FullCustomFrameworkDataAttributes, id: str, type: CustomFrameworkType, **kwargs): | |
def __init__(self, attributes: FullCustomFrameworkDataAttributes, id: str, type: CustomFrameworkType, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
57c4701
to
cd83e71
Compare
"version": "version", | ||
} | ||
|
||
def __init__(self_, handle: Union[str, UnsetType] = unset, version: Union[str, UnsetType] = unset, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
def __init__(self_, handle: Union[str, UnsetType] = unset, version: Union[str, UnsetType] = unset, **kwargs): | |
def __init__(self, handle: Union[str, UnsetType] = unset, version: Union[str, UnsetType] = unset, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
} | ||
|
||
def __init__( | ||
self_, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
self_, | |
self, |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
"type": "type", | ||
} | ||
|
||
def __init__(self_, attributes: CustomFrameworkDataHandleAndVersion, id: str, type: CustomFrameworkType, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
def __init__(self_, attributes: CustomFrameworkDataHandleAndVersion, id: str, type: CustomFrameworkType, **kwargs): | |
def __init__(self, attributes: CustomFrameworkDataHandleAndVersion, id: str, type: CustomFrameworkType, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
} | ||
|
||
def __init__( | ||
self_, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
self_, | |
self, |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
"data": "data", | ||
} | ||
|
||
def __init__(self_, data: CustomFrameworkMetadata, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
def __init__(self_, data: CustomFrameworkMetadata, **kwargs): | |
def __init__(self, data: CustomFrameworkMetadata, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
cd83e71
to
ec85d90
Compare
ec85d90
to
6de8e21
Compare
See DataDog/datadog-api-spec#3739
Test branch datadog-api-spec/test/vbarth/neha.konjeti/custom-framework