[languagedetection] Refactor languagemodels package #33356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidor
added
changelog/no-changelog
qa/done
guyarb
approved these changes
Jan 27, 2025
adel121
approved these changes
Jan 31, 2025
|
/merge |
Devflow running:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This pull request introduces a refactoring opportunity I identified while working on related tasks.
While working on the
workloadmetadefinition package, I noticed that it depended on bothpkg/languagedetection/languagemodelsandpkg/languagedetection/util(the latter further depends onpkg/util/kubernetes).From the perspective of the
workloadmetastore, we only need some types, so I expected them to reside inpkg/languagedetection/languagemodels. However, they were actually scattered betweenpkg/languagedetection/languagemodelsandpkg/languagedetection/util, with some duplicate types, such as "LanguageName".This pull request consolidates all the types/models from
pkg/languagedetection/utilintopkg/languagedetection/languagemodelsfor the sake of clarity.Describe how you validated your changes
This refactor should be covered by tests.