Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block DisruptionCrons at ValidateCreate if their target does not exist #957

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ptnapoleon
Copy link
Contributor

What does this PR do?

  • Adds new functionality
  • Alters existing functionality
  • Fixes a bug
  • Improves documentation or testing

Please briefly describe your changes as well as the motivation behind them:

  • Just a proposal, it has to move cron_rollout_helpers into v1beta1 to avoid cyclic imports. Also runs the risk of a "not found" from the api causing us to reject a legitimate dicron. But is that likely? Needs to be tested

Code Quality Checklist

  • The documentation is up to date.
  • My code is sufficiently commented and passes continuous integration checks.
  • I have signed my commit (see Contributing Docs).

Testing

  • I leveraged continuous integration testing
    • by depending on existing unit tests or end-to-end tests.
    • by adding new unit tests or end-to-end tests.
  • I manually tested the following steps:
    • x
    • locally.
    • as a canary deployment to a cluster.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 7, 2025

Datadog Report

Branch report: philip.thompson/assert-resource-exists
Commit report: 0a14cb6
Test service: chaos-controller

✅ 0 Failed, 892 Passed, 8 Skipped, 11m 21.49s Total Time

@clairecng
Copy link
Contributor

I think it makes sense!

@ptnapoleon ptnapoleon force-pushed the philip.thompson/assert-resource-exists branch from ca989ce to 73ccb72 Compare March 10, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants