-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Improve context properties sanitization #3475
base: main
Are you sure you want to change the base?
Conversation
display.warn(`The property ${key} of ${name} is required; context will not be sent to the intake.`) | ||
} | ||
} | ||
|
||
return newContext | ||
} | ||
|
||
function isNullish(value: unknown) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💬 suggestion: isNullish
is not very explicit. Maybe rename to isDefined
?
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3475 +/- ##
=======================================
Coverage 91.98% 91.99%
=======================================
Files 310 310
Lines 8026 8028 +2
Branches 1820 1821 +1
=======================================
+ Hits 7383 7385 +2
Misses 643 643 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Motivation
Certain context properties like
usr.id
andusr.name
are converted to strings. This PR stops convertingundefined
andnull
values to strings, aligning the behavior with other context properties.ex:
Changes
Testing
I have gone over the contributing documentation.