Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Use a more specific chunk name for recorder #3331

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

romulof
Copy link

@romulof romulof commented Feb 7, 2025

Motivation

When RUM SDK async loads recorder, it instructs webpack to use the name recorder for the chunk. Declarin a name is nice, as it keep awareness of the purpose of the file, but the name recorder might conflict with other people's chunk names.

Changes

Simply rename recorder chunk name to datadog-recorder, making clear its origin and purpose, while avoiding possible conflicts.

Testing

Build and check the chunk name in build output directory.

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@romulof romulof requested a review from a team as a code owner February 7, 2025 17:04
@bits-bot
Copy link

bits-bot commented Feb 7, 2025

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants