Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test smarter, not harder #5166

Merged
merged 3 commits into from
Nov 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ To be copied to the [draft changelog](https://github.com/DataBiosphere/toil/wiki

## Reviewer Checklist

<!-- To be kept in sync with docs/contributing/checklist.rst -->
<!-- To be kept in sync with docs/contributing/checklists.rst -->

* [ ] Make sure it is coming from `issues/XXXX-fix-the-thing` in the Toil repo, or from an external repo.
* [ ] If it is coming from an external repo, make sure to pull it in for CI with:
Expand All @@ -26,10 +26,10 @@ To be copied to the [draft changelog](https://github.com/DataBiosphere/toil/wiki

## Merger Checklist

<!-- To be kept in sync with docs/contributing/checklist.rst -->
<!-- To be kept in sync with docs/contributing/checklists.rst -->

* [ ] Make sure the PR passes tests.
* [ ] Make sure the PR has been reviewed **since its last modification**. If not, review it.
* [ ] Make sure the PR passed tests, including the Gitlab tests, for the most recent commit in its branch.
* [ ] Make sure the PR has been reviewed. If not, review it. If it has been reviewed and any requested changes seem to have been addressed, proceed.
* [ ] Merge with the Github "Squash and merge" feature.
* [ ] If there are multiple authors' commits, add [Co-authored-by](https://github.blog/2018-01-29-commit-together-with-co-authors/) to give credit to all contributing authors.
* [ ] Copy its recommended changelog entry to the [Draft Changelog](https://github.com/DataBiosphere/toil/wiki/Draft-Changelog).
Expand Down
11 changes: 11 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,18 @@ updates:
directory: "/" # Location of package manifests
schedule:
interval: "daily"
ignore:
# htcondor is not under CI
- dependency-name: "htcondor"
# Google cloud/storage is not under CI
- dependency-name: "apache-libcloud"
- dependency-name: "google-cloud-storage"
- dependency-name: "google-auth"
- package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: "weekly"
# Don't constantly rebase all the dependency bump PRs whenever anything else
# merges; this causes too many CI runs.
rebase-strategy: ignore

24 changes: 0 additions & 24 deletions .github/workflows/autoupdate.yaml

This file was deleted.

4 changes: 2 additions & 2 deletions docs/contributing/checklists.rst
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ This checklist is to be kept in sync with the checklist in the pull request temp

When merging a PR, do the following:

* |X| Make sure the PR passes tests.
* |X| Make sure the PR has been reviewed **since its last modification**. If not, review it.
* |X| Make sure the PR passed tests, including the Gitlab tests, for the most recent commit in its branch.
* |X| Make sure the PR has been reviewed. If not, review it. If it has been reviewed and any requested changes seem to have been addressed, proceed.
* |X| Merge with the Github "Squash and merge" feature.
* |X| If there are multiple authors' commits, add `Co-authored-by`_ to give credit to all contributing authors.
.. _Co-authored-by: https://github.blog/2018-01-29-commit-together-with-co-authors/
Expand Down