Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Megamerge #4464

Merged
merged 37 commits into from
May 5, 2023
Merged

Megamerge #4464

merged 37 commits into from
May 5, 2023

Conversation

adamnovak
Copy link
Member

On top of #4460, this includes external PRs #4440, #4456, and #4458. I have created one mega-branch to avoid CI hell trying to get the external branches all rebased on top of each other. I also made what looked like necessary changes to the external code.

DailyDreaming and others added 30 commits February 2, 2023 21:43
…ve. Otherwise get this error, toil-cwl-runner: error: argument --user-space-docker-cmd: not allowed with argument --custom-net.
Co-authored-by: Michael R. Crusoe <[email protected]>
Co-authored-by: Michael R. Crusoe <[email protected]>
@adamnovak adamnovak requested a review from DailyDreaming May 4, 2023 22:07
Copy link
Member

@DailyDreaming DailyDreaming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. See #4460 for (very minor) comments.

@adamnovak adamnovak merged commit f529973 into master May 5, 2023
@mr-c mr-c deleted the megamerge branch May 6, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants