AJ-1451: Simplify and improve pact boilerplate. #1527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nawatts
approved these changes
Nov 14, 2023
jladieu
force-pushed
the
improve-pact-boilerplate
branch
from
1c07f0b to
2106d46
Compare
|
@nawatts I converged on referring to 'Pact Broker' as the actor/product in the human friendly text, consistent with how it's mentioned in |
davidangb
approved these changes
Nov 14, 2023
| > /tmp/pact-ro-username.key | ||
|
|
||
| vault read -field=basic_auth_read_only_password secret/dsp/pact-broker/users/read-only \ | ||
| > /tmp/pact-ro-password.key |
There was a problem hiding this comment.
this will need to change when Vault goes away, it's good for now
Inspired by DataBiosphere/jade-data-repo#1528, this is intended to improve the documentation and first time experience for running pact tests locally.
jladieu
force-pushed
the
improve-pact-boilerplate
branch
from
904b031 to
06b62c0
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: AJ-1451
Inspired by DataBiosphere/jade-data-repo#1528, this is intended to improve the documentation and first time experience for running pact tests locally in the wsm codebase.