UIE-206 App Startup - unit tests pt1 #5246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msilva-broad
force-pushed
the
msilva/UIE-206_startup-unit-tests_pt1
branch
from
a26a40a to
055818d
Compare
- initial code shift to callable (and testable) functions.
- added unit test coverage and light ts conversions. - removed ajax module mocks that somenow snuck back into some other test files.
- removed one last orphaned ajax module mock.
msilva-broad
commented
Feb 10, 2025
| import('src/libs/axe-core'); | ||
| } | ||
| }); | ||
| doAppLoad(); |
There was a problem hiding this comment.
all the logic above got moved to a unit-testable function in src/libs/startup/app-loader.ts
msilva-broad
changed the title
|
I was able to create / delete a Galaxy app when testing, only found a small type, |
LizBaldo
approved these changes
Feb 11, 2025
| @@ -100,3 +100,17 @@ describe('makeSuccess', () => { | |||
| expect(responseBody).toEqual({ message: 'Success' }); | |||
| }); | |||
| }); | |||
|
|
|||
| describe('mountAjaxOverrideUtils', () => { | |||
| it('mounts uitls for use by end2end tests', () => { | |||
- fixed test name typo
salonishah11
approved these changes
Feb 12, 2025
|
lucymcnatt
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: https://broadworkbench.atlassian.net/browse/UIE-206
Summary of changes:
What
Why
Testing strategy