TSPS-447 add file suffix to pipeline details response, update array_impuation version, remove admin update pipeline regex #207
Conversation
add file_suffix value to pipeline details inputs section removed regex that forced tool version to match pipeline version
| @@ -91,7 +91,8 @@ static ApiPipelineWithDetails pipelineWithDetailsToApi(Pipeline pipelineInfo) { | |||
| new ApiPipelineUserProvidedInputDefinition() | |||
| .name(input.getName()) | |||
| .type(input.getType().toString()) | |||
| .isRequired(input.isRequired())) | |||
| .isRequired(input.isRequired()) | |||
| .fileSuffix(input.getFileSuffix())) | |||
There was a problem hiding this comment.
I think if this is null it just won't show up in the response json, is that right? Can you put an example response in the PR description that shows both file and non file types (ie the array imputation response)?
There was a problem hiding this comment.
Nvm I see the screenshots now, thanks!
|
|
||
| // ensure that major version of toolVersion matches the value of the pipeline version. |
| @@ -62,7 +62,7 @@ void getCorrectNumberOfPipelines() { | |||
| pipelinesRepository.save( | |||
| new Pipeline( | |||
| PipelinesEnum.ARRAY_IMPUTATION, | |||
| 1, | |||
| 2, | |||
There was a problem hiding this comment.
Should we make this the current test version + 1? Don't feel strongly, there aren't as many places to update as I feared
There was a problem hiding this comment.
ooo this feels nicer, yea lemme do that
There was a problem hiding this comment.
ended up creating a variable in that test class as it wasnt really used anywhere else to warrant putting it in teh test utils
|
add file_suffix value to pipeline details inputs section
removed regex that forced tool version to match pipeline version
update array_imputation version to 1
Description
Please replace this description with a concise description of this Pull Request.
Jira Ticket
https://broadworkbench.atlassian.net/browse/TSPS-447
Checklist (provide links to changes)
updated e2e test to match these version changes - update array_imputation to version 1 to match service changes broadinstitute/dsp-reusable-workflows#73