-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TSPS-384 rename wdl specific columns #204
Conversation
…_name in pipelines and pipeline_runs tables also update deprecated MockBeans annotation to MockitoBean
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, one question about renaming the wdlUrl field
@@ -81,8 +81,8 @@ public Pipeline( | |||
String description, | |||
String pipelineType, | |||
String wdlUrl, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we think it doesn't make sense to rename wdlUrl as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think that field is actually specific to a wdl pipeline so i think its ok to keep that as is. Or we rename it if we feel like a url is necessary to set up the config for different types of pipelines but i cant think of what url like CAS would need for setup. I think eventually we'll want a whole table for each type of pipeline and stuff liek wdlUrl would go there but no need to split that out now until we see a second pipeline type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense to me, thanks!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for making these changes!
Description
We want to update our tables / api to not be so wdl specific where possible so its easier to add non wdl pipelines in the future w/o having to change terminology as much
Jira Ticket
https://broadworkbench.atlassian.net/browse/TSPS-384
Checklist (provide links to changes)
PR to update e2e test - TSPS-384 updating teaspoons e2e test with latest api changes broadinstitute/dsp-reusable-workflows#71
TSPS-384 update test code to work with latest changes to teaspoons service terra-scientific-pipelines-service-cli#43