Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSPS-384 rename wdl specific columns #204

Merged
merged 1 commit into from
Feb 20, 2025
Merged

TSPS-384 rename wdl specific columns #204

merged 1 commit into from
Feb 20, 2025

Conversation

jsotobroad
Copy link
Collaborator

@jsotobroad jsotobroad commented Feb 20, 2025

Description

We want to update our tables / api to not be so wdl specific where possible so its easier to add non wdl pipelines in the future w/o having to change terminology as much

  • rename wdl_method_version to tool_version and wdl_method_name to tool_name in pipelines and pipeline_runs tables
  • also update deprecated MockBeans annotation to MockitoBean

Jira Ticket

https://broadworkbench.atlassian.net/browse/TSPS-384

Checklist (provide links to changes)

…_name in pipelines and pipeline_runs tables

also update deprecated MockBeans annotation to MockitoBean
Copy link
Collaborator

@mmorgantaylor mmorgantaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, one question about renaming the wdlUrl field

@@ -81,8 +81,8 @@ public Pipeline(
String description,
String pipelineType,
String wdlUrl,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we think it doesn't make sense to rename wdlUrl as well?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think that field is actually specific to a wdl pipeline so i think its ok to keep that as is. Or we rename it if we feel like a url is necessary to set up the config for different types of pipelines but i cant think of what url like CAS would need for setup. I think eventually we'll want a whole table for each type of pipeline and stuff liek wdlUrl would go there but no need to split that out now until we see a second pipeline type

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me, thanks!

Copy link
Collaborator

@mmorgantaylor mmorgantaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for making these changes!

@jsotobroad jsotobroad merged commit 8564139 into main Feb 20, 2025
15 checks passed
@jsotobroad jsotobroad deleted the js_TSPS-384 branch February 20, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants