-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TSPS-404 Update to TCL 1.1.36 to get 401 response for Sam user not found #202
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me (but I'm not sure how to verify the corrected behavior).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is a 401 the only new code we shoudl be getting or also 403 or 404s?
only 401. TCL receives the 403 from Sam and converts it to a 401. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect, thank you!
Description
With this change, we now get back a 401 rather than a 500 from TCL/Sam when Sam doesn't recognize the user calling a Teaspoons API endpoint.
This supports a PR in the terralab repo: DataBiosphere/terra-scientific-pipelines-service-cli#42
Jira Ticket
https://broadworkbench.atlassian.net/browse/TSPS-404
Checklist (provide links to changes)