Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSPS-404 Update to TCL 1.1.36 to get 401 response for Sam user not found #202

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

mmorgantaylor
Copy link
Collaborator

@mmorgantaylor mmorgantaylor commented Feb 18, 2025

Description

With this change, we now get back a 401 rather than a 500 from TCL/Sam when Sam doesn't recognize the user calling a Teaspoons API endpoint.

This supports a PR in the terralab repo: DataBiosphere/terra-scientific-pipelines-service-cli#42

{
  "message": "User not found",
  "statusCode": 401,
  "causes": []
}

Jira Ticket

https://broadworkbench.atlassian.net/browse/TSPS-404

Checklist (provide links to changes)

@mmorgantaylor mmorgantaylor changed the title TSPS0404 Update to TCL 1.1.36 to get 401 response for Sam user not found TSPS-404 Update to TCL 1.1.36 to get 401 response for Sam user not found Feb 18, 2025
@mmorgantaylor mmorgantaylor marked this pull request as ready for review February 18, 2025 18:45
Copy link

@gbggrant gbggrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (but I'm not sure how to verify the corrected behavior).

Copy link
Collaborator

@jsotobroad jsotobroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is a 401 the only new code we shoudl be getting or also 403 or 404s?

@mmorgantaylor
Copy link
Collaborator Author

is a 401 the only new code we shoudl be getting or also 403 or 404s?

only 401. TCL receives the 403 from Sam and converts it to a 401.

Copy link
Collaborator

@jsotobroad jsotobroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect, thank you!

@mmorgantaylor mmorgantaylor merged commit d1a6e52 into main Feb 19, 2025
15 checks passed
@mmorgantaylor mmorgantaylor deleted the TSPS-404_new_terra_users branch February 19, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants