Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSPS-423 add smoke test for teaspoons #191

Merged
merged 3 commits into from
Jan 22, 2025
Merged

TSPS-423 add smoke test for teaspoons #191

merged 3 commits into from
Jan 22, 2025

Conversation

jsotobroad
Copy link
Collaborator

@jsotobroad jsotobroad commented Jan 21, 2025

Description

For production readiness, we want to be able to run a smoke test against a deployment of teaspoons that will test the system quickly and with more confidence than a straight "/status" check. This is a first pass at creating that test

This PR is related to https://github.com/broadinstitute/terra-github-workflows/pull/222

Jira Ticket

https://broadworkbench.atlassian.net/browse/TSPS-423

example manual run of the smoke_test.py script
Screenshot 2025-01-21 at 6 46 04 PM

Copy link
Collaborator

@mmorgantaylor mmorgantaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks super. what do you think of adding a query to the jobs endpoint (that'd make sure Stairway is working)? basically just make sure we get back a 200.

from ..teaspoons_smoke_test_case import TeaspoonsSmokeTestCase


class TeaspoonsPipelineRunsListTests(TeaspoonsSmokeTestCase):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are really quite clear, but it would make it even easier to quickly understand what we're testing if we add a docstring explaining what gets tested in each class of tests

@jsotobroad
Copy link
Collaborator Author

this looks super. what do you think of adding a query to the jobs endpoint (that'd make sure Stairway is working)? basically just make sure we get back a 200.

i like it

add pydocs to smoke test python classes
add test for jobs list endpoint for more coverage
Copy link
Collaborator

@mmorgantaylor mmorgantaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, looks great!

@jsotobroad jsotobroad merged commit f176b04 into main Jan 22, 2025
15 checks passed
@jsotobroad jsotobroad deleted the js_TSPS-423 branch January 22, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants