TSPS-424 add dsde qa slack notification to e2e test workflow #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsotobroad
commented
Jan 17, 2025
.github/workflows/run-e2e-tests.yaml
Outdated
| @@ -131,3 +131,11 @@ jobs: | |||
| notify-slack-channels-upon-workflow-completion: "#terra-teaspoons-alerts" | |||
| permissions: | |||
| id-token: write | |||
|
|
|||
| report-workflow-to-qa: | |||
There was a problem hiding this comment.
not sure i like this option vs having a "slack channel" parameter that sends the notification to that channel only. The only downside to that is that we wouldnt be able to look in one channel for all the e2e test results.
|
mmorgantaylor
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need to notify #dsde-qa when our post deploy hook staging e2e workflow completes. This is one way to do that and im not sure i love it.
We also removed the cron job component of this test on top of adding the ability to run this test on merges to main
This PR accomplishes a similar thing to DataBiosphere/terra-scientific-pipelines-service-cli#29 in the cli repo
Jira Ticket
https://broadworkbench.atlassian.net/browse/TSPS-424