Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error message and sanity check for signed URL generation. #388

Merged
merged 3 commits into from
Jun 30, 2022
Merged

Better error message and sanity check for signed URL generation. #388

merged 3 commits into from
Jun 30, 2022

Conversation

DailyDreaming
Copy link
Member

No description provided.

@DailyDreaming
Copy link
Member Author

Tests are failing because the firecloud library is broken on python3.10: #390

mbaumann-broad
mbaumann-broad requested changes Jun 30, 2022
View reviewed changes
@DailyDreaming
Copy link
Member Author

@mbaumann-broad Changes made.

mbaumann-broad
mbaumann-broad approved these changes Jun 30, 2022
View reviewed changes
Copy link
Collaborator

@mbaumann-broad mbaumann-broad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @DailyDreaming!

@DailyDreaming
Copy link
Member Author

@mbaumann-broad Thanks for the reviews!

@DailyDreaming DailyDreaming merged commit 14acca6 into master Jun 30, 2022
@DailyDreaming DailyDreaming deleted the drs-access-error-msg branch June 30, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbaumann-broad mbaumann-broad mbaumann-broad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DailyDreaming @mbaumann-broad