Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a backwards compatible layer for Azure creds #321

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

aherbst-broad
Copy link
Contributor

@aherbst-broad aherbst-broad commented Nov 14, 2023

Workspace Manager integration tests fail with the current LZ lib as WSM doesn't wire up the needed Azure credentials/login in it's CI pipeline. I've introduced a backwards compatibility layer to keep things functional there and unblock things. We will want to remove this shim once LZS is deamalgamated.

… config or the DefaultAzureCredentialsBuilder
@aherbst-broad aherbst-broad changed the title Add a backwards compatible layer for getting creds from either spring… Add a backwards compatible layer for Azure creds Nov 14, 2023
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@aherbst-broad aherbst-broad marked this pull request as ready for review November 14, 2023 15:46
@aherbst-broad aherbst-broad requested review from a team, blakery and sergiygetlin and removed request for a team November 14, 2023 15:46
@aherbst-broad aherbst-broad merged commit acee48f into main Nov 14, 2023
@aherbst-broad aherbst-broad deleted the arh-wor-1299-wsm-backwards-compatibility branch November 14, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants