Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup stairway serialization tests and fix a few other warnings #199

Merged
merged 5 commits into from
Jan 7, 2025
Merged

Cleanup stairway serialization tests and fix a few other warnings #199

merged 5 commits into from
Jan 7, 2025

Conversation

pshapiro4broad
Copy link
Member

@pshapiro4broad pshapiro4broad commented Sep 9, 2024 •
edited
Loading

A few test related cleanups

  • remove pmd / quality plugin as its functionality is subsumed by the sonar scan
  • fix sonar warnings about calling unnecessary functions inside an assertThrows()
  • refactor common code that tests Stairway serialization for tcl objects and use stairway's ObjectMapper instead of a duplicate
  • replace casts with generics, or use type parameter to avoid casting
  • in modified files, replace wildcard imports with explicit imports, remove unnecessary public

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 3, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

davidangb
davidangb approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@davidangb davidangb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question inline, otherwise looks good.

src/test/java/bio/terra/common/db/DatabaseRetryUtilsTest.java Show resolved Hide resolved
@pshapiro4broad pshapiro4broad merged commit 7b730fe into develop Jan 7, 2025
3 checks passed
@pshapiro4broad pshapiro4broad deleted the ps/test-cleanups branch January 7, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvoet dvoet dvoet approved these changes

@davidangb davidangb davidangb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pshapiro4broad @dvoet @davidangb