[PF-2983] Minor version upgrades that should be low risk #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cahrens
requested review from
nawatts,
a team and
dvoet
and removed request for
a team
nawatts
approved these changes
Feb 16, 2024
pshapiro4broad
approved these changes
Feb 26, 2024
| @@ -41,7 +41,7 @@ public class FlagsmithService { | |||
| * @param feature the name of the feature | |||
| */ | |||
| public Optional<Boolean> isFeatureEnabled(String feature) { | |||
| return isFeatureEnabled(feature, /*userEmail=*/ null); | |||
| return isFeatureEnabled(feature, /* userEmail= */ null); | |||
There was a problem hiding this comment.
Interesting, did spotless change their rules? Anyway I would delete these comments rather than reformat, they don't seem to add value IMO. But maybe others really like them?
There was a problem hiding this comment.
Thanks for reviewing!
Yes, spotless changed their rules. I don't have a strong feeling about the comments, and generally prefer to just automatically reformat the files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls out some test and quality minor version upgrades from #134.
0.2.30.2.6Sonarcube: https://github.com/SonarSource/sonar-scanner-gradle/releases
JUnit change notes: https://github.com/junit-team/junit5/releases
Jackson change notes: https://github.com/OpenAPITools/jackson-databind-nullable/releases