Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use helmchart name for pact identifier. #310

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Use helmchart name for pact identifier. #310

merged 1 commit into from
Nov 3, 2023

Conversation

jladieu
Copy link
Contributor

@jladieu jladieu commented Nov 3, 2023 •
edited by jira bot
Loading

Prefer helmchart name as the pacticipant identifier:

  • bpm-provider -> bpm
  • bpm-consumer -> bpm
  • sam-provider -> sam
  • See thread discussing the -consumer and -provider suffix anti-pattern.
  • See thread discussing the recommendation to use the helm chart name.

Unblocks:

Tickets:
AJ-1428 - General maintenance ticket.
AJ-1234 - Adjacent / similar, but not strictly dependent work.

@jladieu
Use helmchart name for pact identifier.
461a87a 
Prefer helmchart name as the pacticipant identifier:
* `bpm-provider` -> `bpm`
* `bpm-consumer` -> `bpm`
* `sam-provider` -> `sam`
* See [thread](https://broadinstitute.slack.com/archives/C043YJ40719/p1698068076950019) discussing the `-consumer` and `-provider` suffix anti-pattern.
* See [thread](https://broadinstitute.slack.com/archives/C043YJ40719/p1698241095600099) discussing the recommendation to use the helm chart name.

Unblocks:
* broadinstitute/rawls#2610
* DataBiosphere/terra-workspace-manager#1511
* broadinstitute/sam#1234
@jladieu jladieu requested a review from blakery November 3, 2023 12:53
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

blakery
blakery approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@blakery blakery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

@jladieu jladieu requested review from a team and cahrens and removed request for a team November 3, 2023 13:29
@jladieu
Copy link
Contributor Author

jladieu commented Nov 3, 2023

Thanks for the speedy reviews!

@jladieu jladieu merged commit 989469a into main Nov 3, 2023
@jladieu jladieu deleted the use-helmchart-name-for-pacticipant-id branch November 3, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahrens cahrens cahrens approved these changes

@blakery blakery blakery approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jladieu @cahrens @blakery