-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PF-2987]: Bump org.yaml:snakeyaml from 1.27 to 2.2 #122
[PF-2987]: Bump org.yaml:snakeyaml from 1.27 to 2.2 #122
Conversation
Bumps [org.yaml:snakeyaml](https://bitbucket.org/snakeyaml/snakeyaml) from 1.27 to 2.2. - [Commits](https://bitbucket.org/snakeyaml/snakeyaml/branches/compare/snakeyaml-2.2..snakeyaml-1.27) --- updated-dependencies: - dependency-name: org.yaml:snakeyaml dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
The following labels could not be found: |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many tests failed with java.lang.NoSuchMethodError
, I suspect there is a broken runtime dependency with this upgrade.
Swapping myself in as reviewer for AJ as Nick is OOO this week -- @rtitle, I'm not sure we're a great stakeholder for this PR as we're not actively working on any direct dependents of stairway -- should we just direct dependabot to ignore this major upgrade, or is there another team with more context that we should loop in? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing my response to "request changes" to flag that this needs work to fix.
@dependabot rebase |
Looks like org.yaml:snakeyaml is no longer a dependency, so this is no longer needed. |
Bumps org.yaml:snakeyaml from 1.27 to 2.2.
Commits
313f40a
Add mote tests for issue 1065d236260
Improve test9905de1
Issue 1064: use identity in toString() for sequencese3b3d8f
Issue 1064: improve test23a21dd
Issue 1064: improve node representation453196e
Merge branch 'master' into issue1065-doc-limitd07cb52
Add CodeLimitTest2b8173a
Improve commentsf75151d
Merge remote-tracking branch 'origin/master'30620b2
Issue 1065: Respect document start token when limiting the document sizeYou can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)