Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move abort button #797

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Move abort button #797

merged 2 commits into from
Jan 9, 2025

Conversation

lucymcnatt
Copy link
Contributor

@lucymcnatt lucymcnatt commented Jan 7, 2025

Abort and "Go back" buttons are in the same place in the job manager UI
A user can easily accidentally hit the abort button when trying to go back

(Also updated the readme because docker-compose is deprecated)

@jgainerdewar jgainerdewar self-requested a review January 7, 2025 18:45
@jgainerdewar
Copy link
Collaborator

I hate to destroy the purity of this beautiful cut/paste PR, but I think the styling in the new location is a little awkward:
Screenshot 2025-01-07 at 2 48 50 PM

Maybe we can left-align it in the gray box and center-align it vertically? Can also move the button between the workflow id and the gray box if that's easier.

@salonishah11 salonishah11 self-requested a review January 8, 2025 16:11
Copy link
Collaborator

@jgainerdewar jgainerdewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those README changes!

@lucymcnatt lucymcnatt merged commit 9231323 into master Jan 9, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants