CORE-208: include stack traces in InvalidPfbExceptions #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: 3643595 | Previous: 68dcbd4 | Ratio |
|---|---|---|---|
bio.terra.pfb.LibraryBenchmarks.showNodesMedium |
1933.7613395079065 ops/s |
1859.7220972334542 ops/s |
1.04 |
bio.terra.pfb.LibraryBenchmarks.showNodesSmall |
24861.837612940726 ops/s |
24782.004073882654 ops/s |
1.00 |
bio.terra.pfb.PfbReaderBenchmarks.convertEnum |
5260558.121848094 ops/s |
5256141.2115673125 ops/s |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
calypsomatic
approved these changes
Dec 4, 2024
We shouldn't bubble up a stack trace to the user. But, that'll be WDS's job to scrub; here in the library we're not doing anything user-facing. We didn't even give WDS the option to hide or display the stack trace! |
marctalbott
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading the nodes of a PFB, we may throw
InvalidPfbException. When we threw that, we omitted the stack trace. This makes debugging inside cWDS pretty hard; we can't see the underlying error that caused the problem.This is a small PR to include the underlying cause in those exceptions.