DT-1194: Fix issue where using Awaitility was causing code to run on a different thread #1903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshapiro4broad
requested review from
snf2ye and
s-rubenstein
and removed request for
a team
|
snf2ye
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: https://broadworkbench.atlassian.net/browse/DT-1194
Addresses
Using
Awaitilityinstead ofsleep()causes code to run on a different thread. Any thread-local data must be extracted before callingAwaitility.Summary of changes
Move calls to
steward()out of theAwaitiltymethod call. This problem was noticed and fixed while working on #1896, but the fix was inadvertently lost while reverting other unnecessary changes.Testing Strategy
Integration tests pass without need to retry.