DT-1182: Fix issue where integration tests would delete the jade service account #1897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… being _deleted_ by running integration tests
pshapiro4broad
requested review from
rushtong and
rjohanek
and removed request for
a team
|
rjohanek
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: https://broadworkbench.atlassian.net/browse/DT-1182
Addresses
Fix issue where an empty service account email would result in the SA being deleted when running integration tests
Summary of changes
The previous change replaced
ApplicationConfigurationwithIntegrationTestConfiguration, so integration tests would have a more limited application context (e.g., not including a database connection). To satisfy thetdrServiceAccountEmailinjection I added a stub method to return an empty string, which seemed to work fine (as this value isn't needed for tests to work correctly). However, it's used during teardown to prevent the test from deleting a service account. This use wasn't immediately apparent so the change was merged.The fixed code uses the
ApplicationConfigurationimplementation to return the service account email.Testing Strategy
After integration tests run, verify that the service account is still present.